ShockVPN/shockbot
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: more improvement and reproducibility

Browse Source
This commit is contained in:
wolfy
2026-05-31 16:24:09 -05:00
parent fc11b91851
commit 37d15a338d
2 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
modes.ts
+6 -2
View File
@@ -391,7 +391,9 @@ For simple, well-defined tasks, skip the plan phase and go straight to build.`,
7. **submit**: ALWAYS submit exactly one review via \`${t("create_pull_request_review")}\`. Do NOT call \`report_progress\` — the review is the final record and the progress comment will be cleaned up automatically.
**MANDATORY pre-submission self-check**: before calling \`${t("create_pull_request_review")}\`, scan your draft body for \`### \` sections. For each one that mentions a specific file and line number, move it to the \`comments\` array as an inline comment instead. A \`### \` section in the body is ONLY justified when it has NO specific line to anchor to. If you have 3+ body sections that all have file:line references, you have made an error — convert them.
**MANDATORY pre-submission self-check**: before calling \`${t("create_pull_request_review")}\`, do both of these:
1. For each finding already in your \`comments\` array: verify it does NOT also appear as a \`### \` section in the body. A finding goes in ONE place only — inline comment OR body section, never both. If it has a line anchor it goes inline; remove the duplicate body section.
2. For each \`### \` section in the body that mentions a specific file and line number: move it to the \`comments\` array as an inline comment and remove it from the body. Body sections are ONLY for concerns with NO specific line anchor.
note: the first create_pull_request_review submission may error with a one-time diff-coverage nudge listing unread TOC regions. retry the same call to proceed — optionally after reading the listed ranges. the pre-flight will not block again this session.
@@ -510,7 +512,9 @@ ${PR_SUMMARY_FORMAT}`,
Same callout ladder as Review mode — \`[!CAUTION]\` (red, "will break") → \`[!IMPORTANT]\` (purple, "must address before merging") → \`> ℹ️ ...\` (informational, "minor suggestions only") → \`> ✅ ...\` (green friendly, "no concerns"). Same Fix-button lever: the footer renders a Fix button on every non-approving review, so \`approved: true\` suppresses it. Wrapping mergeable feedback in \`[!IMPORTANT]\` trains users to click Fix on reviews that don't need fixing — pick the tier the author's actual next action justifies.
**MANDATORY pre-submission self-check**: before calling \`${t("create_pull_request_review")}\`, scan your draft body for \`### \` sections. For each one that mentions a specific file and line number, move it to the \`comments\` array as an inline comment instead. A \`### \` section in the body is ONLY justified when it has NO specific line to anchor to. If you have 3+ body sections that all have file:line references, you have made an error — convert them.
**MANDATORY pre-submission self-check**: before calling \`${t("create_pull_request_review")}\`, do both of these:
1. For each finding already in your \`comments\` array: verify it does NOT also appear as a \`### \` section in the body. A finding goes in ONE place only — inline comment OR body section, never both. If it has a line anchor it goes inline; remove the duplicate body section.
2. For each \`### \` section in the body that mentions a specific file and line number: move it to the \`comments\` array as an inline comment and remove it from the body. Body sections are ONLY for concerns with NO specific line anchor.
Follow these rules:
- note: the first create_pull_request_review submission may error with a one-time diff-coverage nudge listing unread TOC regions. retry the same call to proceed — optionally after reading the listed ranges. the pre-flight will not block again this session.