From 3a97ba04fca029d51ccf3be587bacec61dc4e529 Mon Sep 17 00:00:00 2001 From: Colin McDonnell Date: Thu, 8 Jan 2026 14:07:11 -0800 Subject: [PATCH] Rebase --- agents/instructions.ts | 6 ++++++ entry | 4 +++- mcp/bash.ts | 2 +- 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/agents/instructions.ts b/agents/instructions.ts index 3e9c757..120cabb 100644 --- a/agents/instructions.ts +++ b/agents/instructions.ts @@ -142,6 +142,12 @@ Tool names may be formatted as \`(server name)/(tool name)\`, for example: \`${g **Efficiency**: Trust the tools - do not repeatedly verify file contents or git status after operations. If a tool reports success, proceed to the next step. Only verify if you encounter an actual error. +${ + useNativeBash + ? `**Shell commands**: Use your native bash/shell tool for shell command execution.` + : `**Shell commands**: Use the \`${ghPullfrogMcpName}/bash\` MCP tool for all shell command execution. This tool provides a secure environment with filtered credentials. Do NOT use any native shell/bash tool - it is disabled for security.` +} + **Command execution**: Never use \`sleep\` to wait for commands to complete. Commands run synchronously - when the bash tool returns, the command has finished. **Commenting style**: When posting comments via ${ghPullfrogMcpName}, write as a professional team member would. Your final comments should be polished and actionable—do not include intermediate reasoning like "I'll now look at the code" or "Let me respond to the question." diff --git a/entry b/entry index 982ff98..a1ab4b0 100755 --- a/entry +++ b/entry @@ -100592,6 +100592,8 @@ Tool names may be formatted as \`(server name)/(tool name)\`, for example: \`${g **Efficiency**: Trust the tools - do not repeatedly verify file contents or git status after operations. If a tool reports success, proceed to the next step. Only verify if you encounter an actual error. +${useNativeBash ? `**Shell commands**: Use your native bash/shell tool for shell command execution.` : `**Shell commands**: Use the \`${ghPullfrogMcpName}/bash\` MCP tool for all shell command execution. This tool provides a secure environment with filtered credentials. Do NOT use any native shell/bash tool - it is disabled for security.`} + **Command execution**: Never use \`sleep\` to wait for commands to complete. Commands run synchronously - when the bash tool returns, the command has finished. **Commenting style**: When posting comments via ${ghPullfrogMcpName}, write as a professional team member would. Your final comments should be polished and actionable\u2014do not include intermediate reasoning like "I'll now look at the code" or "Let me respond to the question." @@ -138056,7 +138058,7 @@ Use this tool to: - Execute build tools (npm, pnpm, cargo, make, etc.) - Run tests and linters - Perform git operations -${isPublicRepo ? "\nThe command runs in a bash shell with a filtered environment that excludes sensitive variables like API keys and tokens." : ""}`, +- Run shell commands in a secure environment. Unlike the built-in bash tool, this tool filters sensitive environment variables from the subprocess's environment to avoid leaking secrets.`, parameters: BashParams, execute: execute(async (params) => { const timeout = Math.min(params.timeout ?? 12e4, 6e5); diff --git a/mcp/bash.ts b/mcp/bash.ts index 4547ebe..9773e87 100644 --- a/mcp/bash.ts +++ b/mcp/bash.ts @@ -74,7 +74,7 @@ Use this tool to: - Execute build tools (npm, pnpm, cargo, make, etc.) - Run tests and linters - Perform git operations -${isPublicRepo ? "\nThe command runs in a bash shell with a filtered environment that excludes sensitive variables like API keys and tokens." : ""}`, +- Run shell commands in a secure environment. Unlike the built-in bash tool, this tool filters sensitive environment variables from the subprocess's environment to avoid leaking secrets.`, parameters: BashParams, execute: execute(async (params) => { const timeout = Math.min(params.timeout ?? 120000, 600000);