Agent & model refactor (#478)

* agent & model refactor with ASKPASS git auth, UI restructure, clerk v7

Made-with: Cursor

* fix stale agent/effort refs, add tests for askpass + model resolution

- reviewCleanup.ts: payload.agent -> payload.model, remove effort
- selectMode.ts PlanEdit: remove delegation/subagent/effort references
- pullfrog.yml.ts: update env vars (drop GOOGLE_API_KEY/CURSOR_API_KEY,
  add GOOGLE_GENERATIVE_AI_API_KEY/XAI_API_KEY/MOONSHOT_API_KEY/OPENCODE_API_KEY)
- FlagsSettings/RepoInstructionsSection: remove stale effort/timeout copy
- new: gitAuthServer.test.ts (10 tests — lifecycle, token delivery, tamper detection, script gen)
- new: agent.test.ts (4 tests — default opentoad, AGENT_OVERRIDE, invalid override)
- new: models.test.ts (19 tests — parseModel, resolution, registry invariants)
- update models.dev snapshot

Made-with: Cursor

* fix changed-agents.sh to filter legacy agent files from CI matrix

legacy agent files (claude.ts, codex.ts, etc.) are @ts-nocheck and not
exported from index.ts. changed-agents.sh now reads index.ts imports to
build the active agent set and treats changes to inactive files as
non-agent changes (opentoad canary only).

Made-with: Cursor

* remove MCP file tools, old agent harnesses, and obsolete security tests

ASKPASS-based git auth makes the old MCP file tool security layer unnecessary:
- token never in subprocess env, so symlink/gitattributes/hook attacks can't exfiltrate it
- agents now use native file tools (OpenCode builtin read/edit)

deleted:
- action/mcp/file.ts (file_read, file_write, file_edit, file_delete, list_directory)
- action/mcp/index.ts (dead re-export)
- agent harnesses: claude.ts, codex.ts, cursor.ts, gemini.ts, opencode.ts
- opencode-runner.ts (inlined into opentoad.ts)
- security tests that validated MCP file tool restrictions
- commented-out three-step review flow (~300 lines)
- sanitizeSchema/wrapSchema dead code from mcp/shared.ts
- OPENCODE_MODEL_MINI/MAX env vars (effort-level model overrides removed)

updated test prompts to use generic file ops instead of MCP tool names.
restored pkg-json-scripts + requirements-txt-attack (test --ignore-scripts defense).

Made-with: Cursor

* bump actions/checkout v4 → v6 (node 24)

node 20 actions deprecated june 2, 2026.

Made-with: Cursor

* temporarily disable fail-fast on agnostic tests to debug checkout@v6

Made-with: Cursor

* re-enable fail-fast on agnostic tests

Made-with: Cursor

* fix test token mismatch: mint OIDC tokens scoped to target repo

CI tests override GITHUB_REPOSITORY to pullfrog/test-repo but inherit
the runner's GITHUB_TOKEN (scoped to pullfrog/app), causing 401s on
every run-context fetch. Clear GITHUB_TOKEN in the test subprocess so
ensureGitHubToken() mints a properly scoped token via OIDC.

Also centralizes the default GITHUB_REPOSITORY in runAgentStreaming
instead of repeating it in every test file, and fixes preview-cleanup
to remove workers from all queues (not just name-matching ones).

Made-with: Cursor

* fix ensureGitHubToken to try OIDC when app credentials are absent

ensureGitHubToken only attempted token minting when GITHUB_APP_ID and
GITHUB_PRIVATE_KEY were set. In CI, OIDC is available but app creds
aren't exposed — so the guard prevented minting entirely.

Made-with: Cursor

* dead code cleanup: remove remnants of deleted agents, file tools, effort system

remove unused @anthropic-ai/claude-agent-sdk and @openai/codex-sdk deps,
orphaned file-tool security tests, dead GEMINI_MODEL passthrough, stale
opencode-runner wiki refs, deleted test file references, and MCP file tool
docs. rename docs/effort → docs/models. fix vitest setup: move dotenv to
globalSetup (runs once before forks instead of per-file, 19s → 200ms).

Made-with: Cursor

* address review feedback: remove dead code, update stale references

- remove AGENT_OVERRIDE (only opentoad exists)
- remove shellToolName plumbing (always restricted shell)
- bump action version to 0.0.179
- remove CURSOR_API_KEY from all workflows/configs
- remove OPENCODE_MODEL_MINI/MAX from workflows/docs
- delete wiki/effort.md, rewrite docs/effort.mdx as "Models"
- rewrite wiki/modes.md: orchestrator/subagent → single agent
- simplify flag system: drop builtin flag extraction (debug, effort,
  timeout, agent), keep custom flag replacement only
- reserve all legacy flag names to prevent custom flag conflicts

Made-with: Cursor

* regenerate lockfile after removing claude-agent-sdk and codex-sdk

Made-with: Cursor

* fix import ordering, add lockfile check to pre-push hook

Made-with: Cursor

* remove dead debug payload field, stale packageExtensions

Made-with: Cursor

* merge proc-sandbox and token-exfil into a single test

proc-sandbox and token-exfil were duplicative — both tested that
SANDBOX_TEST_TOKEN couldn't be exfiltrated. consolidated into
token-exfil with shell:restricted (which actually exercises filterEnv)
and the /proc attack vector hints from proc-sandbox.

Made-with: Cursor

* fix wiki adversarial.md to match actual tokenExfil validator

Made-with: Cursor

external.ts

@@ -4,57 +4,20 @@
  * Other files in action/ re-export from this file for backward compatibility.
  */
 
-import { type } from "arktype";
-
 // mcp name constant
 export const ghPullfrogMcpName = "gh_pullfrog";
 
-export interface AgentManifest {
-  displayName: string;
-  /** empty array means accepts any *API_KEY* env var */
-  apiKeyNames: string[];
-  url: string;
-}
-
-// agent manifest - static metadata about available agents
-export const agentsManifest = {
-  claude: {
-    displayName: "Claude Code",
-    apiKeyNames: ["ANTHROPIC_API_KEY"],
-    url: "https://claude.com/claude-code",
-  },
-  codex: {
-    displayName: "Codex CLI",
-    apiKeyNames: ["OPENAI_API_KEY"],
-    url: "https://platform.openai.com/docs/guides/codex",
-  },
-  cursor: {
-    displayName: "Cursor CLI",
-    apiKeyNames: ["CURSOR_API_KEY"],
-    url: "https://cursor.com/",
-  },
-  gemini: {
-    displayName: "Gemini CLI",
-    apiKeyNames: ["GOOGLE_API_KEY", "GEMINI_API_KEY"],
-    url: "https://ai.google.dev/gemini-api/docs",
-  },
-  opencode: {
-    displayName: "OpenCode",
-    apiKeyNames: [],
-    url: "https://opencode.ai",
-  },
-} as const satisfies Record<string, AgentManifest>;
-
-// agent name type - union of agent slugs
-export type AgentName = keyof typeof agentsManifest;
-export const AgentName = type.enumerated(...(Object.keys(agentsManifest) as AgentName[]));
-
-export type AgentApiKeyName = (typeof agentsManifest)[AgentName]["apiKeyNames"][number];
-
-// effort level type - controls model selection and thinking level
-// mini = fast/minimal, auto = balanced/default, max = maximum capability
-export const Effort = type.enumerated("mini", "auto", "max");
-export type Effort = typeof Effort.infer;
+// model alias registry lives in models.ts — re-exported here for shared access
+export type { ModelAlias, ModelProvider, ProviderConfig } from "./models.ts";
+export {
+  getModelEnvVars,
+  getModelProvider,
+  modelAliases,
+  parseModel,
+  providers,
+  resolveCliModel,
+  resolveModelSlug,
+} from "./models.ts";
 
 // tool permission types shared with server dispatch
 export type ToolPermission = "disabled" | "enabled";
@@ -280,8 +243,8 @@ export interface WriteablePayload {
   "~pullfrog": true;
   /** semantic version of the payload to ensure compatibility */
   version: string;
-  /** agent slug identifier (e.g., "claude", "codex", "gemini") */
-  agent?: AgentName | undefined;
+  /** provider/model slug (e.g. "anthropic/claude-opus") */
+  model?: string | undefined;
   /** the user's actual request (body if @pullfrog tagged) */
   prompt: string;
   /** github username of the human who triggered this workflow run */
@@ -290,16 +253,12 @@ export interface WriteablePayload {
   eventInstructions?: string | undefined;
   /** event data from webhook payload - discriminated union based on trigger field */
   event: PayloadEvent;
-  /** effort level for model selection (mini, auto, max) - defaults to "auto" */
-  effort?: Effort | undefined;
   /** timeout for agent run (e.g., "10m", "1h30m") - defaults to "1h" */
   timeout?: string | undefined;
   /** working directory for the agent */
   cwd?: string | undefined;
   /** pre-created progress comment ID for updating status */
   progressCommentId?: string | undefined;
-  /** whether debug mode is enabled (LOG_LEVEL=debug) */
-  debug?: boolean | undefined;
 }
 
 // immutable payload type for agent execution