Audit core.warning/core.error usage (#269)
* Stop using command-based logs for warnings and errors Co-authored-by: Cursor <cursoragent@cursor.com> * revert * tweak * de-noise * Remove redundant ts() timestamp prefix from log calls * Restore timestamped logging and refine debug output routing. Bring back timestamp prefixes for standard logs and make log.debug emit via core.debug when runner debug is enabled, while still surfacing debug lines for --debug runs. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com> Co-authored-by: Colin McDonnell <colinmcd94@gmail.com>
This commit is contained in:
committed by
pullfrog[bot]
parent
4ee1ae89a5
commit
70f1c47a28
+3
-3
@@ -78,7 +78,7 @@ function detectSandboxMethod(): SandboxMethod {
|
||||
}
|
||||
|
||||
detectedSandboxMethod = "none";
|
||||
log.warning("PID namespace isolation not available - falling back to env filtering only");
|
||||
log.info("PID namespace isolation not available - falling back to env filtering only");
|
||||
return "none";
|
||||
}
|
||||
|
||||
@@ -243,8 +243,8 @@ Use this tool to:
|
||||
|
||||
const finalExitCode = exitCode ?? (timedOut ? 124 : -1);
|
||||
if (finalExitCode !== 0) {
|
||||
log.error(`bash command failed with exit code ${finalExitCode}: ${params.command}`);
|
||||
if (output) log.error(`output: ${output.trim()}`);
|
||||
log.info(`bash command failed with exit code ${finalExitCode}: ${params.command}`);
|
||||
if (output) log.info(`output: ${output.trim()}`);
|
||||
}
|
||||
|
||||
return {
|
||||
|
||||
+1
-1
@@ -213,7 +213,7 @@ export function GetCheckSuiteLogsTool(ctx: ToolContext) {
|
||||
|
||||
log.debug(`analyzed logs for job ${job.name}: ${analysis.index.length} indexed lines`);
|
||||
} catch (error) {
|
||||
log.error(`failed to fetch logs for job ${job.id}: ${error}`);
|
||||
log.info(`failed to fetch logs for job ${job.id}: ${error}`);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
+1
-1
@@ -112,7 +112,7 @@ export function DelegateTool(ctx: ToolContext) {
|
||||
} catch (err) {
|
||||
// normalize agent crashes into the same return shape as clean failures
|
||||
const errorMessage = err instanceof Error ? err.message : String(err);
|
||||
log.error(`» delegation to ${selectedMode.name} crashed: ${errorMessage}`);
|
||||
log.info(`» delegation to ${selectedMode.name} crashed: ${errorMessage}`);
|
||||
return {
|
||||
success: false,
|
||||
mode: selectedMode.name,
|
||||
|
||||
@@ -632,7 +632,7 @@ export function ResolveReviewThreadTool(ctx: ToolContext) {
|
||||
const message = isResolved
|
||||
? `thread ${params.thread_id} was already resolved`
|
||||
: `failed to resolve thread ${params.thread_id}: ${errorMessage}`;
|
||||
log.warning(message);
|
||||
log.info(message);
|
||||
|
||||
return {
|
||||
thread_id: params.thread_id,
|
||||
|
||||
+1
-1
@@ -53,7 +53,7 @@ export const execute = <T, R extends Record<string, any> | string>(
|
||||
} catch (error) {
|
||||
const errorMessage = error instanceof Error ? error.message : String(error);
|
||||
const prefix = toolName ? `[${toolName}]` : "tool";
|
||||
log.error(`${prefix} error: ${errorMessage}`);
|
||||
log.info(`${prefix} error: ${errorMessage}`);
|
||||
log.debug(`${prefix} params: ${formatJsonValue(params)}`);
|
||||
return handleToolError(error);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user