ShockVPN/shockbot
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disable stop hook (runtime + dashboard) (#727)

Browse Source
This commit is contained in:
Colin McDonnell
2026-05-14 01:44:32 +00:00
committed by pullfrog[bot]
parent 56793d4a81
commit 951745ec89
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
agents/postRun.ts
+10 -4
View File
@@ -191,10 +191,16 @@ export async function collectPostRunIssues(
options: { skipSummaryStale?: boolean } = {} options: { skipSummaryStale?: boolean } = {}
): Promise<PostRunIssues> { ): Promise<PostRunIssues> {
const issues: PostRunIssues = {}; const issues: PostRunIssues = {};
if (ctx.stopScript) { // stop hook is disabled — production audit (May 2026) showed 8/9 configured
const failure = await executeStopHook(ctx.stopScript); // scripts are foot-guns (duplicates of prepushScript, run on non-committing
if (failure) issues.stopHook = failure; // modes against unchanged trees) burning the retry budget on un-fixable
} // gates. re-enable here + the dashboard block in `AgentSettings.tsx` once
// we've decided on the right semantics (mode-gating vs. HEAD-changed gating
// vs. deletion). see issue #714.
// if (ctx.stopScript) {
// const failure = await executeStopHook(ctx.stopScript);
// if (failure) issues.stopHook = failure;
// }
// dirty-tree gate fires only in modes that legitimately commit. Review / // dirty-tree gate fires only in modes that legitimately commit. Review /
// IncrementalReview / Plan complete via review submission or a Plan // IncrementalReview / Plan complete via review submission or a Plan
// comment, not by touching files — any tree dirt is incidental (e.g. a // comment, not by touching files — any tree dirt is incidental (e.g. a