console UI improvements and cleanup (#311)
* console UI improvements and cleanup - add verify workflow button and API endpoint for manual installation check - move env var check into PromptBox as blocking overlay (hoisted to RepoConsole) - extract FlagsCheatSheet modal, replace verbose flag hints everywhere - add info popovers for repo setup / post-checkout script descriptions - remove unused prAutoFixCiFailures schema fields and migration - default mentionAllowNonCollaborator to disabled for safety on public repos - update docs for triggers and getting started Co-authored-by: Cursor <cursoragent@cursor.com> * add diagnostic logging for push_branch bug investigation temporary [push-debug] logs to trace why getPushDestination falls back to origin/<localBranch> instead of using the correct remote branch name for same-repo PRs. Co-authored-by: Cursor <cursoragent@cursor.com> * add git config diagnostic to verify original bug cause Co-authored-by: Cursor <cursoragent@cursor.com> * temporarily disable StoredPushDest to test git config path Co-authored-by: Cursor <cursoragent@cursor.com> * remove diagnostic logging for push_branch investigation verified that StoredPushDest fix works correctly on preview repo. both the stored dest path and the git config fallback resolve to the correct remote branch in the GitHub Actions environment. Co-authored-by: Cursor <cursoragent@cursor.com> * fix formatting in AgentSettings and TriggersSettings Co-authored-by: Cursor <cursoragent@cursor.com> * pass derived env var state to PromptBox instead of raw secrets data eliminates duplicated derivation logic between RepoConsole and PromptBox by passing envVarMissing, envVarChecking, and agentKeyNames as props. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: prevent duplicate comment after PR review deletes progress comment progressCommentId now uses three states: undefined (no comment yet), number (active), null (deliberately deleted). After create_pull_request_review deletes the progress comment, subsequent report_progress calls skip instead of creating a new comment. Co-authored-by: Cursor <cursoragent@cursor.com> * effort descriptions, test ordering, husky, docs images, typo fix - rewrote delegation effort level descriptions to per-level breakdown - action-agents now waits for action-agnostic; action-agnostic waits for root - added husky + lint-staged (biome check --write on staged files) - updated triggers docs images and triggers.mdx content - fixed "figured" → "figures" typo on landing page - updated pnpm-lock.yaml Co-authored-by: Cursor <cursoragent@cursor.com> * Commit --------- Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
committed by
pullfrog[bot]
parent
e45c4a84a2
commit
97937f46f7
@@ -141017,6 +141017,11 @@ async function checkoutPrBranch(pullNumber, params) {
|
||||
if (isFork) {
|
||||
toolState.pushUrl = `https://github.com/${headRepo.full_name}.git`;
|
||||
}
|
||||
toolState.pushDest = {
|
||||
remoteName: isFork ? `pr-${pullNumber}` : "origin",
|
||||
remoteBranch: headBranch,
|
||||
localBranch
|
||||
};
|
||||
await executeLifecycleHook({
|
||||
event: "post-checkout",
|
||||
script: params.postCheckoutScript
|
||||
@@ -141417,6 +141422,9 @@ async function reportProgress(ctx, { body }) {
|
||||
action: "updated"
|
||||
};
|
||||
}
|
||||
if (existingCommentId === null) {
|
||||
return { body, action: "skipped" };
|
||||
}
|
||||
if (issueNumber === void 0) {
|
||||
return { body, action: "skipped" };
|
||||
}
|
||||
@@ -141823,7 +141831,10 @@ function resolveInstructions(ctx) {
|
||||
|
||||
Call \`delegate\` with a mode, effort level, and optional instructions:
|
||||
- \`mode\`: The workflow to run (see available modes below)
|
||||
- \`effort\`: \`"auto"\` (default, most capable), \`"mini"\` (fast, for simple tasks), or \`"max"\` (maximum capability)
|
||||
- \`effort\`:
|
||||
- \`"mini"\`: low-effort and fast, for simple tasks
|
||||
- \`"auto"\`: medium-effort, good for typical tasks that don't require significant reasoning
|
||||
- \`"max"\`: high-effort, good for PR reviews and complex coding tasks.
|
||||
- \`instructions\`: Optional additional context for the subagent. Use this to pass results from earlier delegations or narrow the subagent's focus.
|
||||
|
||||
### Single vs. multi-phase delegation
|
||||
@@ -141921,7 +141932,7 @@ var DelegateParams = type({
|
||||
"the name of the mode to delegate to (e.g., 'Build', 'Plan', 'Review', 'Fix', 'AddressReviews')"
|
||||
),
|
||||
"effort?": Effort.describe(
|
||||
'effort level for the subagent: "mini" (fast), "auto" (default, highly capable), or "max" (maximum capability)'
|
||||
`effort level for the subagent: "mini" (low-effort and fast, only for simple tasks), "auto" (medium-effort, good for typical tasks that don't require significant reasoning), or "max" (high-effort, good for PR reviews and complex coding tasks)`
|
||||
),
|
||||
"instructions?": type.string.describe(
|
||||
"optional additional context or instructions for the subagent \u2014 use this to pass results from earlier delegations or narrow the subagent's focus"
|
||||
@@ -142941,7 +142952,14 @@ function ListDirectoryTool(_ctx) {
|
||||
}
|
||||
|
||||
// mcp/git.ts
|
||||
function getPushDestination(branch) {
|
||||
function getPushDestination(branch, storedDest) {
|
||||
if (storedDest && storedDest.localBranch === branch) {
|
||||
log.debug(`using stored push destination: ${storedDest.remoteName}/${storedDest.remoteBranch}`);
|
||||
const url4 = $("git", ["remote", "get-url", "--push", storedDest.remoteName], {
|
||||
log: false
|
||||
}).trim();
|
||||
return { remoteName: storedDest.remoteName, remoteBranch: storedDest.remoteBranch, url: url4 };
|
||||
}
|
||||
try {
|
||||
const pushRemote = $("git", ["config", `branch.${branch}.pushRemote`], { log: false }).trim();
|
||||
const merge4 = $("git", ["config", `branch.${branch}.merge`], { log: false }).trim();
|
||||
@@ -142958,7 +142976,7 @@ function normalizeUrl(url4) {
|
||||
return url4.replace(/\.git$/, "").toLowerCase();
|
||||
}
|
||||
function validatePushDestination(params) {
|
||||
const dest = getPushDestination(params.branch);
|
||||
const dest = getPushDestination(params.branch, params.storedDest);
|
||||
if (normalizeUrl(dest.url) !== normalizeUrl(params.pushUrl)) {
|
||||
throw new Error(
|
||||
`Push blocked: destination does not match expected repository.
|
||||
@@ -142989,7 +143007,11 @@ function PushBranchTool(ctx) {
|
||||
if (!pushUrl) {
|
||||
throw new Error("pushUrl not set - setupGit must run before push_branch");
|
||||
}
|
||||
const pushDest = validatePushDestination({ branch, pushUrl });
|
||||
const pushDest = validatePushDestination({
|
||||
branch,
|
||||
pushUrl,
|
||||
storedDest: ctx.toolState.pushDest
|
||||
});
|
||||
if (pushPermission === "restricted" && pushDest.remoteBranch === defaultBranch) {
|
||||
throw new Error(
|
||||
`Push blocked: cannot push directly to default branch '${pushDest.remoteBranch}'. Create a feature branch and open a PR instead.`
|
||||
@@ -144069,10 +144091,10 @@ function UploadFileTool(ctx) {
|
||||
|
||||
// mcp/server.ts
|
||||
function initToolState(params) {
|
||||
const progressCommentId = params.progressCommentId ? parseInt(params.progressCommentId, 10) : null;
|
||||
const resolvedId = Number.isNaN(progressCommentId) ? null : progressCommentId;
|
||||
if (progressCommentId) {
|
||||
log.info(`\xBB using pre-created progress comment: ${progressCommentId}`);
|
||||
const parsed2 = params.progressCommentId ? parseInt(params.progressCommentId, 10) : NaN;
|
||||
const resolvedId = Number.isNaN(parsed2) ? void 0 : parsed2;
|
||||
if (resolvedId) {
|
||||
log.info(`\xBB using pre-created progress comment: ${resolvedId}`);
|
||||
}
|
||||
return {
|
||||
progressCommentId: resolvedId,
|
||||
|
||||
Reference in New Issue
Block a user