Fixed a wrong issue number being used for "Implement Plan" links at times (#404)
This commit is contained in:
committed by
pullfrog[bot]
parent
887f37236d
commit
a0af59b52a
@@ -141471,7 +141471,7 @@ async function reportProgress(ctx, { body }) {
|
|||||||
return { body, action: "skipped" };
|
return { body, action: "skipped" };
|
||||||
}
|
}
|
||||||
const existingCommentId = ctx.toolState.progressCommentId;
|
const existingCommentId = ctx.toolState.progressCommentId;
|
||||||
const issueNumber = ctx.toolState.issueNumber ?? ctx.payload.event.issue_number;
|
const issueNumber = ctx.payload.event.issue_number ?? ctx.toolState.issueNumber;
|
||||||
const isPlanMode = ctx.toolState.selectedMode === "Plan";
|
const isPlanMode = ctx.toolState.selectedMode === "Plan";
|
||||||
if (existingCommentId) {
|
if (existingCommentId) {
|
||||||
const customParts = isPlanMode && issueNumber !== void 0 ? [buildImplementPlanLink(ctx.repo.owner, ctx.repo.name, issueNumber, existingCommentId)] : void 0;
|
const customParts = isPlanMode && issueNumber !== void 0 ? [buildImplementPlanLink(ctx.repo.owner, ctx.repo.name, issueNumber, existingCommentId)] : void 0;
|
||||||
|
|||||||
+5
-1
@@ -178,7 +178,11 @@ export async function reportProgress(
|
|||||||
}
|
}
|
||||||
|
|
||||||
const existingCommentId = ctx.toolState.progressCommentId;
|
const existingCommentId = ctx.toolState.progressCommentId;
|
||||||
const issueNumber = ctx.toolState.issueNumber ?? ctx.payload.event.issue_number;
|
// Explicit issue_number from the payload wins here
|
||||||
|
// This is especially important for manually triggered workflows from trigger links.
|
||||||
|
// Without this, the created "Implement plan" would be created for the wrong issue
|
||||||
|
// if the run happens to research other issues (and thus overwrite the toolState.issueNumber).
|
||||||
|
const issueNumber = ctx.payload.event.issue_number ?? ctx.toolState.issueNumber;
|
||||||
const isPlanMode = ctx.toolState.selectedMode === "Plan";
|
const isPlanMode = ctx.toolState.selectedMode === "Plan";
|
||||||
|
|
||||||
// if we already have a progress comment, update it
|
// if we already have a progress comment, update it
|
||||||
|
|||||||
Reference in New Issue
Block a user