harden sandbox escape vectors for bash disabled/restricted modes (#257)

* harden sandbox escape vectors for bash disabled/restricted modes block git config injection (-c flag as subcommand), dangerous subcommands (config, submodule, rebase, bisect), code-executing arg flags (--exec, --extcmd), .gitattributes/.gitmodules writes, and package lifecycle scripts. add retry logic to test runner for transient failures. add security unit tests and adhoc attack tests. Co-authored-by: Cursor <cursoragent@cursor.com> * only filter subcommands in nobash, remove nobash from ui * use regex matching * iterate on tests * simplify githooks --------- Co-authored-by: Cursor <cursoragent@cursor.com>
2026-02-11 02:02:41 +00:00
parent f37d02b292
commit bc28c658f2
32 changed files with 2515 additions and 1048 deletions
@@ -1,5 +1,6 @@
 import { Octokit } from "@octokit/rest";
 import { describe, expect, it } from "vitest";
+import { acquireNewToken } from "../utils/github.ts";
 import { fetchAndFormatPrDiff } from "./checkout.ts";

 /**
@@ -20,50 +21,56 @@ function parseTocEntries(toc: string) {
  return entries;
 }

+async function getToken(): Promise<string> {
+  // prefer explicit GH_TOKEN, fall back to acquiring one via GitHub App credentials
+  if (process.env.GH_TOKEN) return process.env.GH_TOKEN;
+  return await acquireNewToken();
+}
+
 describe("fetchAndFormatPrDiff", () => {
-  it("generates accurate TOC line numbers for pullfrog/test-repo#1", async () => {
-    const token = process.env.GH_TOKEN;
-    if (!token) {
-      throw new Error("GH_TOKEN not set in .env");
+  it(
+    "generates accurate TOC line numbers for pullfrog/test-repo#1",
+    { timeout: 30000 },
+    async () => {
+      const token = await getToken();
+      const octokit = new Octokit({ auth: token });
+      const result = await fetchAndFormatPrDiff({
+        octokit,
+        owner: "pullfrog",
+        repo: "test-repo",
+        pullNumber: 1,
+      });
+
+      // verify content includes TOC at the start
+      expect(result.content.startsWith(result.toc)).toBe(true);
+
+      // parse TOC and validate every entry's line numbers against actual content
+      const contentLines = result.content.split("\n");
+      const tocEntries = parseTocEntries(result.toc);
+      expect(tocEntries.length).toBeGreaterThan(0);
+
+      for (const entry of tocEntries) {
+        // line numbers are 1-indexed, arrays are 0-indexed
+        const firstLine = contentLines[entry.startLine - 1];
+        expect(firstLine).toBeDefined();
+        // first line of each file section should be the diff header
+        expect(firstLine).toBe(`diff --git a/${entry.filename} b/${entry.filename}`);
+
+        // endLine should be within bounds
+        expect(entry.endLine).toBeLessThanOrEqual(contentLines.length);
+      }
+
+      // verify adjacent files don't overlap and are contiguous
+      for (let i = 1; i < tocEntries.length; i++) {
+        const prev = tocEntries[i - 1];
+        const curr = tocEntries[i];
+        // current file starts right after previous file ends
+        expect(curr.startLine).toBe(prev.endLine + 1);
+      }
+
+      // snapshot the full output for regression detection
+      expect(result.toc).toMatchSnapshot("toc");
+      expect(result.content).toMatchSnapshot("content");
    }
-
-    const octokit = new Octokit({ auth: token });
-    const result = await fetchAndFormatPrDiff({
-      octokit,
-      owner: "pullfrog",
-      repo: "test-repo",
-      pullNumber: 1,
-    });
-
-    // verify content includes TOC at the start
-    expect(result.content.startsWith(result.toc)).toBe(true);
-
-    // parse TOC and validate every entry's line numbers against actual content
-    const contentLines = result.content.split("\n");
-    const tocEntries = parseTocEntries(result.toc);
-    expect(tocEntries.length).toBeGreaterThan(0);
-
-    for (const entry of tocEntries) {
-      // line numbers are 1-indexed, arrays are 0-indexed
-      const firstLine = contentLines[entry.startLine - 1];
-      expect(firstLine).toBeDefined();
-      // first line of each file section should be the diff header
-      expect(firstLine).toBe(`diff --git a/${entry.filename} b/${entry.filename}`);
-
-      // endLine should be within bounds
-      expect(entry.endLine).toBeLessThanOrEqual(contentLines.length);
-    }
-
-    // verify adjacent files don't overlap and are contiguous
-    for (let i = 1; i < tocEntries.length; i++) {
-      const prev = tocEntries[i - 1];
-      const curr = tocEntries[i];
-      // current file starts right after previous file ends
-      expect(curr.startLine).toBe(prev.endLine + 1);
-    }
-
-    // snapshot the full output for regression detection
-    expect(result.toc).toMatchSnapshot("toc");
-    expect(result.content).toMatchSnapshot("content");
-  });
+  );
 });