refactor delegation system, add PR summary comments, and improve code quality (#334)

* refactor delegation system and add PR summary comments

Delegation system:
- replace mode-based delegation with select_mode → delegate two-step flow
- orchestrator crafts self-contained subagent prompts (clean context — no system/repo/event instructions leak)
- add role-based tool filtering via FastMCP authenticate hook (?role=subagent hides orchestrator-only tools)
- add select_mode tool for orchestrator guidance per mode
- add ask_question tool for lightweight research subagents
- extract shared subagent lifecycle into subagent.ts (create, complete, stdout, instructions)
- route set_output to per-subagent state when activeSubagentId is set
- track per-subagent state (SubagentState Map) replacing boolean delegationActive flag
- capture and aggregate AgentUsage across all agents (claude, codex, gemini, opencode)
- write usage summary table to GitHub job summary
- block built-in subagent spawning (Task for Claude, Task(*) for Cursor)
- increase activity timeout from 60s to 300s (subagent thinking phases)
- fix gh CLI misguidance in system prompt — explicitly forbid usage

PR summary comments:
- add prSummaryComment trigger (DB schema + migrations + Zod + UI toggle)
- dispatch mini-effort summary job alongside PR review on pr.created
- add update_pull_request_body MCP tool
- add defaultEffort option to webhook dispatch

Hardening:
- rewrite delegate/selectMode tests with simulated state management
- add toolFiltering.test.ts for role extraction, canAccess, set_output routing
- remove non-null assertions for PULLFROG_TEMP_DIR (proper error throws)
- use fetchWithRetry for direct tarball downloads
- DRY fix for rate limit check in test runner

Co-authored-by: Cursor <cursoragent@cursor.com>

* fix: add type keyword to Effort import in handleWebhook.ts

Co-authored-by: Cursor <cursoragent@cursor.com>

* clean up delegation system, improve code quality across the codebase

- simplify delegate tool to instructions + effort params with subagent lifecycle in subagent.ts
- add select_mode and ask_question orchestrator-only tools with canAccess filtering
- replace delegate.test.ts/selectMode.test.ts with toolFiltering.test.ts (live MCP integration)
- add set_output routing for subagent context and AgentUsage tracking across all agents
- add PR summary comment trigger (schema, UI, webhook dispatch with silent flag)
- add update_pull_request_body MCP tool
- fix changed-agents.sh to always include claude canary for non-agent action changes
- fix cursor pagination bug in getSelectedInstallationReposPage
- remove destructuring patterns, inline type definitions, and unsafe type casts
- replace non-null assertions with explicit checks in install.ts
- convert multi-param functions to single param objects (postCleanup, runActionLocal, etc.)
- use isHttpError helper in API routes instead of catch-any patterns
- add adhoc test fixtures for delegation scenarios (context isolation, error handling, synthesis, etc.)

Co-authored-by: Cursor <cursoragent@cursor.com>

* no subagent mutation, one mcp per subagent

* address review feedback: parallel-safe usage tracking, subagent isolation, minor improvements

* fix subagent state isolation: replace Object.freeze with shallow copy

Object.freeze throws TypeErrors when subagent tools (checkout_pr,
report_progress) write scalar properties to toolState. A shallow copy
achieves the same isolation for scalar fields while allowing tools to
work normally. Shared references (subagents Map, usageEntries array)
remain shared for coordination.

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: pullfrog[bot] <226033991+pullfrog[bot]@users.noreply.github.com>

test/adhoc/delegateAskQuestion.ts

@@ -0,0 +1,62 @@
+import type { AgentResult, TestRunnerOptions, ValidationCheck } from "../utils.ts";
+import { defineFixture, getAgentOutput, getStructuredOutput } from "../utils.ts";
+
+/**
+ * delegate-ask-question — orchestrator uses ask_question to gather codebase
+ * info, then uses that answer to craft a targeted delegation.
+ *
+ * tests the ask_question → delegate pipeline: information gathering first,
+ * then action based on gathered context. this validates that the orchestrator
+ * can chain ask_question and delegate as a two-step workflow.
+ */
+
+const fixture = defineFixture(
+  {
+    prompt: `You are an orchestrator. Your task has TWO steps:
+
+STEP 1 — GATHER INFO:
+Use gh_pullfrog/ask_question to ask: "What files are in the root directory of this repository? List them."
+
+STEP 2 — DELEGATE WITH CONTEXT:
+After receiving the answer, select Plan mode via select_mode, then delegate to a subagent with mini effort.
+Your subagent instructions MUST include:
+- The list of files you learned about from step 1
+- Tell the subagent to call gh_pullfrog/set_output with EXACTLY this format: "FILES_FOUND=true,COUNT=<N>" where <N> is the number of files from the list you gave it
+- Do NOT create any branches, commits, or PRs
+
+After delegation completes, call set_output yourself with the subagent's result.
+
+IMPORTANT: You MUST use ask_question BEFORE delegating. The subagent prompt must reference specific files from the ask_question answer.`,
+    effort: "auto",
+    timeout: "10m",
+  },
+  { localOnly: true }
+);
+
+function validator(result: AgentResult): ValidationCheck[] {
+  const output = getStructuredOutput(result);
+  const agentOutput = getAgentOutput(result);
+
+  const setOutputCalled = output !== null;
+  const hasFilesFound = setOutputCalled && /FILES_FOUND=true/i.test(output ?? "");
+  const countMatch = output ? /COUNT=(\d+)/i.exec(output) : null;
+  const hasFileCount = countMatch !== null && parseInt(countMatch[1], 10) > 0;
+  const askQuestionUsed = /» ask_question subagent=/i.test(agentOutput);
+  const delegationOccurred = /» delegating subagent=/i.test(agentOutput);
+
+  return [
+    { name: "set_output", passed: setOutputCalled },
+    { name: "files_found", passed: hasFilesFound },
+    { name: "file_count", passed: hasFileCount },
+    { name: "ask_question_used", passed: askQuestionUsed },
+    { name: "delegation_occurred", passed: delegationOccurred },
+  ];
+}
+
+export const test: TestRunnerOptions = {
+  name: "delegate-ask-question",
+  fixture,
+  validator,
+  env: { GITHUB_REPOSITORY: "pullfrog/test-repo" },
+  tags: ["adhoc"],
+};