From efc1b67e7bad682e39f87ba10bbe1d9b33e6ea76 Mon Sep 17 00:00:00 2001
From: Colin McDonnell <colinmcd94@gmail.com>
Date: Sat, 16 May 2026 05:14:51 +0000
Subject: [PATCH] fix(test): skip models.dev existence check for fallback
 aliases
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

deprecated aliases (`fallback` set) legitimately point at dead resolve
targets — xAI just retired grok-4-1-fast/grok-code-fast-1 and #761 wired
them through the fallback chain. the terminal-fallback is validated
separately by the Zen served-list test.
---
 test/models-catalog.main.test.ts | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

diff --git a/test/models-catalog.main.test.ts b/test/models-catalog.main.test.ts
index e6499ea..742ab59 100644
--- a/test/models-catalog.main.test.ts
+++ b/test/models-catalog.main.test.ts
@@ -47,6 +47,12 @@ describe("models.dev validity", async () => {
     // since there's no models.dev entry to validate against.
     if (alias.routing) continue;
 
+    // aliases with a `fallback` are deprecated entries that legitimately point
+    // at dead resolve targets — the fallback chain redirects callers to a live
+    // model. skip both existence and deprecation checks; the terminal-fallback
+    // is validated separately by the Zen served-list test below.
+    if (alias.fallback) continue;
+
     const parsed = parseResolve(alias.resolve);
 
     it(`${alias.resolve} exists on models.dev`, () => {
@@ -59,13 +65,11 @@ describe("models.dev validity", async () => {
       ).toBeDefined();
     });
 
-    if (!alias.fallback) {
-      it(`${alias.resolve} is not deprecated`, () => {
-        const model = data[parsed.provider]?.models[parsed.modelId];
-        if (!model) return; // covered by existence test above
-        expect(model.status, `${alias.resolve} is deprecated on models.dev`).not.toBe("deprecated");
-      });
-    }
+    it(`${alias.resolve} is not deprecated`, () => {
+      const model = data[parsed.provider]?.models[parsed.modelId];
+      if (!model) return; // covered by existence test above
+      expect(model.status, `${alias.resolve} is deprecated on models.dev`).not.toBe("deprecated");
+    });
   }
 });