move croaked logic, ensure API key error populates comment

utils/errorReport.ts

@@ -1,24 +1,21 @@
-import { reportProgress } from "../mcp/comment.ts";
-import { getMcpContext } from "../mcp/shared.ts";
-import { log } from "./cli.ts";
+import { Octokit } from "@octokit/rest";
+import { fetchWorkflowRunInfo } from "./api.ts";
+import { getGitHubInstallationToken, parseRepoContext } from "./github.ts";
 
 /**
- * Check if MCP context is initialized (i.e., MCP server has started)
+ * Get progress comment ID from environment variable or database.
  */
-function isMcpContextInitialized(): boolean {
-  try {
-    getMcpContext();
-    return true;
-  } catch {
-    return false;
+function getProgressCommentIdFromEnv(): number | null {
+  const envCommentId = process.env.PULLFROG_PROGRESS_COMMENT_ID;
+  if (envCommentId) {
+    const parsed = parseInt(envCommentId, 10);
+    if (!Number.isNaN(parsed)) {
+      return parsed;
+    }
   }
+  return null;
 }
 
-/**
- * Report an error to the GitHub working comment.
- * Formats the error message for GitHub markdown and updates the progress comment.
- * Handles failures gracefully - logs but doesn't throw.
- */
 export async function reportErrorToComment({
   error,
   title,
@@ -26,18 +23,52 @@ export async function reportErrorToComment({
   error: string;
   title?: string;
 }): Promise<void> {
-  // only report if MCP context is initialized (MCP server has started)
-  if (!isMcpContextInitialized()) {
-    log.debug("skipping error comment update: MCP context not initialized");
-    return;
+  const formattedError = title ? `${title}\n\n${error}` : `❌ ${error}`;
+
+  // try to get comment ID from env var first, then from database if needed
+  let commentId = getProgressCommentIdFromEnv();
+
+  // if not in env var, try fetching from database using run ID
+  if (!commentId) {
+    const runId = process.env.GITHUB_RUN_ID;
+    if (runId) {
+      try {
+        const workflowRunInfo = await fetchWorkflowRunInfo(runId);
+        if (workflowRunInfo.progressCommentId) {
+          const parsed = parseInt(workflowRunInfo.progressCommentId, 10);
+          if (!Number.isNaN(parsed)) {
+            commentId = parsed;
+            // cache it in env var for future use
+            process.env.PULLFROG_PROGRESS_COMMENT_ID = workflowRunInfo.progressCommentId;
+          }
+        }
+      } catch {
+        // database fetch failed, continue without comment ID
+      }
+    }
   }
 
-  try {
-    const formattedError = title ? `${title}\n\n${error}` : `❌ ${error}`;
-    await reportProgress({ body: formattedError });
-  } catch (reportError) {
-    // log but don't throw - we don't want error reporting to fail the workflow
-    const errorMessage = reportError instanceof Error ? reportError.message : String(reportError);
-    log.warning(`failed to report error to comment: ${errorMessage}`);
+  // if no comment ID available, try using reportProgress (requires MCP context)
+  if (!commentId) {
+    try {
+      const { reportProgress } = await import("../mcp/comment.ts");
+      await reportProgress({ body: formattedError });
+      return;
+    } catch {
+      // MCP context not available, can't create/update comment
+      return;
+    }
   }
+
+  // update comment directly using GitHub API
+  const repoContext = parseRepoContext();
+  const token = getGitHubInstallationToken();
+  const octokit = new Octokit({ auth: token });
+
+  await octokit.rest.issues.updateComment({
+    owner: repoContext.owner,
+    repo: repoContext.name,
+    comment_id: commentId,
+    body: formattedError,
+  });
 }