Colin McDonnell
b9f0938405
#723's revision pass cut four substantive strings along with the negative anchors. those strings address real, audit-observed failure modes and the positive examples don't carry them. restored: - push_branch: "if the response reports a timeout, the underlying push may have actually succeeded — verify with git log origin/<branch> before retrying" (was on the tool description) - create_pull_request_review commit_id .describe(): "must be the FULL 40-character SHA — abbreviated SHAs are rejected by GitHub with 422" - create_pull_request_review comments[].line .describe(): "must sit inside a `@@` hunk... dropped entries are reported under droppedComments in the response" - create_pull_request_review comments[].start_line .describe(): "both start_line and line must sit inside the same @@ hunk" also: get_commit_info example used a 31-character SHA (non-standard truncation). swapped to a 7-char short form, which is what git log --oneline emits and what agents see in practice. note that this tool accepts either full or abbreviated, unlike create_pull_request_review which requires full.
62 lines
2.2 KiB
TypeScript
62 lines
2.2 KiB
TypeScript
import { writeFileSync } from "node:fs";
|
|
import { join } from "node:path";
|
|
import { type } from "arktype";
|
|
import { log } from "../utils/cli.ts";
|
|
import { formatFilesWithLineNumbers } from "./checkout.ts";
|
|
import type { ToolContext } from "./server.ts";
|
|
import { execute, tool } from "./shared.ts";
|
|
|
|
export const CommitInfo = type({
|
|
sha: type.string.describe("the commit SHA (full or abbreviated) to fetch"),
|
|
});
|
|
|
|
export function CommitInfoTool(ctx: ToolContext) {
|
|
return tool({
|
|
name: "get_commit_info",
|
|
description:
|
|
"Retrieve commit metadata and diff via GitHub API. Use this instead of git show for reviewing commits - " +
|
|
"it works with shallow clones and shows the actual changes in the commit. Returns diffPath pointing to formatted diff file. " +
|
|
'Example: `get_commit_info({ sha: "2a6ab5d" })`.',
|
|
parameters: CommitInfo,
|
|
execute: execute(async ({ sha }) => {
|
|
const response = await ctx.octokit.rest.repos.getCommit({
|
|
owner: ctx.repo.owner,
|
|
repo: ctx.repo.name,
|
|
ref: sha,
|
|
});
|
|
|
|
const data = response.data;
|
|
const files = data.files ?? [];
|
|
|
|
// format diff with line numbers and write to file
|
|
const formatResult = formatFilesWithLineNumbers(files);
|
|
const tempDir = process.env.PULLFROG_TEMP_DIR;
|
|
if (!tempDir) {
|
|
throw new Error(
|
|
"PULLFROG_TEMP_DIR not set - get_commit_info must run in pullfrog action context"
|
|
);
|
|
}
|
|
const diffFile = join(tempDir, `commit-${sha.slice(0, 7)}.diff`);
|
|
writeFileSync(diffFile, formatResult.content);
|
|
log.debug(`wrote commit diff to ${diffFile} (${formatResult.content.length} bytes)`);
|
|
|
|
return {
|
|
sha: data.sha,
|
|
message: data.commit.message,
|
|
author: data.author?.login ?? null,
|
|
committer: data.committer?.login ?? null,
|
|
date: data.commit.author?.date ?? data.commit.committer?.date ?? "",
|
|
url: data.html_url,
|
|
parents: data.parents.map((p) => p.sha),
|
|
stats: {
|
|
additions: data.stats?.additions ?? 0,
|
|
deletions: data.stats?.deletions ?? 0,
|
|
total: data.stats?.total ?? 0,
|
|
},
|
|
fileCount: files.length,
|
|
diffFile,
|
|
};
|
|
}),
|
|
});
|
|
}
|