6d25adfd1a
* agent & model refactor with ASKPASS git auth, UI restructure, clerk v7 Made-with: Cursor * fix stale agent/effort refs, add tests for askpass + model resolution - reviewCleanup.ts: payload.agent -> payload.model, remove effort - selectMode.ts PlanEdit: remove delegation/subagent/effort references - pullfrog.yml.ts: update env vars (drop GOOGLE_API_KEY/CURSOR_API_KEY, add GOOGLE_GENERATIVE_AI_API_KEY/XAI_API_KEY/MOONSHOT_API_KEY/OPENCODE_API_KEY) - FlagsSettings/RepoInstructionsSection: remove stale effort/timeout copy - new: gitAuthServer.test.ts (10 tests — lifecycle, token delivery, tamper detection, script gen) - new: agent.test.ts (4 tests — default opentoad, AGENT_OVERRIDE, invalid override) - new: models.test.ts (19 tests — parseModel, resolution, registry invariants) - update models.dev snapshot Made-with: Cursor * fix changed-agents.sh to filter legacy agent files from CI matrix legacy agent files (claude.ts, codex.ts, etc.) are @ts-nocheck and not exported from index.ts. changed-agents.sh now reads index.ts imports to build the active agent set and treats changes to inactive files as non-agent changes (opentoad canary only). Made-with: Cursor * remove MCP file tools, old agent harnesses, and obsolete security tests ASKPASS-based git auth makes the old MCP file tool security layer unnecessary: - token never in subprocess env, so symlink/gitattributes/hook attacks can't exfiltrate it - agents now use native file tools (OpenCode builtin read/edit) deleted: - action/mcp/file.ts (file_read, file_write, file_edit, file_delete, list_directory) - action/mcp/index.ts (dead re-export) - agent harnesses: claude.ts, codex.ts, cursor.ts, gemini.ts, opencode.ts - opencode-runner.ts (inlined into opentoad.ts) - security tests that validated MCP file tool restrictions - commented-out three-step review flow (~300 lines) - sanitizeSchema/wrapSchema dead code from mcp/shared.ts - OPENCODE_MODEL_MINI/MAX env vars (effort-level model overrides removed) updated test prompts to use generic file ops instead of MCP tool names. restored pkg-json-scripts + requirements-txt-attack (test --ignore-scripts defense). Made-with: Cursor * bump actions/checkout v4 → v6 (node 24) node 20 actions deprecated june 2, 2026. Made-with: Cursor * temporarily disable fail-fast on agnostic tests to debug checkout@v6 Made-with: Cursor * re-enable fail-fast on agnostic tests Made-with: Cursor * fix test token mismatch: mint OIDC tokens scoped to target repo CI tests override GITHUB_REPOSITORY to pullfrog/test-repo but inherit the runner's GITHUB_TOKEN (scoped to pullfrog/app), causing 401s on every run-context fetch. Clear GITHUB_TOKEN in the test subprocess so ensureGitHubToken() mints a properly scoped token via OIDC. Also centralizes the default GITHUB_REPOSITORY in runAgentStreaming instead of repeating it in every test file, and fixes preview-cleanup to remove workers from all queues (not just name-matching ones). Made-with: Cursor * fix ensureGitHubToken to try OIDC when app credentials are absent ensureGitHubToken only attempted token minting when GITHUB_APP_ID and GITHUB_PRIVATE_KEY were set. In CI, OIDC is available but app creds aren't exposed — so the guard prevented minting entirely. Made-with: Cursor * dead code cleanup: remove remnants of deleted agents, file tools, effort system remove unused @anthropic-ai/claude-agent-sdk and @openai/codex-sdk deps, orphaned file-tool security tests, dead GEMINI_MODEL passthrough, stale opencode-runner wiki refs, deleted test file references, and MCP file tool docs. rename docs/effort → docs/models. fix vitest setup: move dotenv to globalSetup (runs once before forks instead of per-file, 19s → 200ms). Made-with: Cursor * address review feedback: remove dead code, update stale references - remove AGENT_OVERRIDE (only opentoad exists) - remove shellToolName plumbing (always restricted shell) - bump action version to 0.0.179 - remove CURSOR_API_KEY from all workflows/configs - remove OPENCODE_MODEL_MINI/MAX from workflows/docs - delete wiki/effort.md, rewrite docs/effort.mdx as "Models" - rewrite wiki/modes.md: orchestrator/subagent → single agent - simplify flag system: drop builtin flag extraction (debug, effort, timeout, agent), keep custom flag replacement only - reserve all legacy flag names to prevent custom flag conflicts Made-with: Cursor * regenerate lockfile after removing claude-agent-sdk and codex-sdk Made-with: Cursor * fix import ordering, add lockfile check to pre-push hook Made-with: Cursor * remove dead debug payload field, stale packageExtensions Made-with: Cursor * merge proc-sandbox and token-exfil into a single test proc-sandbox and token-exfil were duplicative — both tested that SANDBOX_TEST_TOKEN couldn't be exfiltrated. consolidated into token-exfil with shell:restricted (which actually exercises filterEnv) and the /proc attack vector hints from proc-sandbox. Made-with: Cursor * fix wiki adversarial.md to match actual tokenExfil validator Made-with: Cursor
127 lines
4.0 KiB
TypeScript
127 lines
4.0 KiB
TypeScript
import { describe, expect, it } from "vitest";
|
|
import {
|
|
getModelEnvVars,
|
|
getModelProvider,
|
|
modelAliases,
|
|
parseModel,
|
|
providers,
|
|
resolveCliModel,
|
|
resolveModelSlug,
|
|
} from "./models.ts";
|
|
|
|
describe("parseModel", () => {
|
|
it("parses provider/model format", () => {
|
|
const result = parseModel("anthropic/claude-opus");
|
|
expect(result).toEqual({ provider: "anthropic", model: "claude-opus" });
|
|
});
|
|
|
|
it("handles nested slashes (openrouter format)", () => {
|
|
const result = parseModel("openrouter/anthropic/claude-opus-4.6");
|
|
expect(result).toEqual({ provider: "openrouter", model: "anthropic/claude-opus-4.6" });
|
|
});
|
|
|
|
it("throws on invalid slug without slash", () => {
|
|
expect(() => parseModel("invalid")).toThrow("invalid model slug");
|
|
});
|
|
});
|
|
|
|
describe("getModelProvider", () => {
|
|
it("extracts provider from slug", () => {
|
|
expect(getModelProvider("anthropic/claude-opus")).toBe("anthropic");
|
|
expect(getModelProvider("openai/gpt-codex")).toBe("openai");
|
|
expect(getModelProvider("google/gemini-pro")).toBe("google");
|
|
});
|
|
});
|
|
|
|
describe("getModelEnvVars", () => {
|
|
it("returns correct env vars for anthropic", () => {
|
|
expect(getModelEnvVars("anthropic/claude-opus")).toEqual(["ANTHROPIC_API_KEY"]);
|
|
});
|
|
|
|
it("returns correct env vars for google (multiple)", () => {
|
|
const envVars = getModelEnvVars("google/gemini-pro");
|
|
expect(envVars).toContain("GOOGLE_GENERATIVE_AI_API_KEY");
|
|
expect(envVars).toContain("GEMINI_API_KEY");
|
|
});
|
|
|
|
it("returns empty array for unknown provider", () => {
|
|
expect(getModelEnvVars("unknown/model")).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe("resolveModelSlug", () => {
|
|
it("resolves known alias to concrete specifier", () => {
|
|
const resolved = resolveModelSlug("anthropic/claude-opus");
|
|
expect(resolved).toBe("anthropic/claude-opus-4-6");
|
|
});
|
|
|
|
it("resolves openai alias", () => {
|
|
const resolved = resolveModelSlug("openai/gpt-codex");
|
|
expect(resolved).toBe("openai/gpt-5.3-codex");
|
|
});
|
|
|
|
it("returns undefined for unknown slug", () => {
|
|
expect(resolveModelSlug("unknown/model")).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe("resolveCliModel", () => {
|
|
it("returns same as resolveModelSlug (models.dev specifier)", () => {
|
|
const slug = "anthropic/claude-opus";
|
|
expect(resolveCliModel(slug)).toBe(resolveModelSlug(slug));
|
|
});
|
|
|
|
it("returns undefined for unknown slug", () => {
|
|
expect(resolveCliModel("bogus/nope")).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe("modelAliases registry", () => {
|
|
it("has at least one model per provider", () => {
|
|
for (const providerKey of Object.keys(providers)) {
|
|
const providerModels = modelAliases.filter((a) => a.provider === providerKey);
|
|
expect(providerModels.length).toBeGreaterThan(0);
|
|
}
|
|
});
|
|
|
|
it("has exactly one recommended model per provider", () => {
|
|
for (const providerKey of Object.keys(providers)) {
|
|
const recommended = modelAliases.filter((a) => a.provider === providerKey && a.recommended);
|
|
expect(recommended.length, `${providerKey} should have exactly 1 recommended model`).toBe(1);
|
|
}
|
|
});
|
|
|
|
it("all slugs follow provider/model format", () => {
|
|
for (const alias of modelAliases) {
|
|
expect(alias.slug).toContain("/");
|
|
const parsed = parseModel(alias.slug);
|
|
expect(parsed.provider).toBe(alias.provider);
|
|
}
|
|
});
|
|
|
|
it("all resolve values follow provider/model format", () => {
|
|
for (const alias of modelAliases) {
|
|
expect(alias.resolve).toContain("/");
|
|
}
|
|
});
|
|
|
|
it("slugs are unique", () => {
|
|
const slugs = modelAliases.map((a) => a.slug);
|
|
expect(new Set(slugs).size).toBe(slugs.length);
|
|
});
|
|
});
|
|
|
|
describe("providers registry", () => {
|
|
it("every provider has envVars", () => {
|
|
for (const [key, config] of Object.entries(providers)) {
|
|
expect(config.envVars.length, `${key} should have env vars`).toBeGreaterThan(0);
|
|
}
|
|
});
|
|
|
|
it("every provider has a displayName", () => {
|
|
for (const [key, config] of Object.entries(providers)) {
|
|
expect(config.displayName, `${key} should have a displayName`).toBeTruthy();
|
|
}
|
|
});
|
|
});
|