David Blass
ada5584737
`mcp/checkout.test.ts` and `mcp/reviewComments.test.ts` previously hit live GitHub on every run via `acquireNewToken()`, requiring `GH_TOKEN` or `GITHUB_APP_ID` + `GITHUB_PRIVATE_KEY` in the env. that made them: - cred-gated — the action runtime filters `_KEY$` / `_TOKEN$` from subprocess env, so the husky pre-push hook (which runs `pnpm -r test`) blocked Pullfrog agents from pushing branches. issues #562, #563, #564, #566 all hit this exact blocker and never got their fixes pushed. - non-deterministic and slow (network round-trips for a snapshot test). both tests are really snapshot tests of pure formatters (`formatFilesWithLineNumbers`, plus `parseFilePatches` / `buildThreadBlocks` / `formatReviewThreads` for review data). the live fetches were just an inefficient way to obtain fixtures. changes: 1. extract a pure `formatReviewData({ review, threads, prFiles, ... })` from `getReviewData` in `mcp/reviewComments.ts`. `getReviewData` becomes thin orchestration: fetch + call formatter. preserves the "skip listFiles when no threads" perf optimization. 2. add `action/mcp/__fixtures__/` with checked-in JSON captures for the three fixture test cases (pullfrog/test-repo#1 listFiles, pullfrog/scratch#49 review 3485940013, pullfrog/scratch#64 review 3531000326). ~14KB total. fixtures store only the fields the formatter reads — volatile fields (sha, blob_url, etc.) are dropped. 3. rewrite both test files to load the fixtures and call the pure formatters directly. snapshot keys updated; snapshot content unchanged (verified by running existing snapshots against the refactored tests). 4. add `action/scripts/refresh-test-fixtures.ts` to re-fetch the fixtures from live GitHub on demand: `node action/scripts/refresh-test-fixtures.ts` (with creds in `.env` or env). re-run when the GitHub API response shape changes and review the snapshot diff. trade-off: a silent change to GitHub's `pulls.listFiles` / `pulls.getReview` / GraphQL `reviewThreads` response shape would no longer break this test on every push. that tradeoff is worth it: shape drift on those endpoints is rare (years between changes), and a dedicated cron that runs the refresh script and opens a PR on diff is a far better signal than a flaky cred-gated pre-push hook. Co-authored-by: Cursor <cursoragent@cursor.com>
110 lines
4.5 KiB
Plaintext
110 lines
4.5 KiB
Plaintext
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html
|
|
|
|
exports[`formatFilesWithLineNumbers > generates accurate TOC line numbers for pullfrog/test-repo#1 > content 1`] = `
|
|
"## Files (5)
|
|
- src/format.ts → lines 9-32 · diff-41c7b3ac268a3a1ae5c7be92f1230f600013b7170e44a693570ccbdb183ea36b
|
|
- src/math.ts → lines 33-55 · diff-9c6e445a719b33e276684bdf95c69e617f0303638d44cf90d61295f2720ecc63
|
|
- src/old-module.ts → lines 56-64 · diff-b02fb28f45ef1227002b260c46ae6b16e080d58f65ed2a035bb58d05e2e2df5c
|
|
- src/validate.ts → lines 65-80 · diff-04b485505a31584d0a838375545a6d1f0044cd9601cd84ed98f75b42a88ea051
|
|
- test/math.test.ts → lines 81-93 · diff-44b3f515a5c787743d239052db11d740d691e8bef711c2427bb2b9752a4103a9
|
|
|
|
---
|
|
diff --git a/src/format.ts b/src/format.ts
|
|
--- a/src/format.ts
|
|
+++ b/src/format.ts
|
|
@@ -1,7 +1,17 @@
|
|
| 1 | | - | export function formatCurrency(amount: number) {
|
|
| 2 | | - | return \`$\${amount.toFixed(2)}\`;
|
|
| | 1 | + | export function formatCurrency(amount: number, currency = "USD") {
|
|
| | 2 | + | return new Intl.NumberFormat("en-US", {
|
|
| | 3 | + | style: "currency",
|
|
| | 4 | + | currency,
|
|
| | 5 | + | }).format(amount);
|
|
| 3 | 6 | | }
|
|
| 4 | 7 | |
|
|
| 5 | 8 | | export function formatPercent(value: number) {
|
|
| 6 | 9 | | return \`\${(value * 100).toFixed(1)}%\`;
|
|
| 7 | 10 | | }
|
|
| | 11 | + |
|
|
| | 12 | + | export function formatNumber(value: number, decimals = 2) {
|
|
| | 13 | + | return new Intl.NumberFormat("en-US", {
|
|
| | 14 | + | minimumFractionDigits: decimals,
|
|
| | 15 | + | maximumFractionDigits: decimals,
|
|
| | 16 | + | }).format(value);
|
|
| | 17 | + | }
|
|
|
|
diff --git a/src/math.ts b/src/math.ts
|
|
--- a/src/math.ts
|
|
+++ b/src/math.ts
|
|
@@ -3,13 +3,16 @@ export function add(a: number, b: number) {
|
|
| 3 | 3 | | }
|
|
| 4 | 4 | |
|
|
| 5 | 5 | | export function subtract(a: number, b: number) {
|
|
| 6 | | - | return a + b; // bug: should be a - b
|
|
| | 6 | + | return a - b;
|
|
| 7 | 7 | | }
|
|
| 8 | 8 | |
|
|
| 9 | 9 | | export function multiply(a: number, b: number) {
|
|
| 10 | | - | return a * b + 1; // bug: off by one
|
|
| | 10 | + | return a * b;
|
|
| 11 | 11 | | }
|
|
| 12 | 12 | |
|
|
| 13 | 13 | | export function divide(a: number, b: number) {
|
|
| | 14 | + | if (b === 0) {
|
|
| | 15 | + | throw new Error("division by zero");
|
|
| | 16 | + | }
|
|
| 14 | 17 | | return a / b;
|
|
| 15 | 18 | | }
|
|
|
|
diff --git a/src/old-module.ts b/src/old-module.ts
|
|
--- a/src/old-module.ts
|
|
+++ b/src/old-module.ts
|
|
@@ -1,4 +0,0 @@
|
|
| 1 | | - | // this module is deprecated and will be removed
|
|
| 2 | | - | export function legacyHelper() {
|
|
| 3 | | - | return "old";
|
|
| 4 | | - | }
|
|
|
|
diff --git a/src/validate.ts b/src/validate.ts
|
|
--- a/src/validate.ts
|
|
+++ b/src/validate.ts
|
|
@@ -0,0 +1,11 @@
|
|
| | 1 | + | export function isPositive(n: number) {
|
|
| | 2 | + | return n > 0;
|
|
| | 3 | + | }
|
|
| | 4 | + |
|
|
| | 5 | + | export function isInRange(value: number, min: number, max: number) {
|
|
| | 6 | + | return value >= min && value <= max;
|
|
| | 7 | + | }
|
|
| | 8 | + |
|
|
| | 9 | + | export function isInteger(n: number) {
|
|
| | 10 | + | return Number.isInteger(n);
|
|
| | 11 | + | }
|
|
|
|
diff --git a/test/math.test.ts b/test/math.test.ts
|
|
--- a/test/math.test.ts
|
|
+++ b/test/math.test.ts
|
|
@@ -17,4 +17,8 @@ describe("math", () => {
|
|
| 17 | 17 | | it("divides", () => {
|
|
| 18 | 18 | | expect(divide(10, 2)).toBe(5);
|
|
| 19 | 19 | | });
|
|
| | 20 | + |
|
|
| | 21 | + | it("throws on division by zero", () => {
|
|
| | 22 | + | expect(() => divide(1, 0)).toThrow("division by zero");
|
|
| | 23 | + | });
|
|
| 20 | 24 | | });
|
|
"
|
|
`;
|
|
|
|
exports[`formatFilesWithLineNumbers > generates accurate TOC line numbers for pullfrog/test-repo#1 > toc 1`] = `
|
|
"## Files (5)
|
|
- src/format.ts → lines 9-32 · diff-41c7b3ac268a3a1ae5c7be92f1230f600013b7170e44a693570ccbdb183ea36b
|
|
- src/math.ts → lines 33-55 · diff-9c6e445a719b33e276684bdf95c69e617f0303638d44cf90d61295f2720ecc63
|
|
- src/old-module.ts → lines 56-64 · diff-b02fb28f45ef1227002b260c46ae6b16e080d58f65ed2a035bb58d05e2e2df5c
|
|
- src/validate.ts → lines 65-80 · diff-04b485505a31584d0a838375545a6d1f0044cd9601cd84ed98f75b42a88ea051
|
|
- test/math.test.ts → lines 81-93 · diff-44b3f515a5c787743d239052db11d740d691e8bef711c2427bb2b9752a4103a9
|
|
|
|
---
|
|
"
|
|
`;
|