b6658ddbc1
* add workflows permission to git token and waitlist improvements - add `workflows` to `InstallationTokenPermissions` type in both action and API token routes - include `workflows: write` in the git token so agents can push workflow file changes - add `githubFollowers` field to WaitlistSignup schema with migration - add script to populate waitlist followers from GitHub API - add frog-green-square-border logo asset Co-authored-by: Cursor <cursoragent@cursor.com> * improve CI, agent logging, token permissions, and delegation guardrails - add format check and build step to root CI job - standardize agent model/effort log lines across all agents - fix GitHub App permissions types to match OpenAPI schema (workflows is write-only) - improve delegation error message to prevent subagent recursion - demote noisy OpenCode stderr to debug level - add subagent delegation rules to resolved instructions Co-authored-by: Cursor <cursoragent@cursor.com> * fix graphql partial error handling, update delegation message, add workflow_run fixtures Co-authored-by: Cursor <cursoragent@cursor.com> * remove module-level env var throws that break CI build Co-authored-by: Cursor <cursoragent@cursor.com> * fix logging bug and type hole from PR review - use batch-local notFound counter so per-batch log doesn't undercount - add workflows to WorkflowTokenPermissions so wire type matches what action sends Co-authored-by: Cursor <cursoragent@cursor.com> * lazy-init appOctokit to fix next build without env vars Co-authored-by: Cursor <cursoragent@cursor.com> * drop pnpm build from CI test workflow Co-authored-by: Cursor <cursoragent@cursor.com> * fix delegate-effort test regex to match actual log format, disable fail-fast for agnostic tests the test was matching `running \w+ with effort=auto` but the actual log line from shared.ts is `» effort: auto`. also temporarily set fail-fast: false on action-agnostic so all failures surface at once. Co-authored-by: Cursor <cursoragent@cursor.com> * disable fail-fast in action workflow too, relax ci.test.ts to match both workflow files now use fail-fast: false for agnostic tests so all matrix jobs run to completion. the ci consistency test now checks that the two workflows agree rather than requiring true. Co-authored-by: Cursor <cursoragent@cursor.com> * restore fail-fast: true now that all agnostic tests pass Co-authored-by: Cursor <cursoragent@cursor.com> * skip agent tests in CI when agent harness file didn't change adds action/test/changed-agents.sh which reads the PR diff (via dorny/paths-filter) and outputs only agents whose harness file was modified. the action-agents matrix now uses this dynamic list instead of a hardcoded array, so e.g. a PR touching only cursor.ts runs 6 jobs instead of 30. Co-authored-by: Cursor <cursoragent@cursor.com> * update ci.test.ts to validate dynamic agent matrix the test now checks that the matrix references the changes job output and that changed-agents.sh correctly discovers all agents. Co-authored-by: Cursor <cursoragent@cursor.com> * parallelize action jobs and use claude canary fallback for shared changes runs action-agents in parallel with action-agnostic after root/changes, and updates changed-agents logic so shared or non-harness action runtime changes run only claude while harness-specific edits run only those changed agents. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
178 lines
6.1 KiB
TypeScript
178 lines
6.1 KiB
TypeScript
import { execFileSync } from "node:child_process";
|
|
import { readdirSync, readFileSync } from "node:fs";
|
|
import { dirname, join } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { describe, expect, it } from "vitest";
|
|
import { parse } from "yaml";
|
|
import { agentsManifest } from "../external.ts";
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
const actionDir = join(__dirname, "..");
|
|
const rootDir = join(actionDir, "..");
|
|
|
|
type WorkflowJob = {
|
|
"runs-on": string;
|
|
"timeout-minutes"?: number;
|
|
permissions?: Record<string, string>;
|
|
strategy?: { "fail-fast": boolean; matrix: Record<string, string[]> };
|
|
env?: Record<string, string>;
|
|
steps?: unknown[];
|
|
};
|
|
|
|
type Workflow = {
|
|
name: string;
|
|
jobs: Record<string, WorkflowJob>;
|
|
};
|
|
|
|
const rootWorkflow = parse(
|
|
readFileSync(join(rootDir, ".github/workflows/test.yml"), "utf-8")
|
|
) as Workflow;
|
|
const actionWorkflow = parse(
|
|
readFileSync(join(actionDir, ".github/workflows/test.yml"), "utf-8")
|
|
) as Workflow;
|
|
|
|
// read test names from .ts files in a test directory.
|
|
// matches `name: "xxx"` at the start of a line (with indentation) to skip
|
|
// inline validator check names like `{ name: "set_output", ... }`.
|
|
function getTestNamesFromDir(dir: string): string[] {
|
|
const dirPath = join(__dirname, dir);
|
|
const files = readdirSync(dirPath).filter((f) => f.endsWith(".ts"));
|
|
const names: string[] = [];
|
|
|
|
for (const file of files) {
|
|
const content = readFileSync(join(dirPath, file), "utf-8");
|
|
const match = content.match(/^\s+name:\s*"([^"]+)"/m);
|
|
if (match) {
|
|
names.push(match[1]);
|
|
}
|
|
}
|
|
|
|
return names.sort();
|
|
}
|
|
|
|
function getEnvVarNames(job: WorkflowJob): string[] {
|
|
return Object.keys(job.env ?? {}).sort();
|
|
}
|
|
|
|
const expectedAgents = Object.keys(agentsManifest).sort();
|
|
const crossagentTests = getTestNamesFromDir("crossagent");
|
|
const agnosticTests = getTestNamesFromDir("agnostic");
|
|
const adhocTests = getTestNamesFromDir("adhoc");
|
|
const dynamicAgentsExpression = "$" + "{{ fromJSON(needs.changes.outputs.agents) }}";
|
|
|
|
// all API key names from all agents + GITHUB_TOKEN + model overrides
|
|
const expectedAgentEnvVars = [
|
|
"GITHUB_TOKEN",
|
|
...new Set(Object.values(agentsManifest).flatMap((a) => a.apiKeyNames)),
|
|
"GEMINI_MODEL",
|
|
"OPENCODE_MODEL",
|
|
].sort();
|
|
|
|
// agnostic tests only run with claude
|
|
const expectedAgnosticEnvVars = ["ANTHROPIC_API_KEY", "GITHUB_TOKEN"].sort();
|
|
|
|
describe("ci workflow consistency", () => {
|
|
it("workflow names match", () => {
|
|
expect(rootWorkflow.name).toBe(actionWorkflow.name);
|
|
});
|
|
|
|
it("no duplicate test names across directories", () => {
|
|
const allNames = [...crossagentTests, ...agnosticTests, ...adhocTests];
|
|
const duplicates = allNames.filter((name, idx) => allNames.indexOf(name) !== idx);
|
|
expect(duplicates).toEqual([]);
|
|
});
|
|
|
|
describe("cross-agent tests", () => {
|
|
const rootJob = rootWorkflow.jobs["action-agents"];
|
|
const actionJob = actionWorkflow.jobs.agents;
|
|
|
|
it("root agent matrix uses dynamic output from changes job", () => {
|
|
expect(rootJob.strategy!.matrix.agent).toBe(dynamicAgentsExpression);
|
|
});
|
|
|
|
it("changed-agents.sh falls back to claude when shared agent code changed", () => {
|
|
const input = JSON.stringify(["action/agents/shared.ts"]);
|
|
const output = execFileSync("bash", [join(__dirname, "changed-agents.sh")], {
|
|
input,
|
|
encoding: "utf-8",
|
|
});
|
|
expect(JSON.parse(output)).toEqual(["claude"]);
|
|
});
|
|
|
|
it("changed-agents.sh falls back to claude for non-agent action changes", () => {
|
|
const output = execFileSync("bash", [join(__dirname, "changed-agents.sh")], {
|
|
input: JSON.stringify(["action/mcp/delegate.ts"]),
|
|
encoding: "utf-8",
|
|
});
|
|
expect(JSON.parse(output)).toEqual(["claude"]);
|
|
});
|
|
|
|
it("action agent matrix matches agentsManifest", () => {
|
|
expect([...actionJob.strategy!.matrix.agent].sort()).toEqual(expectedAgents);
|
|
});
|
|
|
|
it("root test matrix matches crossagent/ directory", () => {
|
|
expect([...rootJob.strategy!.matrix.test].sort()).toEqual(crossagentTests);
|
|
});
|
|
|
|
it("action test matrix matches crossagent/ directory", () => {
|
|
expect([...actionJob.strategy!.matrix.test].sort()).toEqual(crossagentTests);
|
|
});
|
|
|
|
it("permissions match between root and action", () => {
|
|
expect(rootJob.permissions).toEqual(actionJob.permissions);
|
|
});
|
|
|
|
it("timeout-minutes match between root and action", () => {
|
|
expect(rootJob["timeout-minutes"]).toEqual(actionJob["timeout-minutes"]);
|
|
});
|
|
|
|
it("env vars match between root and action", () => {
|
|
expect(getEnvVarNames(rootJob)).toEqual(getEnvVarNames(actionJob));
|
|
});
|
|
|
|
it("env vars cover all agent API keys", () => {
|
|
expect(getEnvVarNames(rootJob)).toEqual(expectedAgentEnvVars);
|
|
});
|
|
|
|
it("fail-fast is enabled in both", () => {
|
|
expect(rootJob.strategy!["fail-fast"]).toBe(true);
|
|
expect(actionJob.strategy!["fail-fast"]).toBe(true);
|
|
});
|
|
});
|
|
|
|
describe("agnostic tests", () => {
|
|
const rootJob = rootWorkflow.jobs["action-agnostic"];
|
|
const actionJob = actionWorkflow.jobs.agnostic;
|
|
|
|
it("root test matrix matches agnostic/ directory", () => {
|
|
expect([...rootJob.strategy!.matrix.test].sort()).toEqual(agnosticTests);
|
|
});
|
|
|
|
it("action test matrix matches agnostic/ directory", () => {
|
|
expect([...actionJob.strategy!.matrix.test].sort()).toEqual(agnosticTests);
|
|
});
|
|
|
|
it("permissions match between root and action", () => {
|
|
expect(rootJob.permissions).toEqual(actionJob.permissions);
|
|
});
|
|
|
|
it("timeout-minutes match between root and action", () => {
|
|
expect(rootJob["timeout-minutes"]).toEqual(actionJob["timeout-minutes"]);
|
|
});
|
|
|
|
it("env vars match between root and action", () => {
|
|
expect(getEnvVarNames(rootJob)).toEqual(getEnvVarNames(actionJob));
|
|
});
|
|
|
|
it("env vars are correct for claude-only tests", () => {
|
|
expect(getEnvVarNames(rootJob)).toEqual(expectedAgnosticEnvVars);
|
|
});
|
|
|
|
it("fail-fast is enabled in both", () => {
|
|
expect(rootJob.strategy!["fail-fast"]).toBe(true);
|
|
expect(actionJob.strategy!["fail-fast"]).toBe(true);
|
|
});
|
|
});
|
|
});
|