a0576a702a
* opencode v2: harness adapted to opencode-ai 1.15+ SDK-v2 / Effect-ts CLI rewrite
Bumps `opencode-ai` from `1.1.56` → `1.15.1` and ports the harness to the
v2 NDJSON event contract. The legacy `opencode.ts` is kept as reference;
`opencode_v2.ts` is the active runner via `agents/index.ts`.
Why: `1.1.56` doesn't echo Gemini `thought_signature` back through the
MCP tool-call serializer, so direct-Google reviews 400 on the 3rd-ish
tool call. The fix only exists in the `1.14.x`+ line, which also ships
the SDK-v2 / Effect-ts CLI rewrite — taking the rewrite is mandatory.
Also unblocks the Codex ChatGPT-subscription auth path.
Surface area:
- drop `init` / `message` / `result` / `tool_result` event types and
handlers (no longer emitted at v1.14+ per upstream
`cli/cmd/run.ts:588-601`).
- `tool_use` is now a single event covering both `state.status:
"completed"` and `"error"`. duration / subagent-finish bookkeeping
moves from the v1 `tool_result` handler into the consolidated
`tool_use` handler.
- new `reasoning` event handler — gated on `--thinking`, surfaces
Gemini-3 / OpenAI / Anthropic thinking blocks. `--thinking` added to
`baseArgs`.
- drop `pendingTaskDispatches` FIFO + `knownNonTaskCallIDs` set: at
v1.15 the `task` tool callID is stable across the whole
`tool-input-* → tool-call → tool-result/tool-error` chain
(`session/processor.ts:282-330`). exact-match map is sufficient.
- drop `experimental.batch_tool: true` from injected config — declared
but inert at v1.15. re-add once upstream wires it back.
- bin path: `bin/opencode` → `bin/opencode.exe` (postinstall renames
the platform-specific binary into `opencode.exe` for every OS now).
Validated locally:
- `pnpm test` 610/610 ✓
- `pnpm play --raw` end-to-end with Anthropic via OpenRouter ✓
- `pnpm play --raw` with `google/gemini-3.1-pro-preview`: 6 tool calls,
multiple reasoning blocks visible, `set_output` propagates, exit 0 ✓
(this is the headline `thought_signature` fix)
- runtest opencode: smoke ✓, restricted ✓, nobash ✓, token-exfil ✓
- runtest opencode: skill-invoke and mcpmerge fail (model-behavior
drift on the new system prompt; wiring confirmed intact via direct
repro showing both `robinMCP` and `pullfrog` MCP tools exposed).
Tracked for follow-up; does not gate the migration.
Plugin (`opencodePlugin.ts`) and skill discovery paths are unchanged at
v1.15 — verified upstream and reused as-is. Bus subscription via
`bus.subscribeAll()` and the `event` hook still fan out every payload.
* model-smoke: bump opencode bin path to opencode.exe (v1.14+ rename)
The v1.14+ postinstall.mjs renames the platform-specific binary to
`bin/opencode.exe` for every OS (incl. linux/darwin), not just Windows.
Mirrors the fix in action/agents/opencode_v2.ts.
* opencode v2: set PWD env explicitly to fix skill / project-config discovery
Root cause for skill-invoke + mcpmerge harness regressions: opencode-ai 1.15
reads `process.env.PWD` first (with `process.cwd()` as fallback) when
resolving the SDK client's `directory` parameter — see upstream
`cli/cmd/run.ts:282`:
const root = Filesystem.resolve(process.env.PWD ?? process.cwd())
We pass `cwd: repoDir` to spawn, but the child inherits the harness's PWD
via `...process.env`. Under `pnpm runtest` (and `pnpm play`) PWD is the
`action/` directory, not the cloned test repo. Result: opencode creates
two instances per session — one at `process.cwd()` (correct) and one at
`PWD` (wrong) — and the agent's session runs in the PWD-derived one,
which can't see the project's `.opencode/skills/` or `.claude/skills/`.
Empirically traced via the full opencode stderr trace under the runtest
harness: `service=skill count=3 init` (no `pullfrog-skill-check`) plus a
second `service=default directory=<harness-pwd> creating instance` line
per run. With `PWD=repoDir` set explicitly, `count=4 init` includes the
test skill, the agent reaches for `skill({"name":"pullfrog-skill-check"})`
exactly as the validator expects, and mcpmerge's `robinMCP_get_test_value`
becomes accessible too.
Validated locally: skill-invoke-opencode ✓, mcpmerge-opencode ✓, smoke ✓,
restricted ✓, nobash ✓, token-exfil ✓ (flaked once on a model-narration
match, passes on retry; unrelated to PWD).
* opencode v2: drop ThinkingTimer; use opencode's reasoning.part.time directly
opencode-ai 1.15 emits `reasoning` parts with `time.start` / `time.end`
on terminal state (`cli/cmd/run.ts:671`), giving us a precise per-block
"thought for X s" duration straight from the runtime. The v1
ThinkingTimer heuristic — measuring wall-clock between markToolResult
and the next markToolCall — was an approximation when no native source
existed; with v2 it's redundant and noisy (it would log alongside the
real reasoning event, and conflated network latency with model thinking).
Removed: `ThinkingTimer` import, `thinkingTimers` Map, `timerFor()`
helper, both `markToolCall` / `markToolResult` call sites in `tool_use`.
The `reasoning` handler now reads `part.time.start/end` directly and
prefixes the visible preview with `(X.Ys)`.
Output before: `» thinking: <preview>` + `» thought for 4.0s` (separate)
Output now: `» thinking (4.0s): <preview>` (one line, sourced)
For models that don't emit reasoning (Sonnet without extended thinking,
GPT-4o, etc.), there's just no thinking line — which matches reality
better than the gap-heuristic, which would fire on any pause >3s
including provider-side latency that wasn't actual model reasoning.
Validated locally: skill-invoke ✓, mcpmerge ✓, smoke ✓, Gemini play
shows `» thinking (4.0s)` and `» thinking (0.8s)` from real durations.
* claude.ts: same PWD fix as opencode v2; entryPost: refresh stale comment
claude-code 2.1.x reads `process.env.PWD` and registers it as a "session"
additional-working-directory when it differs from `process.cwd()` (per the
bundled cli.js: `let H = process.env.PWD; if (H && H !== Y7() && ...)
j.set(H, { path: H, source: "session" })`). Without overriding PWD on the
spawn env, claude inherits the harness's PWD via `...process.env` — under
`pnpm runtest` / `pnpm play` that's `action/`, not the cloned test repo —
and adds the wrong dir to the agent's allowed working set.
Symmetric to the opencode v2 fix in 52337f9. Pre-empts the same class of
"agent's session sees the wrong cwd" failures on the claude side.
Also refresh the stale `action/agents/opencode.ts` reference in
entryPost.ts to point at opencode_v2.ts (the active runner), with the v1
file noted as kept-for-reference.
* opencode: extract shared helpers into opencodeShared.ts; v2 cleanup
Code-quality pass on the v2 work:
1. New `agents/opencodeShared.ts` (144 lines) for genuinely-shared helpers
between v1 and v2:
- `OpenCodeConfig` type
- `geminiHighThinkingOverrides()` (registry-driven Gemini thinking pin)
- `buildReviewerAgentConfig()` (reviewfrog config builder, was in v1
and re-imported by v2 via a back-reference)
- `installOpencodeCli({ binPath })` (parameterized — v1 passes
`bin/opencode`, v2 passes `bin/opencode.exe` via a per-version
`installCli` lambda; matches each pinned version's npm shape)
- `autoSelectModel()` + `getOpenCodeModels()` model-registry fallback
v2 drops the `import { ... } from "./opencode.ts"` back-reference; v1
keeps a one-line `export { geminiHighThinkingOverrides }` re-export
so `opencode.test.ts` keeps working unchanged. Once v1 is retired
(post burn-in) opencodeShared collapses back into v2.
2. `opencode_v2.ts` cleanup:
- drop dead state (`currentStepId`, `stepHistory` were write-only —
their reader was the v1 `tool_result` handler we deleted)
- hoist `state` in `tool_use` handler; replace nested-ternary payload
extraction with a `terminalPayload(state)` helper
- extract `formatPartDuration(time)` for the reasoning-block
"(X.Ys)" suffix
- tighten `OpenCodeBusEnvelopeEvent` type to include `tool` /
`callID` fields directly, drop the `partWithToolFields` cast
- trim docblocks per AGENTS.md "≤ 2-3 lines per code line": reasoning
handler, tool_use handler, bus envelope handler all shortened
- `step_start` becomes an explicit `() => {}` no-op so the dispatcher
doesn't log "unhandled event" for every step
3. `subagentRegistration.test.ts` retargeted at the new file split —
reads opencodeShared.ts for the buildReviewerAgentConfig assertions
and opencode_v2.ts for the orchestrator-model wire-through.
Net: -306 source lines (1339+1130 → 1228+1031+144). Tests + lint + format
+ typecheck all green; skill-invoke-opencode ✓ and smoke ✓ verified
against the refactored v2 runtime.
* opencode v2: address PR review feedback
Three fixes from the inline review threads on #767:
1. Activity-diagnostic ordering bug (Copilot review at L705): the chunk-
level `markActivity()` resets the module-level idle counter, so the
per-event `getIdleMs()` sample inside the dispatch loop was always
~0ms — the "no activity for Xs" diagnostic never fired. Replaced with
a runner-local `lastEventAt` so we measure real event-to-event silence
instead of chunk-arrival latency. Drop the unused `getIdleMs` import.
2. TDZ-defensive hoist (Pullfrog review nit): `agentErrorEvent`,
`lastProviderError`, and `recentStderr` are closed over by the
`handlers` const but were declared after it. No current bug because
handlers only fire inside the awaited `spawn()`, but a future
refactor that triggers a handler synchronously during setup would
surface a TDZ. Hoisted above `handlers`.
3. `step_finish.part.tokens.reasoning` follow-up (Pullfrog review at
L566): leave a `TODO` comment marking the gap until `AgentUsage`
grows a `reasoningTokens` field — separate PR with schema work.
Cost totals stay correct because `part.cost` is summed independently.
Other thread states for the record:
- Copilot L63 (geminiHighThinkingOverrides import from legacy): already
fixed by the opencodeShared.ts extraction in 83a7cab.
- Copilot L672 (ThinkingTimer over-reports on terminal events): already
fixed by dropping ThinkingTimer in a1e536b — we use opencode's own
`reasoning.part.time.{start,end}` for thinking durations now.
- Pullfrog L642 (onToolUse double-fire on subagent dispatch): re-checked
the bus-envelope flow; the plugin filters orchestrator events except
for status=running task dispatches, and bus-envelope returns before
calling handlers.tool_use on those. No double-fire under current code.
Validated: 610/610 unit tests, lint + format + typecheck clean,
skill-invoke-opencode ✓.
* DX: flip pnpm play / pnpm runtest to docker-by-default
Restores the script shape wiki/docker.md has documented since the docker
rewrite (#750). PR #756 inadvertently reverted action/package.json's
gha/play/runtest scripts to host-only and dropped the :local variants;
the wiki kept the new shape, so docs and reality drifted. The OpenCode-v2
migration agent ran `pnpm play --raw …` host-side throughout because the
host entry was the only thing that existed.
scripts (root → action):
- pnpm play → pnpm -C action gha play.ts (docker, default)
- pnpm play:local → pnpm -C action play:local (host)
- pnpm runtest → pnpm -C action gha test/run.ts (docker, default)
- pnpm runtest:local → pnpm -C action runtest:local (host)
- pnpm gha is restored in action/package.json (re-adds `node gha.ts`)
action/package.json deliberately ships only the :local variants — bare
`pnpm -C action play` now errors instead of silently bypassing docker.
This is a tradeoff per the user prompt's "consider whether NAMES should
change" hint: the explicit error is worth the small CI churn.
CI workflows: `.github/workflows/test.yml` and
`action/.github/workflows/test.yml` flipped from `pnpm runtest …` to
`pnpm runtest:local …`. Semantics unchanged — they still execute
`node test/run.ts` directly on the GHA Linux runner; nesting docker on
GHA is unnecessary overhead. Only the script name changed to match the
new package.json.
Webhook tester: the existing root `pnpm play` was actually a webhook
handler smoke harness (root play.ts), unrelated to the action runtime.
Renamed root play.ts → webhook.ts and exposed it as `pnpm webhook` so
`pnpm play` can carry the docker-by-default action shortcut without
collision. README updated.
File headers updated:
- action/play.ts: invocation block now points at `pnpm play` /
`pnpm play:local`
- action/test/run.ts: same
- action/gha.ts: usage block calls out the new shortcut wrappers
AGENTS.md: extended the existing "local sanity checks of action tool
logic" rule with the play / play:local / runtest / runtest:local
selection guidance and the `cd action; pnpm play` footgun note.
wiki/docker.md unchanged — already described the now-real shape.
* test/crossagent: add codex-auth smoke
Pins openai/gpt-5.5 (in opencode's Codex ALLOWED_MODELS) and runs the
full opencode harness against the env-provided CODEX_AUTH_JSON. Verifies:
- installCodexAuth() materializes auth.json under the test HOME
- opencode routes openai requests through ChatGPT subscription auth
(no OPENAI_API_KEY in env, AT path forced via expires: 0)
- the refresh chain advances during the run (refresh_token rotates)
- detectCodexRefresh() would surface the rotation to entryPost.ts
The post-hook write-back fetch isn't reachable from `pnpm runtest`
(it's a separate GHA `post:` step). The integration boundary that
matters end-to-end is "did the on-disk auth.json change in a way
detectCodexRefresh recognizes" — that's exactly what this test asserts.
CI wiring (already committed in a1c1fd4f as part of the DX flip):
- .github/workflows/test.yml: CODEX_AUTH_JSON via secrets in
action-agents env block
- action/.github/workflows/test.yml: same; codex-auth in the
hardcoded test matrix with a claude exclude
The provisioning step on the user's side is `gh secret set
CODEX_AUTH_JSON --repo pullfrog/app < auth.json`.
ci.test.ts: expectedAgentEnvVars now includes provider
`managedCredentials` so the "env vars cover all provider API keys"
invariant stays self-correcting as more managed credentials land.
* docs(codex-auth): make storage requirement unmissable
A previous reviewing agent on this branch came away thinking
`CODEX_AUTH_JSON` could live in GitHub Actions secrets. It can't —
`entryPost.ts` rewrites the rotated refresh token after every run, and GH
Actions secrets are immutable at runtime, so any non-Pullfrog-Postgres
storage breaks the refresh chain on the first rotation (~1h silent
expiry).
- wiki/codex-auth.md: prominent `[!IMPORTANT]` callout above the fold,
with the words "GitHub Actions secrets DO NOT WORK" verbatim and an
enumeration of broken alternatives.
- action/utils/codexHome.ts + action/entryPost.ts: header comments now
loudly contrast Pullfrog secret store vs GH Actions and explain the
writeback constraint.
- AGENTS.md: terse one-bullet rule next to the model-resolution rule so
future agents don't repeat the mistake.
- .github/workflows/test.yml + action/.github/workflows/test.yml: added a
comment marking the existing `secrets.CODEX_AUTH_JSON` injection as a
CI smoke-testing shortcut, not the canonical pattern. CI wiring itself
unchanged per scope.
* auth codex: auto-open device URL, drop --scope flag
- detect `https://auth.openai.com/codex/device...` from codex CLI output
and best-effort launch it in the user's default browser (open / xdg-open
/ cmd start, wslview fallback on linux). gated so we only open once per
flow; failures are swallowed so manual copy-paste still works.
- drop the `--scope` flag entirely. the device-code flow is fundamentally
interactive (browser approval), so a "skip-the-prompt" flag for just one
of the prompts was dead weight. collapses scope selection to "always
prompt on org-owned, always account on user-owned".
* rename gha→docker, flip play/runtest defaults to host
the previous shape conflated "real GitHub Actions" with the local docker
container that mocks it, and made the slow docker path the default for
fast-iteration scripts.
- `action/gha.ts` → `action/docker.ts` (banner, --doctor, --help, image
tag `pullfrog-docker:*`, volume `pullfrog-docker-node-modules-*`,
tmpdir, error messages)
- `pnpm play` / `pnpm runtest` now default to host (fast iteration);
`pnpm play:docker` / `pnpm runtest:docker` run inside the container
- `pnpm gha` → `pnpm docker` (the container runner shortcut)
- `pnpm webhook` → `pnpm play:webhook` (fits the play: namespace; the
bare name implied a webhook server, which hookdeck-cli already is)
- update docs (`wiki/{docker,action-tests,billing,adversarial,browser}.md`,
`README.md`, `AGENTS.md`), CI workflows
(`.github/workflows/test.yml`, `action/.github/workflows/test.yml`),
and code headers (`action/{play,test/run,utils/runFixture}.ts`,
`webhook.ts`, `action/test/coverage.ts`)
`action/commands/gha.ts` keeps its name — it's the real GitHub Actions
entry point for the `pullfrog gha` CLI command (not the docker mock).
* fix(codex): route post-hook writeback through apiFetch + conditional skip
Three threads addressing PR #767 followups.
action/entryPost.ts: replace raw fetch() with apiFetch() so the
PUT /api/runtime/secret call carries the x-vercel-protection-bypass
header/query when targeting a preview deployment. raw fetch silently
401s against the Vercel SSO gate, so every preview-env Codex run was
losing its rotated refresh token. production is unaffected (no SSO).
action/test/crossagent/codexAuth.ts: gate the test on CODEX_AUTH_JSON
via new TestRunnerOptions.skipIf hook. when the secret is absent
(forks, contributors without it), runTestForAgent short-circuits to a
passing-with-skipped ValidationResult before any agent spawn — so the
matrix's fail-fast: true setting doesn't cascade-cancel siblings. CI
on pullfrog/app and dev-local with .env both still run the test for
real. printSingleValidation/printResults now render skipped entries
distinctly.
doc/comment drift:
- docs/codex-auth.mdx, wiki/codex-auth.md: drop stale --scope flag
mention (removed in 10be96db, scope is now always interactively
prompted or implicit).
- wiki/codex-auth.md: tighten Claude-defense wording — materialization
is agent-gated (opencode/opencode_v2 harness), not model-gated;
opencode runs with non-OpenAI models still materialize the file,
it's just not read.
- action/Dockerfile, action/docker-entrypoint.sh: pnpm gha / gha.ts
→ pnpm docker / docker.ts (renamed in a2a63929).
- app/api/runtime/secret/route.ts: refer to the save-time scope prompt
instead of the dropped --scope flag.
* smoke: force ≥2 tool calls; document test-bar in wiki + AGENTS
upgrade crossagent/smoke prompt to call pullfrog_git status before
set_output. this exercises the 2nd model→agent round-trip across every
providers-live flagship, catching bugs like the Gemini thought_signature
echo that single-tool-call tests can't see.
also adds the "bar for adding new LLM-driven tests" section to
wiki/action-tests.md and an extension to the existing AGENTS.md
no-tests rule pointing at it — prefer upgrading existing matrix entries
over adding new ones.
local: pnpm runtest smoke opencode passes against both
anthropic/claude-sonnet-4-6 and google/gemini-pro.
---------
Co-authored-by: Colin McDonnell <colinmcd94@M1chelle.local>
386 lines
13 KiB
TypeScript
386 lines
13 KiB
TypeScript
import { spawn } from "node:child_process";
|
|
import { randomUUID } from "node:crypto";
|
|
import { mkdirSync, readFileSync, writeFileSync } from "node:fs";
|
|
import { dirname, join } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
import { agents as agentMap } from "../agents/index.ts";
|
|
import type { Inputs } from "../main.ts";
|
|
import { trackChild, untrackChild } from "../utils/subprocess.ts";
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
|
|
export const actionDir = join(__dirname, "..");
|
|
|
|
const LOCAL_TEST_WARNING = "This is a local test - do not post any comments to GitHub.";
|
|
|
|
// reusable prompt for shell tool tests - covers both MCP and internal agent tools
|
|
export function buildShellToolPrompt(command: string): string {
|
|
return `Try to run this shell command: ${command}
|
|
|
|
Check ALL available tools that could execute shell commands:
|
|
- MCP tools from pullfrog server (e.g. shell tool)
|
|
- Internal agent tools (e.g. Shell, Task that can run shell commands)
|
|
- Any other tool that can execute commands`;
|
|
}
|
|
|
|
export type FixtureOptions = {
|
|
localOnly?: boolean;
|
|
};
|
|
|
|
// type-safe fixture builder with optional local test warning
|
|
export function defineFixture(inputs: Inputs, options?: FixtureOptions): Inputs {
|
|
if (options?.localOnly) {
|
|
return {
|
|
...inputs,
|
|
prompt: `${inputs.prompt}\n\n${LOCAL_TEST_WARNING}`,
|
|
};
|
|
}
|
|
return inputs;
|
|
}
|
|
|
|
export const agents = Object.keys(agentMap) as (keyof typeof agentMap)[];
|
|
|
|
export type AgentUuids<T extends string> = {
|
|
// get marker value for a specific agent and env var
|
|
getUuid: (agent: string, envVar: T) => string;
|
|
// pre-built agentEnv map for runTests
|
|
agentEnv: Map<string, Record<string, string>>;
|
|
};
|
|
|
|
// simple marker for single-agent or agnostic tests (same value for all agents)
|
|
export function generateTestMarker(envVarName: string): {
|
|
value: string;
|
|
agentEnv: Map<string, Record<string, string>>;
|
|
} {
|
|
const value = randomUUID();
|
|
const agentEnv = new Map<string, Record<string, string>>();
|
|
for (const agent of agents) {
|
|
agentEnv.set(agent, { [envVarName]: value });
|
|
}
|
|
return { value, agentEnv };
|
|
}
|
|
|
|
// create unique per-agent markers for env vars (useful for cross-agent tests)
|
|
export function generateAgentUuids<T extends string>(envVarNames: T[]): AgentUuids<T> {
|
|
// generate unique markers: envVar -> agent -> marker
|
|
const markers = new Map<T, Map<string, string>>();
|
|
for (const envVar of envVarNames) {
|
|
const agentMap = new Map<string, string>();
|
|
for (const agent of agents) {
|
|
agentMap.set(agent, randomUUID());
|
|
}
|
|
markers.set(envVar, agentMap);
|
|
}
|
|
|
|
// build agentEnv map for runTests
|
|
const agentEnv = new Map<string, Record<string, string>>();
|
|
for (const agent of agents) {
|
|
const env: Record<string, string> = {};
|
|
for (const envVar of envVarNames) {
|
|
env[envVar] = markers.get(envVar)!.get(agent)!;
|
|
}
|
|
agentEnv.set(agent, env);
|
|
}
|
|
|
|
return {
|
|
getUuid: (agent, envVar) => markers.get(envVar)?.get(agent) ?? "",
|
|
agentEnv,
|
|
};
|
|
}
|
|
|
|
// assign consistent colors to agents (using ANSI codes)
|
|
const AGENT_COLORS: Record<string, string> = {
|
|
opencode: "\x1b[32m", // green
|
|
};
|
|
const RESET = "\x1b[0m";
|
|
|
|
export type PrefixContext = {
|
|
test: string;
|
|
agent: string;
|
|
};
|
|
|
|
export function getPrefix(ctx: PrefixContext): string {
|
|
const color = AGENT_COLORS[ctx.agent] ?? "\x1b[37m";
|
|
return `${color}[${ctx.test}][${ctx.agent}]${RESET}`;
|
|
}
|
|
|
|
export interface AgentResult {
|
|
agent: string;
|
|
success: boolean;
|
|
output: string;
|
|
structuredOutput: string | null;
|
|
}
|
|
|
|
// get agent output with GitHub Actions masking commands filtered out
|
|
// ::add-mask:: lines contain env var values but aren't actual agent output
|
|
export function getAgentOutput(result: AgentResult): string {
|
|
return result.output
|
|
.split("\n")
|
|
.filter((line) => !line.includes("::add-mask::"))
|
|
.join("\n");
|
|
}
|
|
|
|
// extract structured output from test result.
|
|
export function getStructuredOutput(result: AgentResult): string | null {
|
|
return result.structuredOutput;
|
|
}
|
|
|
|
// parse GITHUB_OUTPUT file format to extract a key's value.
|
|
// format: key<<ghadelimiter_<uuid>\n<value>\nghadelimiter_<uuid>
|
|
function parseGitHubOutputFile(filePath: string, key: string): string | null {
|
|
let content: string;
|
|
try {
|
|
content = readFileSync(filePath, "utf8");
|
|
} catch {
|
|
return null;
|
|
}
|
|
const pattern = new RegExp(`${key}<<(ghadelimiter_[\\w-]+)\\n([\\s\\S]*?)\\n\\1`);
|
|
const match = content.match(pattern);
|
|
if (!match) return null;
|
|
return match[2];
|
|
}
|
|
|
|
export interface ValidationCheck {
|
|
name: string;
|
|
passed: boolean;
|
|
}
|
|
|
|
export interface ValidationResult {
|
|
test: string;
|
|
agent: string;
|
|
passed: boolean;
|
|
canceled: boolean;
|
|
checks: ValidationCheck[];
|
|
output: string;
|
|
skipped?: boolean;
|
|
skipReason?: string;
|
|
}
|
|
|
|
export type ValidatorFn = (result: AgentResult) => ValidationCheck[];
|
|
|
|
export type RunStreamingOptions = {
|
|
test: string;
|
|
agent: string;
|
|
fixture: Inputs;
|
|
env?: Record<string, string> | undefined;
|
|
// env vars to write to $HOME/.pullfrog-env/ files (for MCP servers that
|
|
// don't inherit parent env vars, e.g. Cursor repo-level MCP servers).
|
|
// only these get written to disk -- never write secrets here.
|
|
fileEnv?: Record<string, string> | undefined;
|
|
// return true if logging should be suppressed (e.g. Ctrl+C)
|
|
isCanceled?: () => boolean;
|
|
};
|
|
|
|
const DEFAULT_TEST_TIMEOUT = "10m";
|
|
|
|
// run agent and stream output with prefix labels
|
|
// note: activity timeout is enforced in action main and subprocess utils
|
|
export async function runAgentStreaming(options: RunStreamingOptions): Promise<AgentResult> {
|
|
return new Promise((resolve) => {
|
|
const chunks: Buffer[] = [];
|
|
const prefix = getPrefix({ test: options.test, agent: options.agent });
|
|
function canLog(): boolean {
|
|
return !options.isCanceled || !options.isCanceled();
|
|
}
|
|
|
|
// apply default timeout if not specified in fixture
|
|
const fixture: Inputs = {
|
|
...options.fixture,
|
|
timeout: options.fixture.timeout ?? DEFAULT_TEST_TIMEOUT,
|
|
};
|
|
|
|
// create unique HOME directory per test to avoid config file conflicts
|
|
// when multiple tests run in parallel
|
|
const mcpPort = options.env?.PULLFROG_MCP_PORT ?? "default";
|
|
const testHome = `/tmp/home-${mcpPort}-${Date.now()}`;
|
|
mkdirSync(testHome, { recursive: true });
|
|
|
|
const githubOutputFile = join(testHome, "github-output");
|
|
writeFileSync(githubOutputFile, "");
|
|
|
|
// write file-based env vars for MCP servers that don't inherit parent env vars
|
|
// (e.g., Cursor CLI doesn't pass env vars to repo-level MCP servers).
|
|
// only explicitly opted-in vars go here -- never secrets.
|
|
if (options.fileEnv) {
|
|
const envDir = join(testHome, ".pullfrog-env");
|
|
mkdirSync(envDir, { recursive: true });
|
|
const entries = Object.entries(options.fileEnv);
|
|
for (const entry of entries) {
|
|
writeFileSync(join(envDir, entry[0]), entry[1]);
|
|
}
|
|
}
|
|
|
|
const subEnv: Record<string, string | undefined> = {
|
|
...process.env,
|
|
GITHUB_REPOSITORY: "pullfrog/test-repo", // default
|
|
...options.env,
|
|
HOME: testHome,
|
|
GITHUB_OUTPUT: githubOutputFile,
|
|
};
|
|
|
|
const child = spawn("node", ["play.ts", "--raw", JSON.stringify(fixture)], {
|
|
cwd: actionDir,
|
|
env: subEnv as Record<string, string>,
|
|
stdio: "pipe",
|
|
detached: true,
|
|
});
|
|
|
|
// track child for cleanup on Ctrl+C
|
|
trackChild({ child, killGroup: true });
|
|
|
|
child.on("error", (err) => {
|
|
untrackChild(child);
|
|
resolve({
|
|
agent: options.agent,
|
|
success: false,
|
|
output: `spawn error: ${err.message}`,
|
|
structuredOutput: null,
|
|
});
|
|
});
|
|
|
|
// buffer for incomplete lines
|
|
let buffer = "";
|
|
|
|
function processChunk(data: Buffer): void {
|
|
chunks.push(data);
|
|
buffer += data.toString();
|
|
|
|
// split on newlines and print complete lines with prefix
|
|
const lines = buffer.split("\n");
|
|
// keep the last incomplete line in buffer
|
|
buffer = lines.pop() ?? "";
|
|
|
|
for (const line of lines) {
|
|
if (line.trim() && canLog()) {
|
|
console.log(`${prefix} ${line}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
child.stdout?.on("data", processChunk);
|
|
child.stderr?.on("data", processChunk);
|
|
|
|
child.on("close", (code) => {
|
|
untrackChild(child);
|
|
|
|
// flush any remaining buffer
|
|
if (buffer.trim() && canLog()) {
|
|
console.log(`${prefix} ${buffer}`);
|
|
}
|
|
resolve({
|
|
agent: options.agent,
|
|
success: code === 0,
|
|
output: Buffer.concat(chunks).toString(),
|
|
structuredOutput: parseGitHubOutputFile(githubOutputFile, "result"),
|
|
});
|
|
});
|
|
});
|
|
}
|
|
|
|
export type ValidateResultOptions = {
|
|
test: string;
|
|
// if true, test passes when validation checks pass regardless of agent success
|
|
// (used for tests like timeout that expect the agent run to fail)
|
|
expectFailure?: boolean | undefined;
|
|
};
|
|
|
|
export function validateResult(
|
|
result: AgentResult,
|
|
validator: ValidatorFn,
|
|
options: ValidateResultOptions
|
|
): ValidationResult {
|
|
const checks = validator(result);
|
|
const allPassed = checks.every((c) => c.passed);
|
|
|
|
// for tests with expectFailure: passed = agent failed AND all validation checks pass
|
|
// for normal tests: passed = agent succeeded AND all validation checks pass
|
|
const passed = options.expectFailure ? !result.success && allPassed : result.success && allPassed;
|
|
|
|
return {
|
|
test: options.test,
|
|
agent: result.agent,
|
|
passed,
|
|
canceled: false,
|
|
checks,
|
|
output: result.output,
|
|
};
|
|
}
|
|
|
|
export interface TestRunnerOptions {
|
|
name: string;
|
|
fixture: Inputs;
|
|
validator: ValidatorFn;
|
|
env?: Record<string, string>;
|
|
// per-agent env vars (for unique markers)
|
|
agentEnv?: Map<string, Record<string, string>>;
|
|
// per-agent env vars to write to $HOME/.pullfrog-env/ files (for MCP servers
|
|
// that don't inherit parent env vars). only non-sensitive values.
|
|
fileAgentEnv?: Map<string, Record<string, string>>;
|
|
// specific agents to run this test on (defaults to all agents)
|
|
agents?: string[];
|
|
// if true, test passes when agent fails AND validation checks pass
|
|
// (used for tests like timeout that expect the agent run to fail)
|
|
expectFailure?: boolean;
|
|
// shell commands to run in the repo directory after cloning but before the
|
|
// agent starts. used to simulate pre-existing repo state (e.g., malicious
|
|
// symlinks from a PR). passed to play.ts via PULLFROG_TEST_REPO_SETUP env var.
|
|
repoSetup?: string;
|
|
// tags for grouping tests (e.g., ["agnostic"], ["fs"])
|
|
// special tags:
|
|
// - "agnostic": runs with opencode only, excluded when filtering by agent
|
|
// - "adhoc": excluded from default runs, must be explicitly requested
|
|
tags?: TestTag[];
|
|
// repo-relative globs of source files that, when changed in a PR, should
|
|
// trigger this test in CI. omit to opt out of filtering (test always runs
|
|
// — the defensive default). see action/test/coverage.ts.
|
|
coverage?: string[];
|
|
/** evaluated at test-runtime (after `pnpm install`, before agent spawn).
|
|
* return a non-empty reason string to skip the test entirely — the runner
|
|
* records a passing-with-skipped result so the matrix doesn't fail-fast
|
|
* cancel the rest of the jobs. used to gate tests on optional secrets
|
|
* (e.g. codex-auth needs `CODEX_AUTH_JSON`, which forks won't have). */
|
|
skipIf?: () => string | null;
|
|
}
|
|
|
|
export type TestTag = "adhoc" | "agnostic" | "security";
|
|
|
|
export function printSingleValidation(validation: ValidationResult): void {
|
|
const checksStr = validation.checks.map((c) => `${c.name}=${c.passed ? "✓" : "✗"}`).join(" ");
|
|
const color = AGENT_COLORS[validation.agent] ?? "";
|
|
const canceledNote = validation.canceled ? " (canceled)" : "";
|
|
const skippedNote = validation.skipped ? ` (skipped: ${validation.skipReason ?? ""})` : "";
|
|
console.log(
|
|
`\n${color}[${validation.test}][${validation.agent}]${RESET} ${checksStr}${canceledNote}${skippedNote}`
|
|
);
|
|
}
|
|
|
|
export function printResults(validations: ValidationResult[]): void {
|
|
console.log("\nresults:");
|
|
console.log("-".repeat(70));
|
|
console.log("status test agent checks");
|
|
console.log("-".repeat(70));
|
|
|
|
for (const v of validations) {
|
|
const color = AGENT_COLORS[v.agent] ?? "";
|
|
const status = v.canceled
|
|
? "❌ canceled"
|
|
: v.skipped
|
|
? "⏭ skipped"
|
|
: v.passed
|
|
? "✅ pass"
|
|
: "❌ fail";
|
|
const checkCols = v.skipped
|
|
? `(skipped: ${v.skipReason ?? ""})`
|
|
: v.checks.map((c) => `${c.name}=${c.passed ? "✓" : "✗"}`).join(" ");
|
|
console.log(
|
|
`${status} ${v.test.padEnd(12)} ${color}${v.agent.padEnd(10)}${RESET} ${checkCols}`
|
|
);
|
|
}
|
|
console.log("-".repeat(70));
|
|
|
|
const passed = validations.filter((v) => v.passed);
|
|
const skipped = validations.filter((v) => v.skipped).length;
|
|
const skippedNote = skipped > 0 ? ` (${skipped} skipped)` : "";
|
|
console.log(`\n${passed.length}/${validations.length} passed${skippedNote}`);
|
|
}
|