Compare commits

...

3 Commits

Author SHA1 Message Date
Andrej Mihajlov b7f344968d Kit: make it possible to opt-out from automatically raising the reasserting flag.
Signed-off-by: Andrej Mihajlov <and@mullvad.net>
2022-02-21 15:54:49 +01:00
Andrej Mihajlov 399013415d Merge branch 'am/ignore-set-network-settings-error-when-offline' into am/develop 2022-02-21 13:11:49 +01:00
Andrej Mihajlov 7dea71898d Kit: Adapter: ignore error when updating tunnel settings in offline
Since around iOS 15.1, calling `setNetworkSettings()` when in
airplane mode, throws an unknown error:

Error Domain=NEAgentErrorDomain Code=1

Signed-off-by: Andrej Mihajlov <and@mullvad.net>
2021-12-20 16:21:34 +01:00
+61 -26
View File
@@ -56,6 +56,10 @@ public class WireGuardAdapter {
/// Adapter state. /// Adapter state.
private var state: State = .stopped private var state: State = .stopped
/// Whether adapter should automatically raise the `reasserting` flag when updating
/// tunnel configuration.
private let shouldHandleReasserting: Bool
/// Tunnel device file descriptor. /// Tunnel device file descriptor.
private var tunnelFileDescriptor: Int32? { private var tunnelFileDescriptor: Int32? {
var ctlInfo = ctl_info() var ctlInfo = ctl_info()
@@ -128,9 +132,12 @@ public class WireGuardAdapter {
/// Designated initializer. /// Designated initializer.
/// - Parameter packetTunnelProvider: an instance of `NEPacketTunnelProvider`. Internally stored /// - Parameter packetTunnelProvider: an instance of `NEPacketTunnelProvider`. Internally stored
/// as a weak reference. /// as a weak reference.
/// - Parameter shouldHandleReasserting: whether adapter should automatically raise the
/// `reasserting` flag when updating tunnel configuration.
/// - Parameter logHandler: a log handler closure. /// - Parameter logHandler: a log handler closure.
public init(with packetTunnelProvider: NEPacketTunnelProvider, logHandler: @escaping LogHandler) { public init(with packetTunnelProvider: NEPacketTunnelProvider, shouldHandleReasserting: Bool = true, logHandler: @escaping LogHandler) {
self.packetTunnelProvider = packetTunnelProvider self.packetTunnelProvider = packetTunnelProvider
self.shouldHandleReasserting = shouldHandleReasserting
self.logHandler = logHandler self.logHandler = logHandler
setupLogHandler() setupLogHandler()
@@ -248,40 +255,68 @@ public class WireGuardAdapter {
// Tell the system that the tunnel is going to reconnect using new WireGuard // Tell the system that the tunnel is going to reconnect using new WireGuard
// configuration. // configuration.
// This will broadcast the `NEVPNStatusDidChange` notification to the GUI process. // This will broadcast the `NEVPNStatusDidChange` notification to the GUI process.
self.packetTunnelProvider?.reasserting = true if self.shouldHandleReasserting {
defer { self.packetTunnelProvider?.reasserting = true
self.packetTunnelProvider?.reasserting = false
} }
do { defer {
let settingsGenerator = try self.makeSettingsGenerator(with: tunnelConfiguration) if self.shouldHandleReasserting {
try self.setNetworkSettings(settingsGenerator.generateNetworkSettings()) self.packetTunnelProvider?.reasserting = false
switch self.state {
case .started(let handle, _):
let (wgConfig, resolutionResults) = settingsGenerator.uapiConfiguration()
self.logEndpointResolutionResults(resolutionResults)
wgSetConfig(handle, wgConfig)
#if os(iOS)
wgDisableSomeRoamingForBrokenMobileSemantics(handle)
#endif
self.state = .started(handle, settingsGenerator)
case .temporaryShutdown:
self.state = .temporaryShutdown(settingsGenerator)
case .stopped:
fatalError()
} }
}
completionHandler(nil) let settingsGenerator: PacketTunnelSettingsGenerator
do {
settingsGenerator = try self.makeSettingsGenerator(with: tunnelConfiguration)
} catch let error as WireGuardAdapterError { } catch let error as WireGuardAdapterError {
completionHandler(error) completionHandler(error)
return
} catch { } catch {
fatalError() fatalError()
} }
switch self.state {
case .started(let handle, _):
do {
try self.setNetworkSettings(settingsGenerator.generateNetworkSettings())
} catch let error as WireGuardAdapterError {
completionHandler(error)
return
} catch {
fatalError()
}
let (wgConfig, resolutionResults) = settingsGenerator.uapiConfiguration()
self.logEndpointResolutionResults(resolutionResults)
wgSetConfig(handle, wgConfig)
#if os(iOS)
wgDisableSomeRoamingForBrokenMobileSemantics(handle)
#endif
self.state = .started(handle, settingsGenerator)
case .temporaryShutdown:
// On iOS 15.1 or newer, updating network settings may fail when in airplane mode.
// Network path monitor will retry updating settings later when connectivity is
// back online.
do {
try self.setNetworkSettings(settingsGenerator.generateNetworkSettings())
} catch let error as WireGuardAdapterError {
if case .setNetworkSettings(let systemError) = error {
self.logHandler(.verbose, "Failed to set network settings while offline. Will retry when connectivity is back online. Error: \(systemError.localizedDescription)")
}
} catch {
fatalError()
}
self.state = .temporaryShutdown(settingsGenerator)
case .stopped:
fatalError()
}
completionHandler(nil)
} }
} }