move croaked logic, ensure API key error populates comment

agents/opencode.ts

@@ -1,4 +1,5 @@
 import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
+
 import { join } from "node:path";
 import { log } from "../utils/cli.ts";
 import { spawn } from "../utils/subprocess.ts";
@@ -10,6 +11,14 @@ import {
   setupProcessAgentEnv,
 } from "./shared.ts";
 
+// import { createOpencode } from "@opencode-ai/sdk"
+
+// const { client } = await createOpencode({
+//   config: {
+//     ''
+//   }
+// })
+
 // opencode cli event types inferred from json output format
 interface OpenCodeInitEvent {
   type: "init";

fixtures/basic.txt

@@ -1 +1 @@
-Use the debug_shell_command MCP tool to run `git status` and tell me what agent is running
+Tell me a joke

main.ts

@@ -52,12 +52,13 @@ export interface MainResult {
 
 export async function main(inputs: Inputs): Promise<MainResult> {
   let mcpServerClose: (() => Promise<void>) | undefined;
+  let payload: Payload | undefined;
 
   try {
     const timer = new Timer();
 
     // parse payload early to extract agent
-    const payload = parsePayload(inputs);
+    payload = parsePayload(inputs);
 
     const partialCtx = await initializeContext(inputs, payload);
     const ctx = partialCtx as MainContext;
@@ -86,21 +87,29 @@ export async function main(inputs: Inputs): Promise<MainResult> {
 
     const result = await runAgent(ctx);
     const mainResult = await handleAgentResult(result);
-    // ensure progress comment is updated if it was never updated during execution
-    await ensureProgressCommentUpdated();
     return mainResult;
   } catch (error) {
     const errorMessage = error instanceof Error ? error.message : "Unknown error occurred";
     log.error(errorMessage);
-    await reportErrorToComment({ error: errorMessage });
+    try {
+      await reportErrorToComment({ error: errorMessage });
+    } catch {
+      // error reporting failed, but don't let it mask the original error
+    }
     await log.writeSummary();
-    // ensure progress comment is updated if it was never updated during execution
-    await ensureProgressCommentUpdated();
     return {
       success: false,
       error: errorMessage,
     };
   } finally {
+    // ensure progress comment is updated if it was never updated during execution
+    // do this before revoking the token so we can still make API calls
+    try {
+      await ensureProgressCommentUpdated(payload);
+    } catch {
+      // error updating comment, but don't let it mask the original error
+    }
+
     if (mcpServerClose) {
       await mcpServerClose();
     }

mcp/comment.ts

@@ -1,7 +1,10 @@
+import { Octokit } from "@octokit/rest";
 import { type } from "arktype";
+import { LEAPING_INTO_ACTION_PREFIX } from "../../utils/github/leapingComment.ts";
 import type { Payload } from "../external.ts";
 import { agentsManifest } from "../external.ts";
-import { parseRepoContext } from "../utils/github.ts";
+import { fetchWorkflowRunInfo } from "../utils/api.ts";
+import { getGitHubInstallationToken, parseRepoContext } from "../utils/github.ts";
 import { contextualize, getMcpContext, tool } from "./shared.ts";
 
 const PULLFROG_DIVIDER = "<!-- PULLFROG_DIVIDER_DO_NOT_REMOVE_PLZ -->";
@@ -178,8 +181,7 @@ export async function reportProgress({ body }: { body: string }): Promise<
   // no existing comment - create one
   const issueNumber = ctx.payload.event.issue_number;
   if (issueNumber === undefined) {
-    // fail silently - cannot create comment without issue_number
-    return undefined;
+    throw new Error("cannot create progress comment: no issue_number found in the payload event");
   }
 
   const result = await ctx.octokit.rest.issues.createComment({
@@ -209,13 +211,6 @@ export const ReportProgressTool = tool({
   execute: contextualize(async ({ body }) => {
     const result = await reportProgress({ body });
 
-    if (!result) {
-      return {
-        success: false,
-        message: "cannot create progress comment: no issue_number found in the payload event",
-      };
-    }
-
     return {
       success: true,
       ...result,
@@ -234,39 +229,93 @@ export function wasProgressCommentUpdated(): boolean {
  * Ensure the progress comment is updated with a generic error message if it was never updated.
  * This should be called after agent execution completes to handle cases where the agent
  * exited without ever calling reportProgress.
+ *
+ * Works even if MCP context is not initialized (e.g., if error occurs before MCP server starts).
+ * Will fetch comment ID from database if not available in environment variable.
  */
-export async function ensureProgressCommentUpdated(): Promise<void> {
-  // only update if we have a progress comment ID from env var and it was never updated
-  const existingCommentId = getProgressCommentId();
-  if (!existingCommentId || progressCommentWasUpdated) {
+export async function ensureProgressCommentUpdated(payload?: Payload): Promise<void> {
+  // skip if comment was already updated during execution
+  if (progressCommentWasUpdated) {
     return;
   }
 
-  // check if MCP context is initialized (MCP server started)
+  // try to get comment ID from env var first, then from database if needed
+  let existingCommentId = getProgressCommentId();
+
+  // if not in env var, try fetching from database using run ID
+  if (!existingCommentId) {
+    const runId = process.env.GITHUB_RUN_ID;
+    if (runId) {
+      try {
+        const workflowRunInfo = await fetchWorkflowRunInfo(runId);
+        if (workflowRunInfo.progressCommentId) {
+          existingCommentId = parseInt(workflowRunInfo.progressCommentId, 10);
+          // cache it in env var for future use
+          if (!Number.isNaN(existingCommentId)) {
+            process.env.PULLFROG_PROGRESS_COMMENT_ID = workflowRunInfo.progressCommentId;
+          }
+        }
+      } catch {
+        // database fetch failed, continue without comment ID
+      }
+    }
+  }
+
+  // if still no comment ID, nothing to update
+  if (!existingCommentId) {
+    return;
+  }
+
+  // check if comment still says "leaping into action" - if it's been updated with an error, don't overwrite it
+  const repoContext = parseRepoContext();
+  const token = getGitHubInstallationToken();
+  const octokit = new Octokit({ auth: token });
+
+  try {
+    const existingComment = await octokit.rest.issues.getComment({
+      owner: repoContext.owner,
+      repo: repoContext.name,
+      comment_id: existingCommentId,
+    });
+
+    const commentBody = existingComment.data.body || "";
+    // if comment doesn't start with the leaping prefix, it's already been updated with an error or progress
+    if (!commentBody.startsWith(LEAPING_INTO_ACTION_PREFIX)) {
+      return;
+    }
+  } catch {
+    // can't fetch comment, skip update
+    return;
+  }
+
+  // try to get payload from MCP context if available, otherwise use provided payload
+  let resolvedPayload: Payload | undefined;
   try {
     const ctx = getMcpContext();
-    const repoContext = parseRepoContext();
-    const runId = process.env.GITHUB_RUN_ID;
-    const workflowRunLink = runId
-      ? `[workflow](https://github.com/${repoContext.owner}/${repoContext.name}/actions/runs/${runId})`
-      : "workflow";
+    resolvedPayload = ctx.payload;
+  } catch {
+    // MCP context not initialized, use provided payload
+    resolvedPayload = payload;
+  }
 
-    const errorMessage = `❌ this run croaked
+  const runId = process.env.GITHUB_RUN_ID;
+  const workflowRunLink = runId
+    ? `[workflow](https://github.com/${repoContext.owner}/${repoContext.name}/actions/runs/${runId})`
+    : "workflow";
+
+  const errorMessage = `❌ this run croaked
 
 The workflow encountered an error before any progress could be reported. Please check the ${workflowRunLink} for details.`;
 
-    const bodyWithFooter = addFooter(errorMessage, ctx.payload);
+  // add footer if we have payload, otherwise use plain message
+  const body = resolvedPayload ? addFooter(errorMessage, resolvedPayload) : errorMessage;
 
-    await ctx.octokit.rest.issues.updateComment({
-      owner: ctx.owner,
-      repo: ctx.name,
-      comment_id: existingCommentId,
-      body: bodyWithFooter,
-    });
-  } catch {
-    // fail silently - MCP context not initialized or other error
-    // don't want to fail the workflow if we can't update the comment
-  }
+  await octokit.rest.issues.updateComment({
+    owner: repoContext.owner,
+    repo: repoContext.name,
+    comment_id: existingCommentId,
+    body,
+  });
 }
 
 export const ReplyToReviewComment = type({

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pullfrog/action",
-  "version": "0.0.130",
+  "version": "0.0.131",
   "type": "module",
   "files": [
     "index.js",
@@ -31,6 +31,7 @@
     "@octokit/rest": "^22.0.0",
     "@octokit/webhooks-types": "^7.6.1",
     "@openai/codex-sdk": "0.58.0",
+    "@opencode-ai/sdk": "^1.0.143",
     "@standard-schema/spec": "1.0.0",
     "arktype": "2.1.28",
     "dotenv": "^17.2.3",

pnpm-lock.yaml

@@ -32,6 +32,9 @@ importers:
       '@openai/codex-sdk':
         specifier: 0.58.0
         version: 0.58.0
+      '@opencode-ai/sdk':
+        specifier: ^1.0.143
+        version: 1.0.143
       '@standard-schema/spec':
         specifier: 1.0.0
         version: 1.0.0
@@ -440,6 +443,9 @@ packages:
     resolution: {integrity: sha512-Z5vK294gUS9cn7bpU/lJtgzqJy1UqIGee7WMP+1Z4a6AxDcTxFCLZI4YkH9praJfrgoj5bFeu+3V9HIoBBTzcw==}
     engines: {node: '>=18'}
 
+  '@opencode-ai/sdk@1.0.143':
+    resolution: {integrity: sha512-dtmkBfJ7IIAHzL6KCzAlwc9GybfJONVeCsF6ePYySpkuhslDbRkZBJYb5vqGd1H5zdsgjc6JjuvmOf0rPWUL6A==}
+
   '@sec-ant/readable-stream@0.4.1':
     resolution: {integrity: sha512-831qok9r2t8AlxLko40y2ebgSDhenenCatLVeW/uBtnHPyhHOvG0C7TvfgecV+wHzIm5KUICgzmVpWS+IMEAeg==}
 
@@ -1410,6 +1416,8 @@ snapshots:
 
   '@openai/codex-sdk@0.58.0': {}
 
+  '@opencode-ai/sdk@1.0.143': {}
+
   '@sec-ant/readable-stream@0.4.1': {}
 
   '@sindresorhus/merge-streams@4.0.0': {}

utils/errorReport.ts

@@ -1,24 +1,21 @@
-import { reportProgress } from "../mcp/comment.ts";
-import { getMcpContext } from "../mcp/shared.ts";
-import { log } from "./cli.ts";
+import { Octokit } from "@octokit/rest";
+import { fetchWorkflowRunInfo } from "./api.ts";
+import { getGitHubInstallationToken, parseRepoContext } from "./github.ts";
 
 /**
- * Check if MCP context is initialized (i.e., MCP server has started)
+ * Get progress comment ID from environment variable or database.
  */
-function isMcpContextInitialized(): boolean {
-  try {
-    getMcpContext();
-    return true;
-  } catch {
-    return false;
+function getProgressCommentIdFromEnv(): number | null {
+  const envCommentId = process.env.PULLFROG_PROGRESS_COMMENT_ID;
+  if (envCommentId) {
+    const parsed = parseInt(envCommentId, 10);
+    if (!Number.isNaN(parsed)) {
+      return parsed;
+    }
   }
+  return null;
 }
 
-/**
- * Report an error to the GitHub working comment.
- * Formats the error message for GitHub markdown and updates the progress comment.
- * Handles failures gracefully - logs but doesn't throw.
- */
 export async function reportErrorToComment({
   error,
   title,
@@ -26,18 +23,52 @@ export async function reportErrorToComment({
   error: string;
   title?: string;
 }): Promise<void> {
-  // only report if MCP context is initialized (MCP server has started)
-  if (!isMcpContextInitialized()) {
-    log.debug("skipping error comment update: MCP context not initialized");
-    return;
+  const formattedError = title ? `${title}\n\n${error}` : `❌ ${error}`;
+
+  // try to get comment ID from env var first, then from database if needed
+  let commentId = getProgressCommentIdFromEnv();
+
+  // if not in env var, try fetching from database using run ID
+  if (!commentId) {
+    const runId = process.env.GITHUB_RUN_ID;
+    if (runId) {
+      try {
+        const workflowRunInfo = await fetchWorkflowRunInfo(runId);
+        if (workflowRunInfo.progressCommentId) {
+          const parsed = parseInt(workflowRunInfo.progressCommentId, 10);
+          if (!Number.isNaN(parsed)) {
+            commentId = parsed;
+            // cache it in env var for future use
+            process.env.PULLFROG_PROGRESS_COMMENT_ID = workflowRunInfo.progressCommentId;
+          }
+        }
+      } catch {
+        // database fetch failed, continue without comment ID
+      }
+    }
   }
 
-  try {
-    const formattedError = title ? `${title}\n\n${error}` : `❌ ${error}`;
-    await reportProgress({ body: formattedError });
-  } catch (reportError) {
-    // log but don't throw - we don't want error reporting to fail the workflow
-    const errorMessage = reportError instanceof Error ? reportError.message : String(reportError);
-    log.warning(`failed to report error to comment: ${errorMessage}`);
+  // if no comment ID available, try using reportProgress (requires MCP context)
+  if (!commentId) {
+    try {
+      const { reportProgress } = await import("../mcp/comment.ts");
+      await reportProgress({ body: formattedError });
+      return;
+    } catch {
+      // MCP context not available, can't create/update comment
+      return;
+    }
   }
+
+  // update comment directly using GitHub API
+  const repoContext = parseRepoContext();
+  const token = getGitHubInstallationToken();
+  const octokit = new Octokit({ auth: token });
+
+  await octokit.rest.issues.updateComment({
+    owner: repoContext.owner,
+    repo: repoContext.name,
+    comment_id: commentId,
+    body: formattedError,
+  });
 }