don't allow rejecting prs

.husky/pre-commit

@@ -7,4 +7,4 @@ echo "🔨 Building action..."
 pnpm build
 
 # Add the built files and lockfile to the commit
-git add entry.js pnpm-lock.yaml
+git add entry.js mcp-server.js pnpm-lock.yaml

README.md

@@ -9,9 +9,6 @@ GitHub Action for running Claude Code and other agents via Pullfrog.
 ```bash
 # Install dependencies
 pnpm install
-
-# Test with default prompt
-npm run play              # Run locally on your machine
 ```
 
 ## Testing with play.ts

agents/claude.ts

@@ -1,16 +1,113 @@
+import { execSync } from "node:child_process";
+import { createWriteStream, existsSync, rmSync } from "node:fs";
+import { mkdtemp } from "node:fs/promises";
+import { tmpdir } from "node:os";
+import { join } from "node:path";
+import { pipeline } from "node:stream/promises";
 import { query, type SDKMessage } from "@anthropic-ai/claude-agent-sdk";
+import packageJson from "../package.json" with { type: "json" };
 import { log } from "../utils/cli.ts";
 import { type Agent, instructions } from "./shared.ts";
 
+let cachedCliPath: string | undefined;
+
 export const claude: Agent = {
+  install: async (): Promise<string> => {
+    if (cachedCliPath) {
+      log.info(`Using cached Claude Code CLI at ${cachedCliPath}`);
+      return cachedCliPath;
+    }
+
+    // Get the SDK version from package.json and resolve to actual version
+    const versionRange = packageJson.dependencies["@anthropic-ai/claude-agent-sdk"] || "latest";
+    let sdkVersion: string;
+
+    // If it's a range (starts with ^ or ~), query npm registry for the latest matching version
+    if (versionRange.startsWith("^") || versionRange.startsWith("~")) {
+      const npmRegistry = process.env.NPM_REGISTRY || "https://registry.npmjs.org";
+      log.info(`Resolving version for range ${versionRange}...`);
+      try {
+        const registryResponse = await fetch(`${npmRegistry}/@anthropic-ai/claude-agent-sdk`);
+        if (!registryResponse.ok) {
+          throw new Error(`Failed to query registry: ${registryResponse.status}`);
+        }
+        const registryData = (await registryResponse.json()) as {
+          "dist-tags": { latest: string };
+          versions: Record<string, unknown>;
+        };
+        // Get the latest version that matches the range (simplified: just use latest)
+        sdkVersion = registryData["dist-tags"].latest;
+        log.info(`Resolved to version ${sdkVersion}`);
+      } catch (error) {
+        log.warning(
+          `Failed to resolve version from registry, using latest: ${error instanceof Error ? error.message : String(error)}`
+        );
+        sdkVersion = "latest";
+      }
+    } else {
+      sdkVersion = versionRange;
+    }
+
+    log.info(`📦 Installing Claude Code CLI from @anthropic-ai/claude-agent-sdk@${sdkVersion}...`);
+
+    // Create temp directory
+    const tempDir = await mkdtemp(join(tmpdir(), "claude-cli-"));
+    const tarballPath = join(tempDir, "package.tgz");
+
+    try {
+      // Download tarball from npm
+      const npmRegistry = process.env.NPM_REGISTRY || "https://registry.npmjs.org";
+      const tarballUrl = `${npmRegistry}/@anthropic-ai/claude-agent-sdk/-/claude-agent-sdk-${sdkVersion}.tgz`;
+
+      log.info(`Downloading from ${tarballUrl}...`);
+      const response = await fetch(tarballUrl);
+      if (!response.ok) {
+        throw new Error(`Failed to download tarball: ${response.status} ${response.statusText}`);
+      }
+
+      // Write tarball to file
+      const fileStream = createWriteStream(tarballPath);
+      await pipeline(response.body!, fileStream);
+      log.info(`Downloaded tarball to ${tarballPath}`);
+
+      // Extract tarball
+      log.info(`Extracting tarball...`);
+      execSync(`tar -xzf "${tarballPath}" -C "${tempDir}"`, { stdio: "pipe" });
+
+      // Find cli.js in the extracted package
+      const extractedDir = join(tempDir, "package");
+      const cliPath = join(extractedDir, "cli.js");
+
+      if (!existsSync(cliPath)) {
+        throw new Error(`cli.js not found in extracted package at ${cliPath}`);
+      }
+
+      cachedCliPath = cliPath;
+      log.info(`✓ Claude Code CLI installed at ${cliPath}`);
+      return cliPath;
+    } catch (error) {
+      // Cleanup on error
+      try {
+        rmSync(tempDir, { recursive: true, force: true });
+      } catch {
+        // Ignore cleanup errors
+      }
+      throw error;
+    }
+  },
   run: async ({ prompt, mcpServers, apiKey }) => {
     process.env.ANTHROPIC_API_KEY = apiKey;
 
+    if (!cachedCliPath) {
+      throw new Error("Claude CLI not installed. Call install() before run().");
+    }
+
     const queryInstance = query({
-      prompt: `${instructions}\n\n${prompt}`,
+      prompt: `${instructions}\n\n****** USER PROMPT ******\n${prompt}`,
       options: {
         permissionMode: "bypassPermissions",
         mcpServers,
+        pathToClaudeCodeExecutable: cachedCliPath,
       },
     });
 
@@ -142,4 +239,6 @@ const messageHandlers: SDKMessageHandlers = {
   },
   system: () => {},
   stream_event: () => {},
+  tool_progress: () => {},
+  auth_status: () => {},
 };

agents/shared.ts

@@ -22,6 +22,7 @@ export interface AgentConfig {
 }
 
 export type Agent = {
+  install: () => Promise<string>;
   run: (config: AgentConfig) => Promise<AgentResult>;
 };
 

entry.ts

@@ -6,17 +6,18 @@
 
 import * as core from "@actions/core";
 import { type Inputs, main } from "./main.ts";
-import { createMcpServer } from "./mcp/server.ts";
-import packageJson from "./package.json" with { type: "json" };
 import { log } from "./utils/cli.ts";
 
-// Export createMcpServer so it can be called from the spawned MCP process
-export { createMcpServer };
-
 async function run(): Promise<void> {
-  try {
-    log.info(`🐸 Running pullfrog/action@${packageJson.version}...`);
+  // Change to GITHUB_WORKSPACE if set (this is where actions/checkout puts the repo)
+  // JavaScript actions run from the action's directory, not the checked-out repo
+  if (process.env.GITHUB_WORKSPACE && process.cwd() !== process.env.GITHUB_WORKSPACE) {
+    log.debug(`Changing to GITHUB_WORKSPACE: ${process.env.GITHUB_WORKSPACE}`);
+    process.chdir(process.env.GITHUB_WORKSPACE);
+    log.debug(`New working directory: ${process.cwd()}`);
+  }
 
+  try {
     const inputs: Inputs = {
       prompt: core.getInput("prompt", { required: true }),
       anthropic_api_key: core.getInput("anthropic_api_key") || undefined,

esbuild.config.js

@@ -1,15 +1,11 @@
 import { build } from "esbuild";
 
-// Build the GitHub Action bundle only
-// For npm package builds, use zshy (pnpm build:npm)
-await build({
-  entryPoints: ["./entry.ts"],
+const sharedConfig = {
   bundle: true,
-  outfile: "./entry.js",
   format: "esm",
   platform: "node",
   target: "node20",
-  minify: true,
+  minify: false,
   sourcemap: false,
   // Bundle all dependencies - GitHub Actions doesn't have node_modules
   // Only mark optional peer dependencies as external
@@ -19,13 +15,28 @@ await build({
     "sury",
   ],
   // Provide a proper require shim for CommonJS modules bundled into ESM
+  // We use a unique variable name to avoid conflicts with bundled imports
   banner: {
-    js: `import { createRequire } from 'module'; import { fileURLToPath } from 'url'; import { dirname } from 'path'; const require = createRequire(import.meta.url); const __filename = fileURLToPath(import.meta.url); const __dirname = dirname(__filename);`,
+    js: `import { createRequire as __createRequire } from 'module'; import { fileURLToPath as __fileURLToPath } from 'url'; import { dirname as __dirnameFn } from 'path'; const require = __createRequire(import.meta.url); const __filename = __fileURLToPath(import.meta.url); const __dirname = __dirnameFn(__filename);`,
   },
   // Enable tree-shaking to remove unused code
   treeShaking: true,
   // Drop console statements in production (but keep for debugging)
   drop: [],
+};
+
+// Build the main entry bundle (without MCP)
+await build({
+  ...sharedConfig,
+  entryPoints: ["./entry.ts"],
+  outfile: "./entry.js",
+});
+
+// Build the MCP server bundle
+await build({
+  ...sharedConfig,
+  entryPoints: ["./mcp/server.ts"],
+  outfile: "./mcp-server.js",
 });
 
 console.log("✅ Build completed successfully!");

fixtures/basic.txt

@@ -1 +1 @@
-run npx cowsay "don't eat me"
+Review https://github.com/pullfrogai/scratch/pull/17

main.ts

@@ -1,6 +1,7 @@
 import { type } from "arktype";
 import { claude } from "./agents/claude.ts";
 import { createMcpConfigs } from "./mcp/config.ts";
+import packageJson from "./package.json" with { type: "json" };
 import { log } from "./utils/cli.ts";
 import { parseRepoContext, setupGitHubInstallationToken } from "./utils/github.ts";
 import { setupGitAuth, setupGitConfig } from "./utils/setup.ts";
@@ -22,7 +23,7 @@ export type PromptJSON = {};
 
 export async function main(inputs: Inputs): Promise<MainResult> {
   try {
-    log.info("Starting agent run...");
+    log.info(`🐸 Running pullfrog/action@${packageJson.version}...`);
 
     setupGitConfig();
 
@@ -35,6 +36,9 @@ export async function main(inputs: Inputs): Promise<MainResult> {
 
     log.debug(`📋 MCP Config: ${JSON.stringify(mcpServers, null, 2)}`);
 
+    // Install Claude CLI before running
+    await claude.install();
+
     log.info("Running Claude Agent SDK...");
     log.box(inputs.prompt, { title: "Prompt" });
 

mcp/config.ts

@@ -3,6 +3,7 @@
  */
 
 import type { McpServerConfig } from "@anthropic-ai/claude-agent-sdk";
+import { fromHere } from "@ark/fs";
 import { parseRepoContext } from "../utils/github.ts";
 
 export const ghPullfrogMcpName = "gh-pullfrog";
@@ -15,19 +16,14 @@ export function createMcpConfigs(githubInstallationToken: string): McpConfigs {
   const repoContext = parseRepoContext();
   const githubRepository = `${repoContext.owner}/${repoContext.name}`;
 
-  // Get absolute path to entry.js - use GITHUB_ACTION_PATH if available, otherwise current directory
-  const entryPath = process.env.GITHUB_ACTION_PATH
-    ? `${process.env.GITHUB_ACTION_PATH}/entry.js`
-    : `${process.cwd()}/entry.js`;
+  // In production (GitHub Actions), mcp-server.js is in same directory as entry.js (where this is bundled)
+  // In development, server.ts is in the same directory as this file (config.ts)
+  const serverPath = process.env.GITHUB_ACTIONS ? fromHere("mcp-server.js") : fromHere("server.ts");
 
   return {
     [ghPullfrogMcpName]: {
       command: "node",
-      args: [
-        "--input-type=module",
-        "-e",
-        `import('${entryPath.replace(/'/g, "\\'")}').then(m => m.createMcpServer())`,
-      ],
+      args: [serverPath],
       env: {
         GITHUB_INSTALLATION_TOKEN: githubInstallationToken,
         GITHUB_REPOSITORY: githubRepository,

mcp/review.ts

@@ -4,9 +4,6 @@ import { contextualize, tool } from "./shared.ts";
 
 export const Review = type({
   pull_number: type.number.describe("The pull request number to review"),
-  event: type
-    .enumerated("APPROVE", "REQUEST_CHANGES", "COMMENT")
-    .describe("'APPROVE', 'REQUEST_CHANGES', or 'COMMENT' (the review action)"),
   body: type.string
     .describe(
       "Brief summary or general feedback that doesn't apply to specific code locations. Keep it concise - most feedback should be in the 'comments' array."
@@ -45,7 +42,7 @@ export const ReviewTool = tool({
     "IMPORTANT: Use 'comments' array for ALL specific code issues at the line-level. " +
     "Only use 'body' for a brief summary or feedback that doesn't apply to a specific location.",
   parameters: Review,
-  execute: contextualize(async ({ pull_number, event, body, commit_id, comments = [] }, ctx) => {
+  execute: contextualize(async ({ pull_number, body, commit_id, comments = [] }, ctx) => {
     // Get the PR to determine the head commit if commit_id not provided
     const pr = await ctx.octokit.rest.pulls.get({
       owner: ctx.owner,
@@ -58,7 +55,7 @@ export const ReviewTool = tool({
       owner: ctx.owner,
       repo: ctx.name,
       pull_number,
-      event,
+      event: "COMMENT",
     };
     if (body) params.body = body;
     if (commit_id) {

mcp/server.ts

@@ -8,20 +8,18 @@ import { PullRequestInfoTool } from "./prInfo.ts";
 import { ReviewTool } from "./review.ts";
 import { addTools } from "./shared.ts";
 
-export function createMcpServer(): void {
-  const server = new FastMCP({
-    name: "gh-pullfrog",
-    version: "0.0.1",
-  });
+const server = new FastMCP({
+  name: "gh-pullfrog",
+  version: "0.0.1",
+});
 
-  addTools(server, [
-    CreateCommentTool,
-    EditCommentTool,
-    IssueTool,
-    PullRequestTool,
-    ReviewTool,
-    PullRequestInfoTool,
-  ]);
+addTools(server, [
+  CreateCommentTool,
+  EditCommentTool,
+  IssueTool,
+  PullRequestTool,
+  ReviewTool,
+  PullRequestInfoTool,
+]);
 
-  server.start();
-}
+server.start();

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pullfrog/action",
-  "version": "0.0.78",
+  "version": "0.0.88",
   "type": "module",
   "files": [
     "index.js",

play.ts

@@ -5,7 +5,6 @@ import { fromHere } from "@ark/fs";
 import arg from "arg";
 import { config } from "dotenv";
 import { type Inputs, main } from "./main.ts";
-import packageJson from "./package.json" with { type: "json" };
 import { log } from "./utils/cli.ts";
 import { setupTestRepo } from "./utils/setup.ts";
 
@@ -15,8 +14,6 @@ export async function run(
   prompt: string
 ): Promise<{ success: boolean; output?: string | undefined; error?: string | undefined }> {
   try {
-    log.info(`🐸 Running pullfrog/action@${packageJson.version}...`);
-
     const tempDir = join(process.cwd(), ".temp");
     setupTestRepo({ tempDir, forceClean: true });
 

todo.md

@@ -1,8 +1,10 @@
 [x] add modes to prompt 
 [x] progressively update comment
-[] don't allow rejecting prs
-[] fix pnpm caching
-[] try to avoid claude narrating the initial comment
+[x] don't allow rejecting prs
+[x] fix pnpm caching
 [] fix prompt to avoid narration like "I just read all tools from MCP server"
 [] investigate including terminal output from bash commands as collapsed groups
 [] avoid exposing env
+[] test initialization trade offs for pullfrog.yml
+[] try to find heavy claude code user
+[] investigate repo config file?

utils/setup.ts

@@ -47,13 +47,21 @@ export function setupGitConfig(): void {
   // Only set up git config in GitHub Actions environment
   // In local development, use the user's existing git config
   if (!process.env.GITHUB_ACTIONS) {
-    log.info("⚠️  Skipping git configuration setup (not in GitHub Actions)");
     return;
   }
 
   log.info("🔧 Setting up git configuration...");
-  execSync('git config user.email "action@pullfrog.ai"', { stdio: "inherit" });
-  execSync('git config user.name "Pullfrog Action"', { stdio: "inherit" });
+  try {
+    execSync('git config user.email "action@pullfrog.ai"', { stdio: "pipe" });
+    execSync('git config user.name "Pullfrog Action"', { stdio: "pipe" });
+    log.debug("setupGitConfig: ✓ Git configuration set successfully");
+  } catch (error) {
+    // If git config fails, log warning but don't fail the action
+    // This can happen if we're not in a git repo or git isn't available
+    log.warning(
+      `Failed to set git config: ${error instanceof Error ? error.message : String(error)}`
+    );
+  }
 }
 
 /**
@@ -64,7 +72,6 @@ export function setupGitAuth(githubToken: string, repoContext: RepoContext): voi
   // Only set up git auth in GitHub Actions environment
   // In local testing, this would overwrite the real git remote with fake credentials
   if (!process.env.GITHUB_ACTIONS) {
-    log.info("⚠️  Skipping git authentication setup (not in GitHub Actions)");
     return;
   }