Compare commits

...

15 Commits

Author SHA1 Message Date
Colin McDonnell b6df2860c3 action: bump to 0.1.7 2026-05-14 02:48:31 +00:00
Colin McDonnell d495f0b984 surface BYOK failures + chronic-failures card + WorkflowRunStatus mirrors GitHub conclusions (#722)
- Migrates `WorkflowRunStatus` from `running | completed | cancelled` to a 9-state mirror of `workflow_run.conclusion`. Backfill: old `completed → success`, `cancelled → failure`. New rows write `hook.workflow_run.conclusion` verbatim via `statusFromConclusion`.
- Adds Discord links to `formatApiKeyErrorSummary` (both missing-key and 401 invalid-key shapes).
- Repo console: `<ChronicFailuresCard>` fires when the last 3 terminal-state runs are all `failure`. Pure DB read; latest-run button hidden for pre-dispatch failures (`runId: null`).
- `StatusIcon` distinguishes `cancelled` (gray X, intentional stop) from `failure` (red X) so the visual matches the chronic-card threshold.
- Pre-dispatch failures (workflow lookup miss, dispatch API error) write `failure` instead of `cancelled` so they feed the card.
- Cascade: every `status: "completed"` filter in billing routes / cron / cohort queries / analyzer becomes `status: "success"`.

Verified end-to-end on `pullfrog/preview-722-failure-surfaces` — Better Stack logs confirm webhooks reached the preview deploy and all three e2e runs got `marked as failure (conclusion=failure)` via the new mapper.

Closes #679, #702.
2026-05-14 02:39:41 +00:00
Colin McDonnell 206c11fe7c review: drop misleading 'with the same arguments' from diff-coverage nudge
agent is free to refine review body/comments on retry — there's no
enforcement that the second call matches the first, and if reading the
nudged region surfaces a new finding the agent should add it.
2026-05-14 02:36:06 +00:00
Colin McDonnell 7414c1e9ca review: clarify diff-coverage nudge gives explicit license to skip generated artifacts
the one-time pre-flight nudge said "optionally read" but never told the agent
it's free to retry without reading when every unread region is generated
(lockfiles, codegen, snapshots, migration metadata). audit #677 surfaced ~21
runs/24h burning an extra model turn re-reading drizzle snapshots, pnpm-lock,
and *.gen.ts files purely to satisfy the gate. mode prompts only mention
generated content in the "skip self-review entirely" path, not the
"in-progress substantive review" path, so the in-the-moment error message
was the gap. behavior unchanged for legitimately-unread source regions.
2026-05-14 02:30:37 +00:00
Colin McDonnell 8f9208bd3f feat: Amazon Bedrock support via routing slug (#720)
* add Amazon Bedrock as a routing slug

introduces a single `bedrock/byok` catalog entry that the harness translates
to the appropriate Bedrock model ID at run time via `BEDROCK_MODEL_ID`. routes
Anthropic IDs through claude-code (with `CLAUDE_CODE_USE_BEDROCK=1`) and
everything else through opencode's `amazon-bedrock` provider — keeps the
catalog flat for an audience that needs version pinning rather than aliasing.

accepts either `AWS_BEARER_TOKEN_BEDROCK` or `AWS_ACCESS_KEY_ID` +
`AWS_SECRET_ACCESS_KEY` for auth; both validated alongside `AWS_REGION` and
`BEDROCK_MODEL_ID` in `validateAgentApiKey`. catalog drift tests, the bumps
cron, and per-alias smoke scripts all skip routing slugs since there's no
fixed `resolve` to validate.

docs/bedrock.mdx walks through setup; wiki/model-resolution.md has a section
explaining why bedrock breaks the usual alias pattern.

closes pullfrog/pullfrog#40

* ci: add bedrock env vars to test workflows

mirrors the new bedrock provider's required env vars (AWS_BEARER_TOKEN_BEDROCK
inherited from org secret + AWS_REGION + BEDROCK_MODEL_ID hardcoded) into both
.github/workflows/test.yml files so the ci.test "env vars cover all provider
API keys" assertion passes.

* docs(bedrock): clearer setup flow + screenshot of model selector

restructures the setup section into three concrete steps in execution order:
select Bedrock from the dropdown, store the bearer token as a secret (Pullfrog
or GitHub — links to keys.mdx for the trade-off), then add region + model id
directly in pullfrog.yml since neither is sensitive. enable-model-access in
the Bedrock console moved to step 4 (only required once per model and only
when AWS rejects the call, not blocking on first run).

adds a screenshot of the console model selector with Amazon Bedrock selected
so readers can recognize the UI state they're aiming for.

* fix(bedrock): tolerate raw Bedrock model IDs in validateAgentApiKey

main.ts passes the resolved model into validateAgentApiKey
(`payload.proxyModel ?? resolvedModel ?? payload.model`). For Bedrock,
`resolveModel` translates `bedrock/byok` into the raw AWS model ID
(e.g. `us.anthropic.claude-opus-4-6-v1`), which has no `/` and so
trips parseModel inside getModelEnvVars.

Detect the no-slash case and re-run the bedrock setup check (auth +
region; BEDROCK_MODEL_ID is already enforced upstream by resolveModel).

Caught by PR #720 e2e dispatch on pullfrog/preview-720-bedrock —
"invalid model slug 'us.anthropic.claude-opus-4-6-v1' — expected
'provider/model'". Two regression tests cover the raw-ID path.

* fix(bedrock): always prepend amazon-bedrock/ prefix when bedrock-routed

opencode.ts was gating the prefix-injection on `!isBedrockAnthropicId(rawModel)`,
on the theory that Anthropic Bedrock IDs always go through claude-code. But
`PULLFROG_AGENT=opencode` is a documented escape hatch — when it forces
opencode for an Anthropic Bedrock model, the prefix still has to be added or
opencode fails with 'Model not found: <modelId>/.'.

The Anthropic-vs-other discriminant only belongs in resolveAgent. Once an
agent is selected, it should consistently honor the bedrock route.

Caught by the PULLFROG_AGENT=opencode + Opus 4.6 e2e on
pullfrog/preview-720-bedrock — run 25823437606.

* ui+docs(bedrock): bespoke setup callout + clearer docs

UI:
- BedrockSetupCallout in components/AgentSettings.tsx covers both the
  Model costs section and the onboarding card. Detects bedrock via
  resolveDisplayAlias().routing === "bedrock", shows a dedicated message
  ("store AWS_BEARER_TOKEN_BEDROCK as a secret, then put AWS_REGION +
  BEDROCK_MODEL_ID directly in pullfrog.yml") + link to the setup guide.
  Replaces the generic "X, Y, or Z is required" prompt that misrepresented
  the three values as three separate secrets to add (and used the wrong
  "or" connector for what's actually an AND).
- OnboardingCard re-uses the same callout with the gradient-card variant.

Docs:
- Drop the obsolete "Enable model access" step. AWS retired the manual
  enrollment page; foundation models auto-enable on first invocation.
  Anthropic models still need a one-time use-case form for first-time
  users — surfaced under the AccessDenied troubleshooting entry.
- Drop the "Testing a different model in one run" PULLFROG_MODEL note.
  It introduced the secrets-vs-vars distinction we want to keep out of
  the bedrock setup story.
- Step 3 already recommends hardcoding region + model id in pullfrog.yml.

Workflow template:
- The default pullfrog.yml customers receive (utils/github/pullfrog.yml.ts)
  now references AWS_BEARER_TOKEN_BEDROCK from secrets but inlines
  AWS_REGION and BEDROCK_MODEL_ID as plain values. Matches the docs.

* fix(bedrock): three review-caught edges in routing + UI copy

Addresses three real issues from PR #720 review:

1. agent.ts: PULLFROG_MODEL=bedrock/byok no longer leaks the literal
   sentinel "bedrock" downstream. resolveCliModel returns the alias's
   resolve field verbatim, which for routing entries IS the sentinel.
   Refactored both the env-override and slug-lookup paths through a
   shared resolveSlug() that recognizes routing aliases and defers to
   their backing env var (BEDROCK_MODEL_ID).

2. models.ts: isBedrockAnthropicId() now anchors on a discrete
   dot/slash/colon-segment match (case-insensitive) instead of a
   substring contains. The substring check was fragile in both
   directions for inference-profile ARNs (BEDROCK_MODEL_ID accepts
   ARNs per AWS docs) — a non-Anthropic profile whose user-chosen name
   contained "anthropic" would mis-route to claude-code, and an
   Anthropic profile whose name omitted it would miss
   CLAUDE_CODE_USE_BEDROCK=1.

3. AgentSettings.tsx: BedrockSetupCallout's configured-state copy
   showed "AWS_BEARER_TOKEN_BEDROCK configured" even when the user
   satisfied the gate via AWS_ACCESS_KEY_ID + AWS_SECRET_ACCESS_KEY,
   gaslighting access-key users about a secret they never set.
   Detect which auth method is actually present and name the right
   secret(s) in the success message.

Regression tests in models.test.ts (5 new isBedrockAnthropicId cases
including positive and negative ARN forms) and agent.test.ts (2 new
PULLFROG_MODEL=bedrock/byok cases). 171/171 action tests pass.

* yml template: add commented AWS access-key alternative for Bedrock auth

Mirrors the IAM access-key path verified end-to-end on PR #720 e2e
run 25830764987. Bearer token stays as the primary nudge; the access-key
pair is the fallback for users who can't mint Bedrock API keys.

* yml template: drop redundant 'or, alternatively' annotation

* ui+docs(bedrock): rewrite callout copy + refresh screenshot

Reframes the BedrockSetupCallout away from generic BYOK language to a
Bedrock-specific message: leads with "Amazon Bedrock is configured
entirely via environment variables", lists all four (auth, region,
model id), and ends with the requested CTA sentence ("click below to
learn more about Bedrock support in Pullfrog").

Promotes the "Bedrock setup guide" docs link from an inline anchor to
a prominent button (always visible, regardless of auth state). The
"Add AWS_BEARER_TOKEN_BEDROCK" affordance is now a secondary chip
shown only when no auth secret is configured.

Refreshes docs/images/model-selector-bedrock.png to capture the new
callout — the prior screenshot still showed the old generic
"BYOK / X, Y, or Z required" wording.
2026-05-14 02:12:38 +00:00
Colin McDonnell 1a9d3c1f82 fix bootstrap ETARGET when customer has npm min-release-age policy (#725)
* fix bootstrap ETARGET when customer has npm min-release-age policy

set npm_config_min_release_age=0 in the action runtime env so
`npx --yes pullfrog@<spec>` doesn't get rejected by a customer-side
release-age gate (npm 11.5+'s min-release-age / pnpm's
minimumReleaseAge). env vars beat .npmrc in npm config precedence,
so this neutralises the policy regardless of where it's defined.

pullfrog's npm version is server-stamped from a SHA-pinned action
ref customers already vet at the action layer — it isn't a
customer-vetted dep, so the release-age policy is the wrong
affordance for our bootstrap and would otherwise hard-fail every
run while the latest publish ages into the customer's window.

closes #713

* also cover pnpm's minimumReleaseAge key for corepack fallback path

* correct pnpm env var (pnpm v11+ uses pnpm_config_*, not npm_config_*)

the prior commit set `npm_config_minimum_release_age=0` to cover the
pnpm corepack-dlx fallback path, but pnpm v11+ only reads env vars
prefixed `pnpm_config_*` / `PNPM_CONFIG_*` (the v10→v11 migration
explicitly renamed the prefix). swap to the correct env var so the
fallback path actually neutralises pnpm's `minimumReleaseAge`.

also tighten the comment block, and add an AGENTS.md rule reminding
us to fetch top-level reviews AND inline review comments together —
they live on different endpoints and the inline set is easy to miss
with `gh pr view --json reviews,comments` alone.

* add scripts/pr-reviews.ts for one-shot review evaluation

dumps top-level reviews + inline review threads (with resolved/outdated
state) + PR-level conversation in a single GraphQL round trip, so agents
don't miss inline-comment feedback. fixes the trap where
`gh pr view --json reviews,comments` silently omits the inline
`pulls/{n}/comments` set.

borrows `gh auth token` so no env vars are required. registered in
`wiki/scripts.md`; AGENTS.md rule updated to point at the script
instead of the two-step gh-CLI workaround.

* pr-reviews: dump raw JSON for jq piping
2026-05-14 01:48:14 +00:00
Colin McDonnell 951745ec89 disable stop hook (runtime + dashboard) (#727) 2026-05-14 01:44:32 +00:00
Colin McDonnell 56793d4a81 claude: prefer non-JSON stdout over NDJSON tail in exit-1 fallback (#643) (#726)
Claude CLI under CLAUDE_CODE_OAUTH_TOKEN exits 1 without setting `is_error`
when the OAuth subscription's quota is exhausted. The existing fallback
chain (`lastResultError || stderr || tailLines(stdout)`) had nothing
structured to grab and dumped ~2KB of `system/init` NDJSON into the
progress comment, hiding the actionable quota notice the CLI had already
printed as plain text.

Capture non-JSON stdout lines into a 20-line ring buffer (mirroring the
existing `recentStderr` pattern) and prefer it over the raw NDJSON tail.
Generic — no regex on bubble text — so any human-readable line the CLI
emits surfaces instead of the event stream.

Also adds a `failure:claude-oauth-quota` bucket to `analyze-logs.ts`,
ordered before the SIGTERM check so the NDJSON tail's `cancelled` /
`cancel_url` substrings (from learnings content) stop shadowing it.
2026-05-14 01:26:10 +00:00
Colin McDonnell d857e06731 postrun: tighten unsubmitted-review gate to require create_pull_request_review for Review mode (#724)
The gate at `getUnsubmittedReview` accepted `toolState.finalSummaryWritten`
as a valid Review exit, contradicting the post-failure error message which
already says Review's only valid exit is `create_pull_request_review`.
This let any caller that flipped `finalSummaryWritten` — including a
`task`-dispatched `reviewfrog` subagent calling `pullfrog_report_progress`
in violation of its prose-only read-only contract — silence the gate even
when the orchestrator never submitted a review.

Split per-mode: Review requires `toolState.review`, IncrementalReview keeps
the existing `||` (its post-failure message explicitly accepts
`report_progress` as a "no review warranted" exit). Test split mirrors the
new semantics.

closes #648
2026-05-14 00:01:15 +00:00
Colin McDonnell b9f0938405 mcp: restore operational guidance dropped in #723
#723's revision pass cut four substantive strings along with the
negative anchors. those strings address real, audit-observed failure
modes and the positive examples don't carry them.

restored:
- push_branch: "if the response reports a timeout, the underlying
  push may have actually succeeded — verify with git log
  origin/<branch> before retrying" (was on the tool description)
- create_pull_request_review commit_id .describe(): "must be the FULL
  40-character SHA — abbreviated SHAs are rejected by GitHub with 422"
- create_pull_request_review comments[].line .describe(): "must sit
  inside a `@@` hunk... dropped entries are reported under
  droppedComments in the response"
- create_pull_request_review comments[].start_line .describe(): "both
  start_line and line must sit inside the same @@ hunk"

also: get_commit_info example used a 31-character SHA (non-standard
truncation). swapped to a 7-char short form, which is what git
log --oneline emits and what agents see in practice. note that this
tool accepts either full or abbreviated, unlike create_pull_request_review
which requires full.
2026-05-13 22:49:06 +00:00
Colin McDonnell b8ac42e875 mcp: embed example calls in top-level tool descriptions (#723)
* mcp: embed example calls in top-level tool descriptions

agents (esp. claude sonnet) hallucinate param names from training-data
priors — `pr_number` instead of `pull_number`, `summary` instead of
`body`, full subcommand strings jammed into `git({command})` like it
were `shell({command})`. each error burns a tool round-trip plus a
follow-up ToolSearch, ~40+ events / 24h, no observable recovery cost
to us but visible to users in agent logs.

cheapest fix: add a sample formatted function call to every affected
tool's top-level description. example anchors are more reliable than
schema descriptions alone because the model treats descriptions as
narrative but call examples as canonical structure. for `git` and
`shell` (whose `command` fields collide), include explicit
counter-examples disambiguating which tool owns which shape.

no schema aliases / coercion yet — try the cheap thing first; if the
next audit window still shows the same hallucination rate, layer
aliases on top per #585's recommendation.

closes #585, closes #701

* mcp: drop negative anchors from tool descriptions

negation is a footgun in tool descriptions — telling the model "NOT
pr_number" makes pr_number more salient, not less. let the positive
example carry the schema and trust the model to read it.

removes:
- "the parameter is pull_number (a number), NOT pr_number" and
  similar across checkout_pr, get_pull_request, list_pull_request_reviews,
  get_review_comments, create_pull_request_review
- "NOT summary, message, or content" on report_progress
- "WRONG: git({ command: 'log --oneline' })" counter-example on git
- redundant param-type restatements after the example (e.g. "depth is a
  number, not a string" on git_fetch, "description is required" on shell)

keeps a single positive example per tool. for tools with multiple call
shapes (git, git_fetch, push_branch), two positive examples instead of
one + a counter-example.
2026-05-13 22:45:08 +00:00
Colin McDonnell 868576a474 audit: format byok auth errors actionably + tighten audit prompt
- `action/utils/apiKeys.ts`: rewrite the missing-key body as Markdown with
  linked CTAs (repo secrets / model settings / docs). add
  `isApiKeyAuthError` + `formatApiKeyErrorSummary` covering both shapes:
  missing key (#679) and revoked/invalid 401 key (#702).
- `action/main.ts`: reclassify in the result-failure branch and the catch
  block so the PR progress comment surfaces the actionable CTA instead of
  the raw `Invalid API key · Fix external API key` / numbered-list dump.
- `scripts/analyze-logs.ts`: split `failure:user-misconfig` into
  `:no-key` and `:invalid-key` so both buckets are visible separately
  and the audit can ignore them as user-correctable.
- `.github/workflows/run-audit.yml`: add three explicit prompt rules —
  cross-customer signal required (≥3 distinct accounts; single-customer
  concentration is not enough), recovered failures are not actionable,
  user misconfig is out of scope. closes the loop on #679 / #702 being
  filed in the first place.
2026-05-13 21:59:47 +00:00
Colin McDonnell b2b1e588e7 biome: exclude .scripts/ — gitignored operator scratchpad
Mirrors the gitignore. Same shape as the existing !**/logs / !**/.logs
/ !.worktrees exclusions in files.includes. Matches the upstream
.gitignore policy for the .scripts/ directory.

Without this, .scripts/ scripts (`.scripts/kyle-*.ts`,
`.scripts/check-comment.ts`, etc.) get scanned by `pnpm lint` and
`pnpm format` from the repo root and routinely fail husky pre-push
even though they're explicitly intended to be local-only / personal.
The companion to .gitignore — both are operator-owned scratchpads;
neither participates in repo-wide hygiene.
2026-05-13 21:25:43 +00:00
Colin McDonnell 5caeb75344 review: 0-or-2+ lens rule, parallel-or-bust, downshifted subagent models (#710)
* review: 0-or-2+ lens rule, parallel-or-bust, downshifted subagent models

PR review wall-time was dominated by two failure modes: orchestrator
serial-dispatching subagents (despite prompt asking for parallel) and
running every lens on the same Opus tier as the orchestrator. Sample of
recent runs showed 25-60min reviews on small PRs, with 8-10min idle
gaps between subagent dispatches.

Three changes:

1. `action/modes.ts` — replace the soft "1 trivial / 2-3 typical /
   4-5 high-stakes" lens calibration with a binary 0-or-2+ rule. Default
   is 0 lenses (orchestrator handles review solo with optional cheap
   tracerfrog dispatches). 2+ parallel lenses only fire for substantive
   PRs (>5 files AND >200 lines) or high-stakes-subsystem touches. Never
   exactly one. Both Review and IncrementalReview prompts get loud
   ALL-CAPS framing on parallel dispatch — emit ALL Task tool_use blocks
   in a single assistant turn before reading any result. Drop the
   "do NOT lens-review the diff yourself" advice; orchestrator pulls
   context aggressively, in parallel with the lens fan-out.

2. New `tracerfrog` subagent for mechanical code tracing ("where is X
   used / who calls Y / what depends on Z"). Pure read+grep+report with
   no judgment — orchestrator can dispatch many tracers cheaply in
   parallel. Defined in `action/agents/reviewer.ts`. Wired into both
   claude.ts (`--agents` JSON) and opencode.ts (`agent` config block).

3. Per-subagent model downshifts via `deriveSubagentModels`:
   - Anthropic: reviewfrog → Sonnet, tracerfrog → Haiku
   - OpenAI: both → gpt-5.4-mini
   - other providers (xai, deepseek, gemini, etc.): inherit (no
     standard tier triplet to downshift to)

Claude Code path always runs Anthropic so the downshift is hardcoded
inline in claude.ts. OpenCode uses the helper since orchestrator
provider varies.

Both runtimes' subagent-definition formats verified directly against
their source: `--agents` JSON `model` field (claude-code's
`AgentJsonSchema` accepts model+effort+maxTurns+more) and OpenCode's
`agent.{name}.model` config field (parsed via Provider.parseModel,
applied per-task in tool/task.ts line 92). Parallel dispatch is
infra-supported in both — only the orchestrator model's tool_use
emission pattern was the bottleneck.

Tests: subagentModels.test.ts (14 tests covering provider matrix),
subagentRegistration.test.ts (6 source-asserts catching shape
regressions in buildAgentsJson / buildReviewerAgentConfig).

* subagentModels: add openrouter routes (proxy/router mode)

Initial helper missed the openrouter prefix used by Pullfrog's router
proxy. preview-710 e2e showed the OpenCode + openrouter path receiving
no downshift — orchestrator and lenses both ran on opus-4.7 because
'openrouter/anthropic/claude-opus-4.7' didn't match any of the
anthropic/openai prefixes the helper checked.

Add explicit branches for 'openrouter/anthropic/...' (uses dot notation:
claude-sonnet-4.6 / claude-haiku-4.5) and 'openrouter/openai/...'
(gpt-5.4-mini for both reviewer and tracer). Same opus->sonnet,
sonnet->keep-but-haiku-tracer, haiku->no-op semantics as the direct
anthropic path.

* opencode: log resolved subagent models at startup

So we can verify per-subagent model overrides actually take effect at
runtime. Prints once per run alongside the existing model/effort log
lines.

* drop tracerfrog: keep reviewfrog only, LSP-powered tracer planned later

Removes the cheap-haiku-tracer subagent (TRACER_AGENT_NAME +
TRACER_SYSTEM_PROMPT, registrations in claude.ts/opencode.ts, dispatch
guidance in modes.ts). The mechanical-tracing use case will be served
better by an LSP-powered tool than by a separately-prompted subagent.

deriveSubagentModels collapses to a single { reviewer } shape; the
reviewfrog-on-Sonnet downshift stays. Same source-assert + provider-
matrix tests, minus the tracer-specific cases.

modes.ts wording: drop the 'subagent type cheat sheet' bullet, drop
the parenthetical 'often better served by tracerfrog than reviewfrog'
on the impact lens, drop tracerfrog from the same-turn-context-pulling
hint. The 0-or-2+ rule and ALL-CAPS parallel emphasis are unchanged.

* subagentModels: broader downshift coverage (gpt-pro, gemini-pro, grok); drop gpt-mini target

Scanned every resolved orchestrator slug in action/models.ts against
models.dev pricing data. Identified five clear cases where the
orchestrator is meaningfully expensive AND has a cheaper sibling that
remains capable enough for review-style judgment work.

Changes:
- Anthropic: opus → sonnet  (kept; -40%)
- OpenAI: gpt → gpt-5.4 (was: gpt-mini; -54% instead of -85% but
  preserves review-quality judgment — gpt-mini was too dumb)
- OpenAI: gpt-pro → gpt   (NEW; -93%, biggest single unlock —
  gpt-5.5-pro is $30/Mtok in vs gpt-5.5 at $5)
- Google: gemini-pro → gemini-flash  (NEW; -75%)
- xAI: grok-4.3 → grok-4-1-fast  (NEW; -80%)

Every branch handles the three routes in use: direct provider slug,
opencode-vendored, and openrouter-proxied. Variants below the downshift
target (mini/nano/flash/fast/sonnet/haiku) inherit (no further drop).

Skipped:
- DeepSeek: v4-flash ($0.14/Mtok) is too far below review judgment
  threshold; v4-pro orchestrator already cheap ($0.55 blended).
- Moonshot: kimi-k2-thinking would only save 32% and slug stability on
  OpenRouter is uncertain; revisit if cost matters.
- o3: already mid-tier in OpenAI's reasoning family; no clean target.

* models: hoist subagent downshift into the registry, add hidden flag

The downshift relationship now lives next to each alias's resolve /
openRouterResolve as a sibling field. Two new ModelDef fields:

- subagentModel?: string — alias key (within same provider) of the
  cheaper sibling reviewfrog should use as a lens-fanout subagent.
  e.g. claude-opus → 'claude-sonnet'.
- hidden?: boolean — exclude from selectable lists (UI dropdown,
  CLI init picker). Does NOT affect resolution; for that use
  fallback. Used so internal-only subagent targets like openai/gpt-5.4
  exist in the registry but never appear as a user-facing pick.

Wiring:
- anthropic.claude-opus → claude-sonnet (-40%)
- openai.gpt-pro → gpt (-93%, biggest unlock)
- openai.gpt → gpt-5.4 (-54%); gpt-5.4 added with hidden:true
- google.gemini-pro → gemini-flash (-75%)
- mirrored across opencode + openrouter providers (each provider
  declares its own three-route data so the downshift declaration
  is colocated with the rest of the alias definition).

deriveSubagentModels collapses from ~85 lines of prefix-matching to
a ~15-line registry reverse-lookup: find the alias whose resolve OR
openRouterResolve matches the orchestrator's spec, follow its
subagentModel pointer, return the matching field of the target alias.

Filter sites updated:
- components/ModelSelector.tsx: !a.fallback && !a.hidden
- action/commands/init.ts:       same

Tests rewritten to exercise the registry through the public surface;
the matrix collapses to one assertion per (provider × route) pair.

* TEMP: log per-step cost+tokens for subagent model verification (PR #710)

* TEMP: also log SUBAGENT step_finish from bus envelope handler

* remove temporary per-step diagnostic logs (verification done)

Verified subagent model downshift takes effect end-to-end on the OpenCode
+ openrouter path. PR #8 in pullfrog/preview-710-review-perf dispatched
3 lenses (billing-subsystem / security / correctness) on the orchestrator's
opus-4.7 session, and per-subagent step_finish events showed actual cost
exactly matching Sonnet pricing rates (60% of what Opus would have cost):

  session       n  actual    if-Opus   if-Sonnet  match
  T3VrUuF...    5  $0.2425   $0.4042   $0.2425    Sonnet ✓
  93ZZR7E...    4  $0.2253   $0.3754   $0.2253    Sonnet ✓
  Fb1Kr7b...    4  $0.2495   $0.4158   $0.2495    Sonnet ✓

The startup '» subagent models: reviewfrog=...' line stays — useful
permanent diagnostic showing the resolved subagent model per-run.

* TEMP: log per-event model from claude.ts assistant handler

* remove temporary per-event model log (claude.ts verification done)

Verified subagent model downshift takes effect end-to-end on the Claude
Code path. PR #9 in pullfrog/preview-710-review-perf dispatched 2 lenses
on an opus-4-7 orchestrator. Per-assistant-event model field from the
SDK's stream-json output, partitioned by parent_tool_use_id:

  ORCH (parent_tool_use_id=null):  17 events all model=claude-opus-4-7
  SUBAGENT lens:billing-subsystem: 17 events all model=claude-sonnet-4-6
  SUBAGENT lens:security:          21 events all model=claude-sonnet-4-6

Zero leakage to opus from either subagent session. The per-subagent
'model' field in --agents JSON is honored by claude-code at the SDK
level, identical to the OpenCode path verified earlier.

* opencode: bump per-call output cap 5K → 16K to unblock large reviews

The 5K cap (added in #616 to lower OpenRouter upfront budget reservation
for low-wallet runs) was capping the entire response of a single LLM call,
not just the budget reservation. A single tool_use response — like a
`create_pull_request_review` with many inline comments — would truncate
mid-stream past 5K output tokens, leave the JSON unparseable, and the tool
would never actually invoke. We hit this on PR #710's verify-downshift PR:
review aggregated from 3 lenses had 11 inline comments + a long body,
truncated at out=5000 on every retry attempt, action exited with 'Review
mode finished without calling create_pull_request_review after 3 retry
attempts'.

Investigated whether OpenCode (or OpenAI/Anthropic/OpenRouter directly)
exposes a separate budget-reservation parameter that could stay small
while letting the response exceed it. They don't — `max_tokens` /
`max_completion_tokens` is the single value all four use for both the
upfront reservation and the hard output ceiling. No way to decouple them
at the API surface.

Bumped to 16K as a middle ground: 8× the prior cap (handles every review
shape we've observed plus headroom), still half of OpenCode's 32K default
so the wallet-burn benefit for low-balance accounts is preserved, just
smaller. For Opus 4.7 a typical ~50K-input call now reserves roughly
$0.65 instead of the prior $0.38.

Updated the constant comment to spell out the trade-off clearly so this
doesn't happen again.

* opencode: drop OPENCODE_EXPERIMENTAL_OUTPUT_TOKEN_MAX override entirely

Verified the original rationale for the override is obsolete. From #616
the cap shrunk OpenRouter's per-call upfront budget reservation so a
single call's reservation wouldn't exceed the per-run key cap
(`ROUTER_PER_RUN_LIMIT_USD = 25`) and lock low-balance accounts out of
starting a run.

That per-run gate is gone. `app/api/proxy-token/route.ts` ~line 422
explicitly says: 'No upper cap (the old ROUTER_PER_RUN_LIMIT_USD = 25 is
gone). The natural ceiling is whatever the user has + their buffer.'
Router now mints keys with `keyLimitCents = balance + buffer` ($50 for
autoreload+card, $5 for card-only, $0 for no-card). A single call's
upfront reservation fits comfortably within that — no separate per-call
gate to fail past.

The cap had a real downside as a hard per-call output truncation. A
single `create_pull_request_review` tool_use with many inline comments
would truncate mid-stream past 5K output tokens, the JSON would be
unparseable, and the tool never invoked. Hit on PR #710's
verify-downshift PR.

Removing the override entirely; OpenCode falls back to its 32K default.
Left an explanatory note above the env-var assignment site so the next
person doesn't unknowingly re-add it.
2026-05-13 21:05:52 +00:00
David Blass 5518890b18 learnings: TOC + section taxonomy + 100k cap, hygiene rules, tool-quirk descriptions (#717)
* audit learnings: reshape reflection prompt + bake tool quirks into descriptions (#619)

Cross-repo audit of the 48 repos with non-null learnings turned up two
recurring failure modes:

1. ~25-30% of bullets across the most-active repos are pullfrog-tool
   quirks ("shell timeout is in milliseconds", "git args must be a JSON
   array", "create_pull_request_review drops out-of-hunk comments",
   "push_branch may report timeout when push succeeded", "checkout_pr
   shallow.lock retries", "commit_id needs full 40-char SHA"). These are
   universal across repos and should live in tool descriptions, not be
   rediscovered and stored 48 times. Tool descriptions now surface them.

2. Bullets are routinely 200-1000 chars (paragraph-length), and 12 of 48
   repos are at the 10k cap. The reflection prompt now: caps bullets at
   ~240 chars (one specific fact), bans PR/review/commit/date-anchored
   facts that decay within weeks, bans tool-quirk learnings, and tells
   the agent that cap pressure means compress+prune existing bullets,
   not skip new findings.

Co-authored-by: Cursor <cursoragent@cursor.com>

* learnings: add server-generated TOC, fixed section taxonomy, raise cap to 100k (#707)

Cap goes 10k → 100k. Reads stay bounded because the seeded file now
opens with a server-generated table of contents listing every `## `
section's line range — agents read the TOC, then `read_file offset/limit`
just the sections relevant to the current task instead of slurping the
whole file.

## Section taxonomy (fixed)

`## Build & test`, `## CI`, `## Conventions`, `## Architecture`,
`## Gotchas`. Free-form `### ` sub-headings inside a section are fine.
Pre-taxonomy free-text rows get wrapped in a `## Legacy` carve-out on
first seed so they remain visible while the agent gradually re-curates
them during reflection turns.

## Storage shape unchanged

`Repo.learnings` still holds raw markdown (no schema migration). The TOC
is a pure read-side affordance: prepended at seed time, stripped from
the agent-edited file before persist. Markers
`<!-- pullfrog-learnings-toc:* -->` delimit the strip region. Agent
edits inside the markers are discarded.

## Round-trip semantics

`seedLearningsFile` now returns `{ path, canonicalSeed }` where
`canonicalSeed` is the post-TOC body — same shape `readLearningsFile`
returns at end-of-run, so `persistLearnings` byte-compares them
directly to skip the no-op PATCH. Empty-repo first runs end up with the
section scaffold both as seed and as read-back, so untouched runs still
short-circuit cleanly.

## Reflection prompt

Adds explicit section-placement guidance (place each new bullet under
the most relevant `## `; do NOT add new top-level headings; do NOT
edit anything between the TOC markers). Carries forward the bullet
hygiene from the previous commit: ≤240 chars per bullet, no
pullfrog-tool quirks (those belong in tool descriptions), no
PR/review/commit/date references. The "near cap" framing is replaced
with "compress and prune within a section when it grows noisy" since
the cap pressure that drove cramming is gone.

Co-authored-by: Cursor <cursoragent@cursor.com>

* anneal round 1: line-anchored taxonomy detect, partial-merge, line-boundary truncation, scaffold-empty UI

Multi-lens review of the TOC + taxonomy diff surfaced a cluster of
correctness and operational bugs. Fixes:

- `hasAnyTaxonomyHeading` used `String.includes("## X")` which
  false-positives on `### X` (the `## ` substring sits inside `### `),
  prose containing `## CI`, fenced code documenting markdown, etc.
  Replaced with a line-anchored predicate that reuses `parseHeadings`
  so detection and TOC construction stay consistent.

- The "any heading present → pass through verbatim" rule meant a body
  with one taxonomy heading would seed without the other four. Worse,
  requiring all five would flip a body back into Legacy when the agent
  legitimately pruned a section to empty. New `partial` kind: keep
  existing content in place, append missing sections in canonical order
  so the agent always has the full scaffold without losing pruning
  intent.

- `stripLearningsToc` collapsed `\n{3,}` globally; `canonicalSeed`
  doesn't, so an untouched body with intentional triple-newline spacing
  would compare unequal and burn a spurious LearningsRevision row each
  run. Drop the global collapse — only the leading newlines that the
  strip itself introduces are normalized.

- 100k truncation via `slice(0, 100_000)` could cut mid-line, breaking
  `parseHeadings` (whole-line `^## `) on the next seed and flipping a
  cut body back into Legacy. New `truncateAtLineBoundary` cuts at the
  last newline before the cap.

- `LearningsSection.tsx` rendered a scaffold-only body as "has
  learnings" instead of the empty placeholder. Added a
  `hasOnlyEmptyScaffold` guard so the console behaves the same as
  pre-PR for the empty case.

- Seed log line distinguishes `kind=structured/partial/legacy-wrapped/
  empty` instead of `existing=yes/no`, so operators can spot legacy
  migration activity in logs.

- New tests cover: substring false-positive (`### Build & test`,
  in-prose mentions), partial-taxonomy merge (no Legacy wrap),
  full-taxonomy structured pass-through, last-newline truncation,
  triple-newline preservation.

Deferred (documented in PR body): deploy-ordering footgun (action
before API), rollback for rows >10k, Gemini sanitizer dropping
`description` on `anyOf` branches, reflection-on-failed-runs.

Co-authored-by: Cursor <cursoragent@cursor.com>

* anneal r2: hard-truncate fallback when line boundary discards >4k

Round-2 review caught a regression in `truncateAtLineBoundary`: when the
only newline within the first 100k chars sits near the start (e.g. one
heading + 100k+ char single line — pathological pasted log dumps), the
line-boundary cut discards almost all of the body. losing one partial
line is preferable to losing kilobytes; threshold the fallback at 4k.

Co-authored-by: Cursor <cursoragent@cursor.com>

* move TOC out of file: prompt-side rendering, server-parsed headings

drops the in-file TOC + fixed taxonomy in favor of:
- file on disk = verbatim Repo.learnings (no markers, no scaffold)
- server parses headings (mdast-util-from-markdown) at run-context time
  and returns them as RepoSettings.learningsHeadings
- action renders heading TOC into the LEARNINGS prompt section as
  parenthesized line ranges like `Build & test (L1-L42)` with hierarchy
  via 2-space indent off the shallowest depth
- reflection prompt teaches agent-curated structure with a soft 300-line
  per-section cap and explicit guidance to restructure flat legacy lists

cuts 8 helpers (ensureSections, stripLearningsToc, assembleFile,
buildTocBlock, parseHeadings, buildSectionScaffold, hasAnyTaxonomyHeading,
LEARNINGS_SECTIONS) and the canonicalSeed round-trip dance.

action seedLearningsFile is now { path } only; main.ts byte-compares the
trimmed read-back against (current ?? "").trim() to gate the persist
PATCH. truncateAtLineBoundary kept for safety.

new tests:
- test/learningsToc.test.ts (11 parser cases incl. fenced-code, blockquote,
  arbitrary h1-h6 nesting, startLine-points-at-heading invariant)
- action/utils/learningsTocRender.test.ts (7 renderer cases)

---------

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Colin McDonnell <colinmcd94@gmail.com>
2026-05-13 20:14:26 +00:00
40 changed files with 1473 additions and 214 deletions
+3
View File
@@ -55,6 +55,9 @@ jobs:
OPENROUTER_API_KEY: ${{ secrets.OPENROUTER_API_KEY }} OPENROUTER_API_KEY: ${{ secrets.OPENROUTER_API_KEY }}
MOONSHOT_API_KEY: ${{ secrets.MOONSHOT_API_KEY }} MOONSHOT_API_KEY: ${{ secrets.MOONSHOT_API_KEY }}
OPENCODE_API_KEY: ${{ secrets.OPENCODE_API_KEY }} OPENCODE_API_KEY: ${{ secrets.OPENCODE_API_KEY }}
AWS_BEARER_TOKEN_BEDROCK: ${{ secrets.AWS_BEARER_TOKEN_BEDROCK }}
AWS_REGION: us-east-1
BEDROCK_MODEL_ID: us.anthropic.claude-opus-4-6-v1
PULLFROG_MODEL: ${{ vars.PULLFROG_MODEL }} PULLFROG_MODEL: ${{ vars.PULLFROG_MODEL }}
steps: steps:
- uses: actions/checkout@v6 - uses: actions/checkout@v6
+60 -4
View File
@@ -16,6 +16,7 @@ import { mkdirSync, writeFileSync } from "node:fs";
import { join } from "node:path"; import { join } from "node:path";
import { performance } from "node:perf_hooks"; import { performance } from "node:perf_hooks";
import { pullfrogMcpName } from "../external.ts"; import { pullfrogMcpName } from "../external.ts";
import { BEDROCK_MODEL_ID_ENV, isBedrockAnthropicId } from "../models.ts";
import { getIdleMs, markActivity } from "../utils/activity.ts"; import { getIdleMs, markActivity } from "../utils/activity.ts";
import { formatJsonValue, log } from "../utils/cli.ts"; import { formatJsonValue, log } from "../utils/cli.ts";
@@ -72,17 +73,27 @@ function writeMcpConfig(ctx: AgentRunContext): string {
/** /**
* Build the `--agents` JSON definition for the `reviewfrog` subagent. * Build the `--agents` JSON definition for the `reviewfrog` subagent.
*
* The Claude Code path always runs against an Anthropic model (see
* resolveAgent), so we hardcode the cheaper-sibling downshift: lenses run
* on Sonnet, the orchestrator stays on whatever model `--model` was passed.
*
* Per-call model override is also possible (Task tool's `model` arg accepts
* 'sonnet' | 'opus' | 'haiku') and takes precedence over what's set here —
* we don't pass it; the per-subagent `model` field is the right default.
*
* The non-mutative + non-recursive contract is enforced by the prose system * The non-mutative + non-recursive contract is enforced by the prose system
* prompt baked into the agent — see action/agents/reviewer.ts for why we no * prompt baked into the agent — see action/agents/reviewer.ts for why we
* longer wire per-agent `disallowedTools` here. * no longer wire per-agent `disallowedTools` here.
*/ */
function buildAgentsJson(): string { function buildAgentsJson(): string {
const agents = { const agents = {
[REVIEWER_AGENT_NAME]: { [REVIEWER_AGENT_NAME]: {
description: description:
"Read-only review subagent for self-review and lens-based code review. " + "Read-only review subagent for lens-based code review (correctness, security, billing-subsystem, etc.). " +
"Reads only — no writes, no state-changing shell or MCP calls, no nested subagent dispatch.", "Reads only — no writes, no state-changing shell or MCP calls, no nested subagent dispatch.",
prompt: REVIEWER_SYSTEM_PROMPT, prompt: REVIEWER_SYSTEM_PROMPT,
model: "claude-sonnet-4-6",
}, },
}; };
return JSON.stringify(agents); return JSON.stringify(agents);
@@ -539,6 +550,13 @@ export async function runClaude(params: RunParams): Promise<ClaudeRunResult> {
}; };
const recentStderr: string[] = []; const recentStderr: string[] = [];
// ring buffer of recent non-JSON stdout lines. Claude CLI prints
// human-readable TTY chrome (status bubbles, quota notices, etc.)
// alongside the NDJSON event stream. when the CLI exits non-zero without
// emitting a structured error event, these lines are the only actionable
// signal — preferring them over the NDJSON tail keeps progress comments
// readable. issue #643.
const recentNonJsonStdout: string[] = [];
let lastProviderError: string | null = null; let lastProviderError: string | null = null;
@@ -584,6 +602,8 @@ export async function runClaude(params: RunParams): Promise<ClaudeRunResult> {
event = JSON.parse(trimmed) as ClaudeEvent; event = JSON.parse(trimmed) as ClaudeEvent;
} catch { } catch {
log.debug(`» non-JSON stdout line: ${trimmed.substring(0, 200)}`); log.debug(`» non-JSON stdout line: ${trimmed.substring(0, 200)}`);
recentNonJsonStdout.push(trimmed);
if (recentNonJsonStdout.length > MAX_STDERR_LINES) recentNonJsonStdout.shift();
continue; continue;
} }
@@ -685,9 +705,16 @@ export async function runClaude(params: RunParams): Promise<ClaudeRunResult> {
const stdoutSnapshot = output.toString(); const stdoutSnapshot = output.toString();
const stderrSnapshot = recentStderr.join("\n"); const stderrSnapshot = recentStderr.join("\n");
const truncatedStdout = stdoutSnapshot ? tailLines(stdoutSnapshot, 2048) : ""; const truncatedStdout = stdoutSnapshot ? tailLines(stdoutSnapshot, 2048) : "";
// prefer non-JSON stdout (human-readable TTY chrome the CLI prints,
// including status bubbles and quota notices) over the raw NDJSON
// tail. when the CLI exits 1 without emitting `is_error` (issue #643),
// the NDJSON fallback would otherwise dump 2KB of `system/init` events
// into the progress comment with no mention of the actual cause.
const nonJsonStdoutSnapshot = recentNonJsonStdout.join("\n");
const errorMessage = const errorMessage =
lastResultError || lastResultError ||
stderrSnapshot || stderrSnapshot ||
nonJsonStdoutSnapshot ||
truncatedStdout || truncatedStdout ||
`unknown error - no output from Claude CLI${errorContext}`; `unknown error - no output from Claude CLI${errorContext}`;
log.error( log.error(
@@ -818,7 +845,22 @@ export const claude = agent({
const cliPath = await installClaudeCli(); const cliPath = await installClaudeCli();
const specifier = ctx.payload.proxyModel ?? ctx.resolvedModel; const specifier = ctx.payload.proxyModel ?? ctx.resolvedModel;
const model = specifier ? stripProviderPrefix(specifier) : undefined; // claude-code on Bedrock takes the bare AWS model ID — no provider prefix
// to strip, since the ID is already in `provider.model` form (e.g.
// `us.anthropic.claude-opus-4-7`). detect via the env-var sentinel: if
// BEDROCK_MODEL_ID is set and matches the resolved specifier, this is a
// bedrock route. see `wiki/model-resolution.md` for the routing pattern.
const bedrockModelId = process.env[BEDROCK_MODEL_ID_ENV]?.trim();
const isBedrockRoute =
specifier !== undefined &&
bedrockModelId !== undefined &&
bedrockModelId === specifier &&
isBedrockAnthropicId(specifier);
const model = !specifier
? undefined
: isBedrockRoute
? specifier
: stripProviderPrefix(specifier);
const homeEnv = { const homeEnv = {
HOME: ctx.tmpdir, HOME: ctx.tmpdir,
@@ -865,10 +907,24 @@ export const claude = agent({
// agent process gets full env — needs LLM API keys, PATH, locale, etc. // agent process gets full env — needs LLM API keys, PATH, locale, etc.
// security is enforced via managed-settings.json, --disallowedTools (Bash), and MCP tool filtering. // security is enforced via managed-settings.json, --disallowedTools (Bash), and MCP tool filtering.
//
// bedrock route: claude-code reads `CLAUDE_CODE_USE_BEDROCK=1` to switch
// its provider implementation from the direct Anthropic API to Bedrock.
// AWS_BEARER_TOKEN_BEDROCK / AWS_ACCESS_KEY_ID + AWS_SECRET_ACCESS_KEY +
// AWS_REGION are already in process.env from the workflow's `env:` block.
// see https://docs.claude.com/en/docs/claude-code/amazon-bedrock.
//
// we only force CLAUDE_CODE_USE_BEDROCK=1 when this is a Pullfrog-routed
// bedrock run; if the user has set the env var manually for some other
// reason (e.g. always-Bedrock org policy), `...process.env` already
// carries it through and we don't disturb it.
const env: Record<string, string | undefined> = { const env: Record<string, string | undefined> = {
...process.env, ...process.env,
...homeEnv, ...homeEnv,
}; };
if (isBedrockRoute) {
env.CLAUDE_CODE_USE_BEDROCK = "1";
}
const repoDir = process.cwd(); const repoDir = process.cwd();
+67 -27
View File
@@ -16,7 +16,7 @@ import { mkdirSync, writeFileSync } from "node:fs";
import { join } from "node:path"; import { join } from "node:path";
import { performance } from "node:perf_hooks"; import { performance } from "node:perf_hooks";
import { pullfrogMcpName } from "../external.ts"; import { pullfrogMcpName } from "../external.ts";
import { modelAliases } from "../models.ts"; import { BEDROCK_MODEL_ID_ENV, modelAliases } from "../models.ts";
import { getIdleMs, markActivity } from "../utils/activity.ts"; import { getIdleMs, markActivity } from "../utils/activity.ts";
import { formatJsonValue, log } from "../utils/cli.ts"; import { formatJsonValue, log } from "../utils/cli.ts";
import { installFromNpmTarball } from "../utils/install.ts"; import { installFromNpmTarball } from "../utils/install.ts";
@@ -48,6 +48,7 @@ import {
logTokenTable, logTokenTable,
MAX_STDERR_LINES, MAX_STDERR_LINES,
} from "./shared.ts"; } from "./shared.ts";
import { deriveSubagentModels } from "./subagentModels.ts";
async function installOpencodeCli(): Promise<string> { async function installOpencodeCli(): Promise<string> {
return await installFromNpmTarball({ return await installFromNpmTarball({
@@ -71,21 +72,25 @@ type OpenCodeConfig = {
[key: string]: unknown; [key: string]: unknown;
}; };
/** // NOTE: OpenCode's per-call `max_tokens` defaults to 32_000. We previously
* Per-inference `max_tokens` reservation the agent sends to the upstream // overrode this via `OPENCODE_EXPERIMENTAL_OUTPUT_TOKEN_MAX = 5000` in #616
* model. OpenCode's default is 32_000 (sized for long-running TUI sessions // to lower OpenRouter's per-call upfront budget reservation — back when the
* where a human user might want big outputs). Pullfrog runs are headless and // `ROUTER_PER_RUN_LIMIT_USD = 25` per-run key cap meant that reservation was
* short — typical outputs are 1-3K tokens — so we cap at 5_000. This // a hard gate that could lock low-balance accounts out of starting a run.
* drastically reduces the upfront budget reservation OpenRouter requires per //
* call (~$0.38 vs ~$2.40 for Opus), which is what lets low-wallet runs // That gate is gone (see `app/api/proxy-token/route.ts` ~line 422 — "Per-run
* actually start. // key budget … is decoupled from wallet balance"); the router now mints
* // keys with `keyLimitCents = balance + buffer` ($50 / $5 / $0). The override
* Plumbed via `OPENCODE_EXPERIMENTAL_OUTPUT_TOKEN_MAX` env var rather than the // no longer materially helps, and as a hard per-call output truncation it
* config JSON. OpenCode's `OUTPUT_TOKEN_MAX` (session/llm.ts) is sourced // actively hurt: a single `create_pull_request_review` tool_use with many
* exclusively from this env var; top-level `limit.output` in the config // inline comments would truncate mid-stream past 5K output tokens, the JSON
* has no read site and is silently dropped on merge. // was unparseable, and the tool never invoked. We hit this on PR #710's
*/ // verify-downshift PR. Removed in #710 — using OpenCode's 32K default.
const PULLFROG_OPENCODE_OUTPUT_LIMIT = 5000; //
// If you need to re-cap output for some reason, set
// `OPENCODE_EXPERIMENTAL_OUTPUT_TOKEN_MAX` in the action env. OpenCode's
// top-level `limit.output` config field has no read site (silently dropped
// on merge in session/llm.ts), so the env var is the only working knob.
/** /**
* upstream opencode hardcodes `thinkingLevel: "high"` as the default for every * upstream opencode hardcodes `thinkingLevel: "high"` as the default for every
@@ -120,7 +125,12 @@ function buildSecurityConfig(ctx: AgentRunContext, model: string | undefined): s
mcp: { mcp: {
[pullfrogMcpName]: { type: "remote", url: ctx.mcpServerUrl }, [pullfrogMcpName]: { type: "remote", url: ctx.mcpServerUrl },
}, },
agent: buildReviewerAgentConfig(), agent: (() => {
const cfg = buildReviewerAgentConfig(model);
const reviewerModel = (cfg[REVIEWER_AGENT_NAME] as { model?: string })?.model ?? "(inherit)";
log.info(`» subagent models: reviewfrog=${reviewerModel}`);
return cfg;
})(),
// opt into opencode's experimental `batch` tool (added in // opt into opencode's experimental `batch` tool (added in
// anomalyco/opencode PR #2983, opt-in via `experimental.batch_tool`). it // anomalyco/opencode PR #2983, opt-in via `experimental.batch_tool`). it
// exposes a single `batch` tool that runs 1-25 independent tool calls // exposes a single `batch` tool that runs 1-25 independent tool calls
@@ -159,19 +169,30 @@ function buildSecurityConfig(ctx: AgentRunContext, model: string | undefined): s
} }
/** /**
* Read-only subagent for self-review and /anneal lens dispatch. The * Read-only `reviewfrog` subagent for lens-based review.
* non-mutative + non-recursive contract is enforced by the prose system *
* prompt — see action/agents/reviewer.ts for why we no longer wire per-agent * Non-mutative + non-recursive — enforced by the prose system prompt in
* tool/permission denies here. * reviewer.ts.
*
* Per-subagent `model:` override is driven by the registry in
* `action/models.ts` via each alias's `subagentModel` field — see
* `deriveSubagentModels` for the reverse-lookup. Currently wired:
* Anthropic opus → sonnet, OpenAI gpt-pro → gpt and gpt → gpt-5.4,
* Google gemini-pro → gemini-flash. Other providers (xai, deepseek,
* moonshot) and already-cheap tiers inherit (no override) — either the
* absolute savings are too small to justify or there's no clean
* cheaper-but-capable sibling.
*/ */
function buildReviewerAgentConfig(): Record<string, unknown> { function buildReviewerAgentConfig(orchestratorModel: string | undefined): Record<string, unknown> {
const overrides = deriveSubagentModels(orchestratorModel);
return { return {
[REVIEWER_AGENT_NAME]: { [REVIEWER_AGENT_NAME]: {
description: description:
"Read-only review subagent for self-review and lens-based code review. " + "Read-only review subagent for lens-based code review (correctness, security, billing-subsystem, etc.). " +
"Reads only — no writes, no state-changing shell or MCP calls, no nested subagent dispatch.", "Reads only — no writes, no state-changing shell or MCP calls, no nested subagent dispatch.",
mode: "subagent", mode: "subagent",
prompt: REVIEWER_SYSTEM_PROMPT, prompt: REVIEWER_SYSTEM_PROMPT,
...(overrides.reviewer !== undefined ? { model: overrides.reviewer } : {}),
}, },
}; };
} }
@@ -209,9 +230,12 @@ function autoSelectModel(cliPath: string): string | undefined {
const availableSet = new Set(availableModels); const availableSet = new Set(availableModels);
if (availableSet.size > 0) { if (availableSet.size > 0) {
log.debug(`» opencode models (${availableSet.size}): ${availableModels.join(", ")}`); log.debug(`» opencode models (${availableSet.size}): ${availableModels.join(", ")}`);
// skip hidden aliases (internal subagent-tier targets like opencode/gpt-5.4) —
// they should never surface as a user-facing orchestrator pick. mirrors the
// selectable-list filter in components/ModelSelector.tsx and action/commands/init.ts.
const match = const match =
modelAliases.find((a) => a.preferred && availableSet.has(a.resolve)) ?? modelAliases.find((a) => !a.hidden && a.preferred && availableSet.has(a.resolve)) ??
modelAliases.find((a) => availableSet.has(a.resolve)); modelAliases.find((a) => !a.hidden && availableSet.has(a.resolve));
if (match) { if (match) {
log.info( log.info(
`» model: ${match.resolve} (auto-selected${match.preferred ? " — preferred" : ""} curated match)` `» model: ${match.resolve} (auto-selected${match.preferred ? " — preferred" : ""} curated match)`
@@ -1151,7 +1175,24 @@ export const opencode = agent({
run: async (ctx) => { run: async (ctx) => {
const cliPath = await installOpencodeCli(); const cliPath = await installOpencodeCli();
const model = ctx.payload.proxyModel ?? ctx.resolvedModel ?? autoSelectModel(cliPath); const rawModel = ctx.payload.proxyModel ?? ctx.resolvedModel ?? autoSelectModel(cliPath);
// bedrock route: opencode's `amazon-bedrock` provider expects the model
// string in `amazon-bedrock/<bedrock-id>` form. the bare AWS model ID
// (what the user puts in `BEDROCK_MODEL_ID`) needs the prefix added.
// detect via env-var sentinel — same pattern as claude.ts.
//
// we deliberately do NOT gate on `!isBedrockAnthropicId(rawModel)` here:
// Anthropic-on-Bedrock normally routes to claude-code (per `resolveAgent`),
// but `PULLFROG_AGENT=opencode` is the documented escape hatch for forcing
// opencode regardless. when that override fires, opencode still needs the
// `amazon-bedrock/` prefix or the provider lookup fails with
// "Model not found: <modelId>/.". the Anthropic-vs-other discriminant
// only belongs in `resolveAgent`.
const bedrockModelId = process.env[BEDROCK_MODEL_ID_ENV]?.trim();
const isBedrockRoute =
rawModel !== undefined && bedrockModelId !== undefined && bedrockModelId === rawModel;
const model = isBedrockRoute ? `amazon-bedrock/${rawModel}` : rawModel;
const homeEnv = { const homeEnv = {
HOME: ctx.tmpdir, HOME: ctx.tmpdir,
@@ -1199,7 +1240,6 @@ export const opencode = agent({
...homeEnv, ...homeEnv,
OPENCODE_CONFIG_CONTENT: buildSecurityConfig(ctx, model), OPENCODE_CONFIG_CONTENT: buildSecurityConfig(ctx, model),
OPENCODE_PERMISSION: permissionOverride, OPENCODE_PERMISSION: permissionOverride,
OPENCODE_EXPERIMENTAL_OUTPUT_TOKEN_MAX: PULLFROG_OPENCODE_OUTPUT_LIMIT.toString(),
GOOGLE_GENERATIVE_AI_API_KEY: GOOGLE_GENERATIVE_AI_API_KEY:
process.env.GOOGLE_GENERATIVE_AI_API_KEY || process.env.GEMINI_API_KEY, process.env.GOOGLE_GENERATIVE_AI_API_KEY || process.env.GEMINI_API_KEY,
}; };
+14 -1
View File
@@ -29,9 +29,22 @@ describe("getUnsubmittedReview", () => {
).toBeNull(); ).toBeNull();
}); });
it("returns null when report_progress wrote a final summary", () => { it("fires for Review even when report_progress wrote a final summary", () => {
// Review's only valid exit is `create_pull_request_review`. a summary
// comment is not a substitute, and accepting it here previously let
// subagent-flipped `finalSummaryWritten` silence the gate.
expect( expect(
getUnsubmittedReview(makeToolState({ selectedMode: "Review", finalSummaryWritten: true })) getUnsubmittedReview(makeToolState({ selectedMode: "Review", finalSummaryWritten: true }))
).toBe("Review");
});
it("returns null for IncrementalReview when report_progress wrote a final summary", () => {
// IncrementalReview treats `report_progress` as a legitimate
// "no review warranted" exit, matching the post-failure error message.
expect(
getUnsubmittedReview(
makeToolState({ selectedMode: "IncrementalReview", finalSummaryWritten: true })
)
).toBeNull(); ).toBeNull();
}); });
+55 -12
View File
@@ -30,13 +30,26 @@ import {
* *
* the gate is anchored to `hadProgressComment` so silent runs (non-issue * the gate is anchored to `hadProgressComment` so silent runs (non-issue
* events, dispatcher skipped seeding) don't fire a nudge there's no UI for. * events, dispatcher skipped seeding) don't fire a nudge there's no UI for.
*
* `Review` and `IncrementalReview` have different valid exits:
* - Review: only `create_pull_request_review` counts. `report_progress` is
* not a substitute — a Review run that exits with just a summary comment
* has produced nothing reviewable on the PR. matches the hard-fail
* message at `expected = "create_pull_request_review"` below.
* - IncrementalReview: `report_progress` is a legitimate "no review
* warranted" exit, so either toolState flag short-circuits.
* splitting per mode also closes the bypass where a subagent (e.g. a
* `task`-dispatched `reviewfrog` lens) calls `report_progress` and silences
* the gate even though the orchestrator never submitted a review.
*/ */
export function getUnsubmittedReview(toolState: ToolState): "Review" | "IncrementalReview" | null { export function getUnsubmittedReview(toolState: ToolState): "Review" | "IncrementalReview" | null {
const mode = toolState.selectedMode; const mode = toolState.selectedMode;
if (mode !== "Review" && mode !== "IncrementalReview") return null;
if (toolState.review || toolState.finalSummaryWritten) return null;
if (!toolState.hadProgressComment) return null; if (!toolState.hadProgressComment) return null;
return mode; if (mode === "Review") return toolState.review ? null : "Review";
if (mode === "IncrementalReview") {
return toolState.review || toolState.finalSummaryWritten ? null : "IncrementalReview";
}
return null;
} }
/** /**
@@ -178,10 +191,16 @@ export async function collectPostRunIssues(
options: { skipSummaryStale?: boolean } = {} options: { skipSummaryStale?: boolean } = {}
): Promise<PostRunIssues> { ): Promise<PostRunIssues> {
const issues: PostRunIssues = {}; const issues: PostRunIssues = {};
if (ctx.stopScript) { // stop hook is disabled — production audit (May 2026) showed 8/9 configured
const failure = await executeStopHook(ctx.stopScript); // scripts are foot-guns (duplicates of prepushScript, run on non-committing
if (failure) issues.stopHook = failure; // modes against unchanged trees) burning the retry budget on un-fixable
} // gates. re-enable here + the dashboard block in `AgentSettings.tsx` once
// we've decided on the right semantics (mode-gating vs. HEAD-changed gating
// vs. deletion). see issue #714.
// if (ctx.stopScript) {
// const failure = await executeStopHook(ctx.stopScript);
// if (failure) issues.stopHook = failure;
// }
// dirty-tree gate fires only in modes that legitimately commit. Review / // dirty-tree gate fires only in modes that legitimately commit. Review /
// IncrementalReview / Plan complete via review submission or a Plan // IncrementalReview / Plan complete via review submission or a Plan
// comment, not by touching files — any tree dirt is incidental (e.g. a // comment, not by touching files — any tree dirt is incidental (e.g. a
@@ -237,6 +256,16 @@ export function buildPostRunPrompt(issues: PostRunIssues): string {
* the file is the single source of truth — there is no separate MCP tool * the file is the single source of truth — there is no separate MCP tool
* call. the server reads the file at end-of-run and persists any edits to * call. the server reads the file at end-of-run and persists any edits to
* `Repo.learnings`. * `Repo.learnings`.
*
* the prompt copy is shaped by repo-wide audits of the actual content the
* agent has been writing (issue #619 in pullfrog/app). recurring failure
* modes the framing pushes back on:
* - massive multi-paragraph "bullets" that are really mini-articles
* - PR-/review-/commit-/date-anchored facts that decay within weeks
* - rediscovery of pullfrog-tool quirks that belong in tool descriptions,
* not per-repo learnings
* - sections growing into giant flat lists with no internal structure,
* forcing future runs to read kilobytes to find one fact
*/ */
export function buildLearningsReflectionPrompt(filePath: string): string { export function buildLearningsReflectionPrompt(filePath: string): string {
return [ return [
@@ -244,11 +273,25 @@ export function buildLearningsReflectionPrompt(filePath: string): string {
"", "",
`the rolling learnings file is at \`${filePath}\`. read it first if you haven't already, then edit it in place using your native file tools. the server reads this file at end-of-run and persists any changes — there is no tool to call.`, `the rolling learnings file is at \`${filePath}\`. read it first if you haven't already, then edit it in place using your native file tools. the server reads this file at end-of-run and persists any changes — there is no tool to call.`,
"", "",
`keep the file healthy:`, `structure:`,
`- only add bullets when the finding is high-confidence AND broadly useful. skip speculative, one-off, or "maybe" findings.`, `- markdown hierarchy: \`## \` for top-level themes, \`### \` and deeper for sub-themes when a section grows. there is no fixed taxonomy — choose headings that fit THIS repo (e.g. for one repo \`## Migrations\` / \`## Local dev\` may make sense; for another, \`## API quirks\` / \`## Failure modes\`).`,
`- prune bullets that are clearly wrong, no longer relevant, or low-signal (rarely useful). a focused, accurate file beats a long stale one.`, `- **no section over ~300 lines.** when a section is approaching that, split it: introduce \`### \` subsections grouping related bullets, or hoist a coherent group into a new top-level \`## \` section. granular sections mean future runs read targeted line ranges instead of slurping the whole file. this is the most important hygiene rule on long-lived repos.`,
`- format: flat bullet list, one fact per line starting with \`- \`. deduplicate against existing entries — if a bullet covers the same fact, update it in place instead of adding a duplicate.`, `- if you find a flat unstructured list (legacy content from before this format), restructure it: read it, group related bullets, rewrite the file with \`## \` / \`### \` headings around them. don't preserve bad structure — fix it.`,
`- leave the file alone if you have nothing substantively new to add and the existing entries still look healthy. silence is a valid outcome — just reply "done" and stop.`, "",
`bullet hygiene:`,
`- one fact per line starting with \`- \`. each bullet is ONE specific durable fact, not a paragraph or essay.`,
`- aim for ≤ 240 chars per bullet. longer bullets are almost always mixing multiple facts that should be split, or burying the durable claim under PR-specific context that should be cut.`,
`- only add bullets when the finding is high-confidence AND broadly useful AND will still be true in 3+ months. skip speculative, one-off, or "maybe" findings.`,
`- prune bullets that are clearly wrong, no longer relevant, or low-signal. a focused, accurate file beats a long stale one. compressing two overlapping bullets into one tighter bullet counts as progress.`,
`- deduplicate against existing entries (in any section) — if a bullet covers the same fact, update it in place instead of adding a duplicate.`,
"",
`do NOT add bullets for:`,
`- pullfrog tool quirks (e.g. "\`shell\` timeout is in milliseconds", "\`git\` args must be a JSON array", "\`create_pull_request_review\` drops out-of-hunk comments", "\`push_branch\` may report timeout when push succeeded"). these are universal across repos and belong in the tool descriptions — flag the gap rather than hoarding the workaround per-repo.`,
`- references to specific PR numbers, review IDs, commit SHAs, branch names, or person handles ("PR #595 introduced X", "flagged in review 12345", "as of commit abc123"). repo state changes; these decay into noise within weeks.`,
`- dated assertions ("as of May 2026", "currently...", "for now..."). if a fact needs a date to be true, it isn't durable enough to belong here.`,
`- play-by-play of what THIS run did. learnings are for the NEXT run, not a retrospective.`,
"",
`if you have nothing substantively new to add AND the existing entries still look healthy and well-structured, leave the file alone — just reply "done" and stop. silence is a valid outcome.`,
].join("\n"); ].join("\n");
} }
+110
View File
@@ -0,0 +1,110 @@
import { describe, expect, it } from "vitest";
import { deriveSubagentModels } from "./subagentModels.ts";
describe("deriveSubagentModels", () => {
it("returns no override when orchestrator is undefined", () => {
expect(deriveSubagentModels(undefined)).toEqual({ reviewer: undefined });
});
it("returns no override when orchestrator slug isn't registered", () => {
expect(deriveSubagentModels("nonexistent/model")).toEqual({ reviewer: undefined });
});
describe("anthropic family — opus → sonnet", () => {
it("direct anthropic opus", () => {
expect(deriveSubagentModels("anthropic/claude-opus-4-7")).toEqual({
reviewer: "anthropic/claude-sonnet-4-6",
});
});
it("opencode-vendored opus stays on opencode prefix", () => {
expect(deriveSubagentModels("opencode/claude-opus-4-7")).toEqual({
reviewer: "opencode/claude-sonnet-4-6",
});
});
it("openrouter-anthropic-opus-via-anthropic-direct hits anthropic alias's openRouterResolve", () => {
// both the anthropic alias and the opencode alias have the same
// openRouterResolve. first-match-wins by alias declaration order
// (anthropic declared first in providers).
expect(deriveSubagentModels("openrouter/anthropic/claude-opus-4.7")).toEqual({
reviewer: "openrouter/anthropic/claude-sonnet-4.6",
});
});
it("sonnet has no further downshift", () => {
expect(deriveSubagentModels("anthropic/claude-sonnet-4-6")).toEqual({ reviewer: undefined });
expect(deriveSubagentModels("opencode/claude-sonnet-4-6")).toEqual({ reviewer: undefined });
});
it("haiku has no downshift", () => {
expect(deriveSubagentModels("anthropic/claude-haiku-4-5")).toEqual({ reviewer: undefined });
});
});
describe("openai family", () => {
it("gpt-pro → gpt (direct)", () => {
expect(deriveSubagentModels("openai/gpt-5.5-pro")).toEqual({ reviewer: "openai/gpt-5.5" });
});
it("gpt → gpt-5.4 (direct)", () => {
expect(deriveSubagentModels("openai/gpt-5.5")).toEqual({ reviewer: "openai/gpt-5.4" });
});
it("gpt → gpt-5.4 (opencode-vendored)", () => {
expect(deriveSubagentModels("opencode/gpt-5.5")).toEqual({ reviewer: "opencode/gpt-5.4" });
});
it("gpt-pro → gpt (openrouter)", () => {
expect(deriveSubagentModels("openrouter/openai/gpt-5.5-pro")).toEqual({
reviewer: "openrouter/openai/gpt-5.5",
});
});
it("gpt → gpt-5.4 (openrouter)", () => {
expect(deriveSubagentModels("openrouter/openai/gpt-5.5")).toEqual({
reviewer: "openrouter/openai/gpt-5.4",
});
});
it("gpt-5.4 itself (the hidden subagent target) has no further downshift", () => {
expect(deriveSubagentModels("openai/gpt-5.4")).toEqual({ reviewer: undefined });
});
it("gpt-mini has no downshift", () => {
expect(deriveSubagentModels("openai/gpt-5.4-mini")).toEqual({ reviewer: undefined });
});
});
describe("google (gemini) — pro → flash", () => {
it("direct google", () => {
expect(deriveSubagentModels("google/gemini-3.1-pro-preview")).toEqual({
reviewer: "google/gemini-3-flash-preview",
});
});
it("opencode-vendored gemini-pro", () => {
expect(deriveSubagentModels("opencode/gemini-3.1-pro")).toEqual({
reviewer: "opencode/gemini-3-flash",
});
});
it("openrouter-google-gemini-pro", () => {
expect(deriveSubagentModels("openrouter/google/gemini-3.1-pro-preview")).toEqual({
reviewer: "openrouter/google/gemini-3-flash-preview",
});
});
it("flash has no downshift", () => {
expect(deriveSubagentModels("google/gemini-3-flash-preview")).toEqual({
reviewer: undefined,
});
});
});
describe("providers / models without a subagentModel — inherit", () => {
it("xai grok (already cheap flagship)", () => {
expect(deriveSubagentModels("xai/grok-4.3")).toEqual({ reviewer: undefined });
});
it("deepseek", () => {
expect(deriveSubagentModels("deepseek/deepseek-v4-pro")).toEqual({ reviewer: undefined });
});
it("moonshot kimi", () => {
expect(deriveSubagentModels("moonshotai/kimi-k2.6")).toEqual({ reviewer: undefined });
});
it("opencode big-pickle", () => {
expect(deriveSubagentModels("opencode/big-pickle")).toEqual({ reviewer: undefined });
});
it("legacy fallback aliases (gpt-codex, deepseek-reasoner)", () => {
expect(deriveSubagentModels("openai/gpt-5.3-codex")).toEqual({ reviewer: undefined });
expect(deriveSubagentModels("deepseek/deepseek-reasoner")).toEqual({ reviewer: undefined });
});
});
});
+40
View File
@@ -0,0 +1,40 @@
import { modelAliases } from "../models.ts";
/**
* Derive a cheaper subagent model override from the orchestrator's resolved
* model spec.
*
* This is a pure registry lookup: every alias in `action/models.ts` declares
* its own `subagentModel` (alias key in the same provider). At runtime we
* reverse-lookup the orchestrator's resolved slug to find the alias that
* produced it, follow the `subagentModel` pointer, and return the target
* alias's resolve / openRouterResolve depending on which route the
* orchestrator was using.
*
* Returns `{ reviewer: undefined }` when the orchestrator's alias has no
* `subagentModel` (e.g. it's already at a sufficiently cheap tier, or its
* provider doesn't have a clean cheaper-but-capable sibling). See models.ts
* for the wiring + per-provider rationale.
*/
export function deriveSubagentModels(orchestratorSpec: string | undefined): {
reviewer: string | undefined;
} {
if (!orchestratorSpec) return { reviewer: undefined };
// Reverse-lookup. The same resolve string appears in only one alias
// (within its provider), so first match wins. We track which field
// matched (resolve vs openRouterResolve) so we can pick the same field
// off the subagent target — keeping the orchestrator's route consistent.
for (const source of modelAliases) {
const matchedDirect = source.resolve === orchestratorSpec;
const matchedOR = source.openRouterResolve === orchestratorSpec;
if (!matchedDirect && !matchedOR) continue;
if (!source.subagentModel) return { reviewer: undefined };
const target = modelAliases.find((a) => a.slug === source.subagentModel);
if (!target) return { reviewer: undefined };
const reviewer = matchedOR ? target.openRouterResolve : target.resolve;
return { reviewer };
}
return { reviewer: undefined };
}
+40
View File
@@ -0,0 +1,40 @@
import { readFileSync } from "node:fs";
import { join } from "node:path";
import { describe, expect, it } from "vitest";
const claudeSource = readFileSync(join(__dirname, "claude.ts"), "utf-8");
const opencodeSource = readFileSync(join(__dirname, "opencode.ts"), "utf-8");
/**
* The Claude Code `--agents` JSON and OpenCode `agent` config block are the
* only places where per-subagent model overrides take effect. They're built
* by string-only helpers we don't export, so this test reads the source and
* asserts the literal model strings + agent names are wired in. A regression
* here means the next review run silently runs lenses on Opus instead of
* Sonnet.
*/
describe("subagent registration source asserts", () => {
describe("claude.ts buildAgentsJson", () => {
it("registers reviewfrog with sonnet model", () => {
expect(claudeSource).toMatch(
/\[REVIEWER_AGENT_NAME\]:\s*\{[^}]*model:\s*"claude-sonnet-4-6"/s
);
});
it("imports the reviewer name constant", () => {
expect(claudeSource).toMatch(/REVIEWER_AGENT_NAME/);
});
});
describe("opencode.ts buildReviewerAgentConfig", () => {
it("registers reviewfrog with mode: subagent", () => {
expect(opencodeSource).toMatch(/\[REVIEWER_AGENT_NAME\]:[^}]*mode:\s*"subagent"/s);
});
it("uses deriveSubagentModels for the reviewer model override", () => {
expect(opencodeSource).toMatch(/deriveSubagentModels\(/);
expect(opencodeSource).toMatch(/overrides\.reviewer/);
});
it("passes orchestrator model to buildReviewerAgentConfig", () => {
expect(opencodeSource).toMatch(/buildReviewerAgentConfig\(model\)/);
});
});
});
+9 -2
View File
@@ -22,9 +22,16 @@ type CliProvider = {
function buildProviders(): CliProvider[] { function buildProviders(): CliProvider[] {
return Object.entries(providers) return Object.entries(providers)
.filter(([key]) => key !== "opencode" && key !== "openrouter") .filter(([key]) => key !== "opencode" && key !== "openrouter" && key !== "bedrock")
.map(([key, config]: [string, ProviderConfig]) => { .map(([key, config]: [string, ProviderConfig]) => {
const aliases = modelAliases.filter((a) => a.provider === key && !a.fallback); // bedrock requires multi-secret setup (auth + region + model id) that
// doesn't fit the single-paste flow below — direct users to
// https://docs.pullfrog.com/bedrock instead. revisit once the init flow
// supports multi-value setup. `hidden` excludes internal-only subagent
// targets (e.g. openai/gpt-5.4) per #710.
const aliases = modelAliases.filter(
(a) => a.provider === key && !a.fallback && !a.routing && !a.hidden
);
const recommended = aliases.find((a) => a.preferred); const recommended = aliases.find((a) => a.preferred);
const sorted = [...aliases].sort((a, b) => { const sorted = [...aliases].sort((a, b) => {
if (a.preferred && !b.preferred) return -1; if (a.preferred && !b.preferred) return -1;
+30 -13
View File
@@ -17,7 +17,11 @@ import {
} from "./utils/activity.ts"; } from "./utils/activity.ts";
import { resolveAgent, resolveModel } from "./utils/agent.ts"; import { resolveAgent, resolveModel } from "./utils/agent.ts";
import { apiFetch } from "./utils/apiFetch.ts"; import { apiFetch } from "./utils/apiFetch.ts";
import { validateAgentApiKey } from "./utils/apiKeys.ts"; import {
formatApiKeyErrorSummary,
isApiKeyAuthError,
validateAgentApiKey,
} from "./utils/apiKeys.ts";
import { isLocalApiUrl } from "./utils/apiUrl.ts"; import { isLocalApiUrl } from "./utils/apiUrl.ts";
import { resolveBody } from "./utils/body.ts"; import { resolveBody } from "./utils/body.ts";
import { formatUsageSummary, log, writeSummary } from "./utils/cli.ts"; import { formatUsageSummary, log, writeSummary } from "./utils/cli.ts";
@@ -770,12 +774,10 @@ export async function main(): Promise<MainResult> {
current: runContext.repoSettings.learnings, current: runContext.repoSettings.learnings,
}); });
toolState.learningsFilePath = learningsPath; toolState.learningsFilePath = learningsPath;
try { // file on disk is the verbatim DB body, so the seed used for
toolState.learningsSeed = await readFile(learningsPath, "utf8"); // change-detection is just `current ?? ""` (trimmed). persistLearnings
} catch { // byte-compares against the trimmed read-back to skip no-op PATCHes.
// intentionally empty — learningsSeed stays undefined, persistLearnings toolState.learningsSeed = (runContext.repoSettings.learnings ?? "").trim();
// will treat seed as "" and persist any non-empty content
}
log.info( log.info(
`» learnings seeded at ${learningsPath} (existing=${runContext.repoSettings.learnings ? "yes" : "no"})` `» learnings seeded at ${learningsPath} (existing=${runContext.repoSettings.learnings ? "yes" : "no"})`
); );
@@ -839,6 +841,7 @@ export async function main(): Promise<MainResult> {
agentId, agentId,
outputSchema, outputSchema,
learningsFilePath: toolState.learningsFilePath ?? null, learningsFilePath: toolState.learningsFilePath ?? null,
learningsHeadings: runContext.repoSettings.learningsHeadings,
}); });
const logParts = [ const logParts = [
instructions.eventInstructions instructions.eventInstructions
@@ -1036,10 +1039,15 @@ export async function main(): Promise<MainResult> {
// the comment is still around to update; reportErrorToComment sets // the comment is still around to update; reportErrorToComment sets
// wasUpdated=true and the !result.success guard skips deletion. // wasUpdated=true and the !result.success guard skips deletion.
if (!result.success && toolContext && toolState.progressComment) { if (!result.success && toolContext && toolState.progressComment) {
await reportErrorToComment({ const rawError = result.error || "agent run failed";
toolState, const errorBody = isApiKeyAuthError(rawError)
error: result.error || "agent run failed", ? formatApiKeyErrorSummary({
}).catch((error) => { owner: runContext.repo.owner,
name: runContext.repo.name,
raw: rawError,
})
: rawError;
await reportErrorToComment({ toolState, error: errorBody }).catch((error) => {
log.debug(`failure error report failed: ${error}`); log.debug(`failure error report failed: ${error}`);
}); });
} }
@@ -1115,11 +1123,20 @@ export async function main(): Promise<MainResult> {
? new BillingError(errorMessage, { code: "router_keylimit_exhausted" }) ? new BillingError(errorMessage, { code: "router_keylimit_exhausted" })
: null; : null;
const apiKeyErrorSummary =
!billingError && isApiKeyAuthError(errorMessage)
? formatApiKeyErrorSummary({
owner: runContext.repo.owner,
name: runContext.repo.name,
raw: errorMessage,
})
: null;
// best-effort summary — write the error so it's visible in the Actions summary tab // best-effort summary — write the error so it's visible in the Actions summary tab
try { try {
const errorSummary = billingError const errorSummary = billingError
? formatBillingErrorSummary(billingError, runContext.repo.owner) ? formatBillingErrorSummary(billingError, runContext.repo.owner)
: `### ❌ Pullfrog failed\n\n\`\`\`\n${errorMessage}\n\`\`\``; : (apiKeyErrorSummary ?? `### ❌ Pullfrog failed\n\n\`\`\`\n${errorMessage}\n\`\`\``);
const usageSummary = formatUsageSummary(toolState.usageEntries); const usageSummary = formatUsageSummary(toolState.usageEntries);
const parts = [errorSummary, toolState.lastProgressBody, usageSummary].filter(Boolean); const parts = [errorSummary, toolState.lastProgressBody, usageSummary].filter(Boolean);
await writeSummary(parts.join("\n\n")); await writeSummary(parts.join("\n\n"));
@@ -1128,7 +1145,7 @@ export async function main(): Promise<MainResult> {
try { try {
const commentBody = billingError const commentBody = billingError
? formatBillingErrorSummary(billingError, runContext.repo.owner) ? formatBillingErrorSummary(billingError, runContext.repo.owner)
: errorMessage; : (apiKeyErrorSummary ?? errorMessage);
await reportErrorToComment({ toolState, error: commentBody }); await reportErrorToComment({ toolState, error: commentBody });
} catch { } catch {
// error reporting failed, but don't let it mask the original error // error reporting failed, but don't let it mask the original error
+4 -1
View File
@@ -593,7 +593,10 @@ export function CheckoutPrTool(ctx: ToolContext) {
name: "checkout_pr", name: "checkout_pr",
description: description:
"Checkout a pull request branch locally. This fetches the PR branch and sets up push configuration for fork PRs. " + "Checkout a pull request branch locally. This fetches the PR branch and sets up push configuration for fork PRs. " +
"Returns diffPath pointing to the formatted diff file.", "Returns diffPath pointing to the formatted diff file. " +
"Example: `checkout_pr({ pull_number: 1234 })`. " +
"Transient fetch timeouts are common — retry the same call up to a few times before treating the failure as terminal. " +
"If the error mentions `.git/shallow.lock: File exists` or `.git/index.lock: File exists`, that's a stale lock from a prior timed-out fetch — remove it via the shell tool (`rm -f .git/shallow.lock .git/index.lock`) and retry.",
parameters: CheckoutPr, parameters: CheckoutPr,
execute: execute(async ({ pull_number }) => { execute: execute(async ({ pull_number }) => {
const prResponse = await ctx.octokit.rest.pulls.get({ const prResponse = await ctx.octokit.rest.pulls.get({
+9 -3
View File
@@ -65,7 +65,9 @@ export function CreateCommentTool(ctx: ToolContext) {
return tool({ return tool({
name: "create_issue_comment", name: "create_issue_comment",
description: description:
"Create a comment on a GitHub issue or PR. For progress/plan updates on the current run use report_progress instead. Use type: 'Plan' for plan comments.", "Create a comment on a GitHub issue or PR. " +
'Example: `create_issue_comment({ issueNumber: 1234, body: "Thanks for the report." })`. ' +
"For progress/plan updates on the current run use report_progress instead. Use type: 'Plan' for plan comments.",
parameters: Comment, parameters: Comment,
execute: execute(async ({ issueNumber, body, type: commentType }) => { execute: execute(async ({ issueNumber, body, type: commentType }) => {
const bodyWithFooter = addFooter(ctx, body); const bodyWithFooter = addFooter(ctx, body);
@@ -310,7 +312,9 @@ export function ReportProgressTool(ctx: ToolContext) {
return tool({ return tool({
name: "report_progress", name: "report_progress",
description: description:
"Share progress on the associated GitHub issue/PR. The first call creates a comment; subsequent calls update it in place. Call this at the end of every run with a brief final summary (1-3 sentences) unless the mode guidance instructs otherwise. The current task list is automatically appended in a collapsible section — do not restate individual steps.", "Share progress on the associated GitHub issue/PR. The first call creates a comment; subsequent calls update it in place. " +
'Example: `report_progress({ body: "Implemented the auth check and added tests." })`. ' +
"Call this at the end of every run with a brief final summary (1-3 sentences) unless the mode guidance instructs otherwise. The current task list is automatically appended in a collapsible section — do not restate individual steps.",
parameters: ReportProgress, parameters: ReportProgress,
execute: execute(async (params) => { execute: execute(async (params) => {
let body = params.body; let body = params.body;
@@ -445,7 +449,9 @@ export function ReplyToReviewCommentTool(ctx: ToolContext) {
return tool({ return tool({
name: "reply_to_review_comment", name: "reply_to_review_comment",
description: description:
"Reply to a PR review comment thread (NOT issue comments — this only works for inline review comments on PR diffs). Call exactly ONCE per parent comment you address in AddressReviews mode — duplicate calls with the same body are a no-op. Keep replies extremely brief (1 sentence max).", "Reply to a PR review comment thread (NOT issue comments — this only works for inline review comments on PR diffs). " +
'Example: `reply_to_review_comment({ pull_number: 1234, comment_id: 567890, body: "Fixed by adding a null check." })`. ' +
"Call exactly ONCE per parent comment you address in AddressReviews mode — duplicate calls with the same body are a no-op. Keep replies extremely brief (1 sentence max).",
parameters: ReplyToReviewComment, parameters: ReplyToReviewComment,
execute: execute(async ({ pull_number, comment_id, body }) => { execute: execute(async ({ pull_number, comment_id, body }) => {
const bodyWithFooter = addFooter(ctx, body); const bodyWithFooter = addFooter(ctx, body);
+2 -1
View File
@@ -15,7 +15,8 @@ export function CommitInfoTool(ctx: ToolContext) {
name: "get_commit_info", name: "get_commit_info",
description: description:
"Retrieve commit metadata and diff via GitHub API. Use this instead of git show for reviewing commits - " + "Retrieve commit metadata and diff via GitHub API. Use this instead of git show for reviewing commits - " +
"it works with shallow clones and shows the actual changes in the commit. Returns diffPath pointing to formatted diff file.", "it works with shallow clones and shows the actual changes in the commit. Returns diffPath pointing to formatted diff file. " +
'Example: `get_commit_info({ sha: "2a6ab5d" })`.',
parameters: CommitInfo, parameters: CommitInfo,
execute: execute(async ({ sha }) => { execute: execute(async ({ sha }) => {
const response = await ctx.octokit.rest.repos.getCommit({ const response = await ctx.octokit.rest.repos.getCommit({
+10 -3
View File
@@ -218,10 +218,12 @@ export function PushBranchTool(ctx: ToolContext) {
name: "push_branch", name: "push_branch",
description: description:
"Push the current branch to the remote repository. Omit branchName to push the current branch (recommended). " + "Push the current branch to the remote repository. Omit branchName to push the current branch (recommended). " +
'Example: `push_branch({})` to push the current branch. Example: `push_branch({ branchName: "pr-1" })` to push a specific local branch. ' +
"If specifying branchName, use the LOCAL branch name (e.g., 'pr-1'), not the remote branch name. " + "If specifying branchName, use the LOCAL branch name (e.g., 'pr-1'), not the remote branch name. " +
"The correct remote and remote branch are determined automatically from branch config set by checkout_pr. " + "The correct remote and remote branch are determined automatically from branch config set by checkout_pr. " +
"Requires a clean working tree. Runs the repository prepush hook (if configured) before the network push — hook failure means tests/lint or similar in that script failed, not necessarily a Pullfrog timeout. " + "Requires a clean working tree. Runs the repository prepush hook (if configured) before the network push — hook failure means tests/lint or similar in that script failed, not necessarily a Pullfrog timeout. " +
"Never force push unless explicitly requested. Pushes to the default branch are blocked in restricted mode.", "Never force push unless explicitly requested. Pushes to the default branch are blocked in restricted mode. " +
"If the response reports a timeout, the underlying push may have actually succeeded — verify with `git log origin/<branch>` (or this tool with command 'log') before retrying, otherwise you'll push a duplicate.",
parameters: PushBranch, parameters: PushBranch,
execute: execute(async ({ branchName, force }) => { execute: execute(async ({ branchName, force }) => {
// permission check // permission check
@@ -451,7 +453,10 @@ export function GitTool(ctx: ToolContext) {
return tool({ return tool({
name: "git", name: "git",
description: description:
"Run git commands. For push/fetch, use the dedicated MCP tools (push_branch, git_fetch). " + "Run a git subcommand. `command` is a single subcommand; flags and positional args go in `args`. " +
'Example: `git({ command: "log", args: ["--oneline", "-n", "20"] })`. ' +
'Example: `git({ command: "diff", args: ["origin/main..HEAD"] })`. ' +
"For push/fetch, use the dedicated MCP tools (push_branch, git_fetch). " +
"git pull is not available — use git_fetch then this tool with command 'merge'.", "git pull is not available — use git_fetch then this tool with command 'merge'.",
parameters: Git, parameters: Git,
execute: execute(async (params) => { execute: execute(async (params) => {
@@ -523,7 +528,9 @@ const DEEPEN_RETRY_DEPTH = 1000;
export function GitFetchTool(ctx: ToolContext) { export function GitFetchTool(ctx: ToolContext) {
return tool({ return tool({
name: "git_fetch", name: "git_fetch",
description: "Fetch refs from remote repository. Use this instead of git fetch directly.", description:
"Fetch refs from remote repository. Use this instead of git fetch directly. " +
'Example: `git_fetch({ ref: "main" })`. With depth: `git_fetch({ ref: "pull/1234/head", depth: 1 })`.',
parameters: GitFetch, parameters: GitFetch,
execute: execute(async (params) => { execute: execute(async (params) => {
rejectIfLeadingDash(params.ref, "ref"); rejectIfLeadingDash(params.ref, "ref");
+2 -1
View File
@@ -10,7 +10,8 @@ export function GetIssueCommentsTool(ctx: ToolContext) {
return tool({ return tool({
name: "get_issue_comments", name: "get_issue_comments",
description: description:
"Get all comments for a GitHub issue. Returns all comments including the issue body and all subsequent discussion comments.", "Get all comments for a GitHub issue. Returns all comments including the issue body and all subsequent discussion comments. " +
"Example: `get_issue_comments({ issue_number: 1234 })`.",
parameters: GetIssueComments, parameters: GetIssueComments,
execute: execute(async ({ issue_number }) => { execute: execute(async ({ issue_number }) => {
// set issue context // set issue context
+3 -1
View File
@@ -9,7 +9,9 @@ export const IssueInfo = type({
export function IssueInfoTool(ctx: ToolContext) { export function IssueInfoTool(ctx: ToolContext) {
return tool({ return tool({
name: "get_issue", name: "get_issue",
description: "Retrieve GitHub issue information by issue number", description:
"Retrieve GitHub issue information by issue number. " +
"Example: `get_issue({ issue_number: 1234 })`.",
parameters: IssueInfo, parameters: IssueInfo,
execute: execute(async ({ issue_number }) => { execute: execute(async ({ issue_number }) => {
const issue = await ctx.octokit.rest.issues.get({ const issue = await ctx.octokit.rest.issues.get({
+3 -1
View File
@@ -30,7 +30,9 @@ export function PullRequestInfoTool(ctx: ToolContext) {
return tool({ return tool({
name: "get_pull_request", name: "get_pull_request",
description: description:
"Retrieve PR metadata (title, body, state, branches, author, labels, linked issues). To checkout a PR branch locally, use checkout_pr instead.", "Retrieve PR metadata (title, body, state, branches, author, labels, linked issues). " +
"Example: `get_pull_request({ pull_number: 1234 })`. " +
"To checkout a PR branch locally, use checkout_pr instead.",
parameters: PullRequestInfo, parameters: PullRequestInfo,
execute: execute(async ({ pull_number }) => { execute: execute(async ({ pull_number }) => {
// fetch REST and GraphQL in parallel // fetch REST and GraphQL in parallel
+9 -4
View File
@@ -320,14 +320,16 @@ export const CreatePullRequestReview = type({
) )
.optional(), .optional(),
commit_id: type.string commit_id: type.string
.describe("Optional SHA of the commit being reviewed. Defaults to latest.") .describe(
"Optional SHA of the commit being reviewed. Defaults to latest. Must be the FULL 40-character SHA — abbreviated SHAs are rejected by GitHub with `422 Unprocessable Entity`. The PR-synchronize event payload's `head_sha` is already full-length."
)
.optional(), .optional(),
comments: type({ comments: type({
path: type.string.describe( path: type.string.describe(
"The file path to comment on (relative to repo root). Must be a file that appears in the PR diff." "The file path to comment on (relative to repo root). Must be a file that appears in the PR diff."
), ),
line: type.number.describe( line: type.number.describe(
"Line number to comment on. For multi-line ranges, this is the end line. Use NEW column from diff format." "Line number to comment on. For multi-line ranges, this is the end line. Use NEW column from diff format. Must sit inside a `@@` hunk in the PR diff — anchors on context-only or untouched lines are dropped silently (the rest of the review still posts; dropped entries are reported under `droppedComments` in the response)."
), ),
side: type side: type
.enumerated("LEFT", "RIGHT") .enumerated("LEFT", "RIGHT")
@@ -345,7 +347,7 @@ export const CreatePullRequestReview = type({
.optional(), .optional(),
start_line: type.number start_line: type.number
.describe( .describe(
"Start line for multi-line comment ranges. Omit for single-line comments. The range [start_line, line] defines which lines a suggestion replaces." "Start line for multi-line comment ranges. Omit for single-line comments. The range [start_line, line] defines which lines a suggestion replaces. Both `start_line` and `line` must sit inside the same `@@` hunk — a `start_line` outside the hunk causes the whole comment to be dropped even when `line` is valid. If you need to comment on context just above/below a hunk, shrink the range to a single line that is provably modified."
) )
.optional(), .optional(),
}) })
@@ -361,6 +363,7 @@ export function CreatePullRequestReviewTool(ctx: ToolContext) {
name: "create_pull_request_review", name: "create_pull_request_review",
description: description:
"Submit a review for an existing pull request. " + "Submit a review for an existing pull request. " +
'Example: `create_pull_request_review({ pull_number: 1234, body: "LGTM", approved: true, comments: [{ path: "src/api.ts", line: 42, body: "nit: rename" }] })`. ' +
"Each call creates a permanent, visible review on the PR — NEVER submit test or diagnostic reviews. " + "Each call creates a permanent, visible review on the PR — NEVER submit test or diagnostic reviews. " +
"Reviews with no body AND no comments are silently skipped (nothing to post). " + "Reviews with no body AND no comments are silently skipped (nothing to post). " +
"IMPORTANT: 95%+ of feedback should be in 'comments' array with file paths and line numbers. " + "IMPORTANT: 95%+ of feedback should be in 'comments' array with file paths and line numbers. " +
@@ -709,7 +712,9 @@ function runDiffCoveragePreflight(params: { ctx: ToolContext }): void {
.join("\n"); .join("\n");
throw new Error( throw new Error(
`diff coverage pre-flight: some TOC regions were not read before review submission. ` + `diff coverage pre-flight: some TOC regions were not read before review submission. ` +
`this is a one-time nudge — optionally read the ranges below from ${coverageState.diffPath}, then call create_pull_request_review again with the same arguments. ` + `this is a one-time nudge — read the ranges below from ${coverageState.diffPath} on a best-effort basis, then call create_pull_request_review again. ` +
`you are NOT obligated to read generated artifacts (lockfiles like pnpm-lock.yaml / package-lock.json / yarn.lock / Cargo.lock; codegen output like *.gen.*, *.pb.go, *.generated.*; snapshot/fixture dirs like __snapshots__/; migration metadata like drizzle/meta/, prisma migration SQL). ` +
`if every unread region is generated, retry immediately without reading. ` +
`this pre-flight will not block again in this review session.\n\n` + `this pre-flight will not block again in this review session.\n\n` +
`unread TOC regions:\n${unreadText}\n\n` + `unread TOC regions:\n${unreadText}\n\n` +
`${coverageState.lastBreakdown}` `${coverageState.lastBreakdown}`
+3 -1
View File
@@ -602,6 +602,7 @@ export function GetReviewCommentsTool(ctx: ToolContext) {
name: "get_review_comments", name: "get_review_comments",
description: description:
"Get review comments for a pull request review with full thread context. " + "Get review comments for a pull request review with full thread context. " +
"Example: `get_review_comments({ pull_number: 1234, review_id: 567890 })`. " +
"Automatically filters to approved comments when applicable. " + "Automatically filters to approved comments when applicable. " +
"Returns a TOC and commentsPath pointing to a markdown file with full comment details.", "Returns a TOC and commentsPath pointing to a markdown file with full comment details.",
parameters: GetReviewComments, parameters: GetReviewComments,
@@ -673,7 +674,8 @@ export function ListPullRequestReviewsTool(ctx: ToolContext) {
return tool({ return tool({
name: "list_pull_request_reviews", name: "list_pull_request_reviews",
description: description:
"List all reviews for a pull request. Returns all reviews including approvals, request changes, and comments.", "List all reviews for a pull request. Returns all reviews including approvals, request changes, and comments. " +
"Example: `list_pull_request_reviews({ pull_number: 1234 })`.",
parameters: ListPullRequestReviews, parameters: ListPullRequestReviews,
execute: execute(async (params) => { execute: execute(async (params) => {
const reviews = await ctx.octokit.paginate(ctx.octokit.rest.pulls.listReviews, { const reviews = await ctx.octokit.paginate(ctx.octokit.rest.pulls.listReviews, {
+2 -1
View File
@@ -121,7 +121,8 @@ export function SelectModeTool(ctx: ToolContext) {
return tool({ return tool({
name: "select_mode", name: "select_mode",
description: description:
"Select a mode and receive step-by-step guidance on how to handle the task. Call this to understand the best workflow for the current mode.", "Select a mode and receive step-by-step guidance on how to handle the task. Call this to understand the best workflow for the current mode. " +
'Example: `select_mode({ mode: "Review" })` or `select_mode({ mode: "Plan", issue_number: 1234 })`.',
parameters: SelectModeParams, parameters: SelectModeParams,
execute: execute(async (params) => { execute: execute(async (params) => {
if (ctx.toolState.selectedMode) { if (ctx.toolState.selectedMode) {
+5 -1
View File
@@ -15,7 +15,9 @@ import { execute, tool } from "./shared.ts";
export const ShellParams = type({ export const ShellParams = type({
command: "string", command: "string",
description: "string", description: "string",
"timeout?": "number", "timeout?": type.number.describe(
"Timeout in MILLISECONDS (not seconds). Default 30000 (30s), max 120000 (2m). e.g. timeout: 180000 for 3 minutes; timeout: 180 means 180ms and will kill the process almost immediately."
),
"working_directory?": "string", "working_directory?": "string",
"background?": "boolean", "background?": "boolean",
}); });
@@ -187,6 +189,8 @@ export function ShellTool(ctx: ToolContext) {
name: "shell", name: "shell",
description: `Execute shell commands securely. Environment is filtered to remove API keys and secrets. description: `Execute shell commands securely. Environment is filtered to remove API keys and secrets.
Example: \`shell({ command: "pnpm test", description: "run the test suite" })\`.
Use this tool to: Use this tool to:
- Run shell commands (ls, cat, grep, find, etc.) - Run shell commands (ls, cat, grep, find, etc.)
- Execute build tools (npm, pnpm, cargo, make, etc.) - Execute build tools (npm, pnpm, cargo, make, etc.)
+59 -1
View File
@@ -2,6 +2,7 @@ import { describe, expect, it } from "vitest";
import { import {
getModelEnvVars, getModelEnvVars,
getModelProvider, getModelProvider,
isBedrockAnthropicId,
modelAliases, modelAliases,
parseModel, parseModel,
providers, providers,
@@ -175,7 +176,12 @@ describe("modelAliases registry", () => {
it("has exactly one preferred model per provider", () => { it("has exactly one preferred model per provider", () => {
for (const providerKey of Object.keys(providers)) { for (const providerKey of Object.keys(providers)) {
const preferred = modelAliases.filter((a) => a.provider === providerKey && a.preferred); // routing-only providers (bedrock) deliberately have no preferred
// model — the user picks the actual model via a per-run env var, so
// there's no "preferred default" to surface to auto-select.
const aliases = modelAliases.filter((a) => a.provider === providerKey);
if (aliases.every((a) => a.routing)) continue;
const preferred = aliases.filter((a) => a.preferred);
expect(preferred.length, `${providerKey} should have exactly 1 preferred model`).toBe(1); expect(preferred.length, `${providerKey} should have exactly 1 preferred model`).toBe(1);
} }
}); });
@@ -190,6 +196,10 @@ describe("modelAliases registry", () => {
it("all resolve values follow provider/model format", () => { it("all resolve values follow provider/model format", () => {
for (const alias of modelAliases) { for (const alias of modelAliases) {
// routing slugs use a sentinel `resolve` (e.g. "bedrock") that's never
// passed to a CLI directly — the harness reads a separate env var to
// get the real model ID. format check doesn't apply.
if (alias.routing) continue;
expect(alias.resolve).toContain("/"); expect(alias.resolve).toContain("/");
} }
}); });
@@ -200,6 +210,54 @@ describe("modelAliases registry", () => {
}); });
}); });
describe("isBedrockAnthropicId", () => {
it("matches geo-prefixed Anthropic foundation IDs", () => {
expect(isBedrockAnthropicId("us.anthropic.claude-opus-4-7")).toBe(true);
expect(isBedrockAnthropicId("eu.anthropic.claude-sonnet-4-6")).toBe(true);
expect(isBedrockAnthropicId("global.anthropic.claude-haiku-4-5-20251001-v1:0")).toBe(true);
});
it("matches in-region Anthropic foundation IDs", () => {
expect(isBedrockAnthropicId("anthropic.claude-opus-4-7")).toBe(true);
});
it("rejects non-Anthropic foundation IDs", () => {
expect(isBedrockAnthropicId("amazon.nova-pro-v1:0")).toBe(false);
expect(isBedrockAnthropicId("us.meta.llama4-scout-17b-instruct-v1:0")).toBe(false);
expect(isBedrockAnthropicId("deepseek.v3.2")).toBe(false);
});
// regression: PR #720 review caught that a substring-only match was
// fragile for inference-profile ARNs (which BEDROCK_MODEL_ID accepts per
// the AWS docs). ARN names are user-chosen — both directions of the
// heuristic could break depending on what name the operator picked.
// We anchor on a discrete dot-segment match (case-insensitive) instead.
it("ignores 'anthropic' substrings inside non-segment text", () => {
// ARN whose user-chosen profile name happens to contain "anthropic" as
// part of a longer word — would route to claude-code under naive
// includes("anthropic") even though the backing model is unknown.
expect(
isBedrockAnthropicId(
"arn:aws:bedrock:us-east-2:123456789012:application-inference-profile/my-anthropicish-profile"
)
).toBe(false);
});
it("matches when 'anthropic' appears as its own dot-segment in ARN", () => {
// ARN whose profile name embeds the foundation segment correctly —
// operator chose to surface the backing model in the name.
expect(
isBedrockAnthropicId(
"arn:aws:bedrock:us-east-2:123456789012:application-inference-profile/anthropic.claude-opus-4-7"
)
).toBe(true);
});
it("is case-insensitive", () => {
expect(isBedrockAnthropicId("US.ANTHROPIC.CLAUDE-OPUS-4-7")).toBe(true);
});
});
describe("providers registry", () => { describe("providers registry", () => {
it("every provider has envVars", () => { it("every provider has envVars", () => {
for (const [key, config] of Object.entries(providers)) { for (const [key, config] of Object.entries(providers)) {
+127 -3
View File
@@ -7,6 +7,22 @@
// ── types ────────────────────────────────────────────────────────────────────── // ── types ──────────────────────────────────────────────────────────────────────
/**
* routing discriminant for entries whose `resolve` is dynamic looked up
* from a separate env var at run time rather than fixed in the catalog.
*
* `"bedrock"` means the actual model ID comes from `BEDROCK_MODEL_ID`
* (an AWS-canonical Bedrock model ID like `us.anthropic.claude-opus-4-7`
* or `amazon.nova-pro-v1:0`). enterprise Bedrock customers self-select for
* version control silent alias bumps would break compliance review,
* model-access enrollment, and provisioned-throughput contracts. so the
* single `bedrock/byok` entry is a routing slug, not a model alias: the
* harness reads `BEDROCK_MODEL_ID` and routes to claude-code (when the ID
* contains "anthropic") or opencode (everything else, with an
* `amazon-bedrock/` prefix).
*/
export type ModelRouting = "bedrock";
export interface ModelAlias { export interface ModelAlias {
/** stable alias stored in DB, e.g. "anthropic/claude-opus" */ /** stable alias stored in DB, e.g. "anthropic/claude-opus" */
slug: string; slug: string;
@@ -14,9 +30,9 @@ export interface ModelAlias {
provider: string; provider: string;
/** human-readable name shown in dropdowns */ /** human-readable name shown in dropdowns */
displayName: string; displayName: string;
/** concrete models.dev specifier, e.g. "anthropic/claude-opus-4-6" */ /** concrete models.dev specifier, e.g. "anthropic/claude-opus-4-6". sentinel for routing entries — never passed to a CLI directly. */
resolve: string; resolve: string;
/** full models.dev specifier for the OpenRouter equivalent (undefined for free models) */ /** full models.dev specifier for the OpenRouter equivalent (undefined for free models and routing entries) */
openRouterResolve: string | undefined; openRouterResolve: string | undefined;
/** top-tier pick for this provider — preferred during auto-select */ /** top-tier pick for this provider — preferred during auto-select */
preferred: boolean; preferred: boolean;
@@ -24,6 +40,15 @@ export interface ModelAlias {
isFree: boolean; isFree: boolean;
/** slug of a replacement model — presence implies this model is deprecated */ /** slug of a replacement model — presence implies this model is deprecated */
fallback: string | undefined; fallback: string | undefined;
/** dynamic-resolution discriminant — see ModelRouting docs */
routing: ModelRouting | undefined;
/** alias key (within same provider) of the cheaper sibling reviewfrog should
* use as its lens-fanout subagent. e.g. claude-opus "claude-sonnet". */
subagentModel: string | undefined;
/** hide from selectable lists (UI dropdowns, CLI pickers). does NOT affect
* resolution for that use `fallback`. used for internal-only tier targets
* (e.g. gpt-5.4 as a subagent target without exposing it to users). */
hidden: boolean;
} }
interface ModelDef { interface ModelDef {
@@ -37,6 +62,13 @@ interface ModelDef {
isFree?: boolean; isFree?: boolean;
/** slug of a replacement model — presence implies this model is deprecated */ /** slug of a replacement model — presence implies this model is deprecated */
fallback?: string; fallback?: string;
/** dynamic-resolution discriminant — see ModelRouting docs */
routing?: ModelRouting;
/** alias key (within same provider) of the cheaper sibling reviewfrog should
* use as its lens-fanout subagent (e.g. claude-opus "claude-sonnet"). */
subagentModel?: string;
/** hide from selectable lists. does NOT affect resolution; for that use `fallback`. */
hidden?: boolean;
} }
export interface ProviderConfig { export interface ProviderConfig {
@@ -61,6 +93,7 @@ export const providers = {
resolve: "anthropic/claude-opus-4-7", resolve: "anthropic/claude-opus-4-7",
openRouterResolve: "openrouter/anthropic/claude-opus-4.7", openRouterResolve: "openrouter/anthropic/claude-opus-4.7",
preferred: true, preferred: true,
subagentModel: "claude-sonnet",
}, },
"claude-sonnet": { "claude-sonnet": {
displayName: "Claude Sonnet", displayName: "Claude Sonnet",
@@ -83,11 +116,22 @@ export const providers = {
resolve: "openai/gpt-5.5", resolve: "openai/gpt-5.5",
openRouterResolve: "openrouter/openai/gpt-5.5", openRouterResolve: "openrouter/openai/gpt-5.5",
preferred: true, preferred: true,
subagentModel: "gpt-5.4",
}, },
"gpt-pro": { "gpt-pro": {
displayName: "GPT Pro", displayName: "GPT Pro",
resolve: "openai/gpt-5.5-pro", resolve: "openai/gpt-5.5-pro",
openRouterResolve: "openrouter/openai/gpt-5.5-pro", openRouterResolve: "openrouter/openai/gpt-5.5-pro",
subagentModel: "gpt",
},
// hidden subagent target — `gpt` lenses run against this. surfacing
// it in the picker would just confuse users (it's the prior-flagship,
// and they already have `gpt` and `gpt-mini` to choose from).
"gpt-5.4": {
displayName: "GPT 5.4",
resolve: "openai/gpt-5.4",
openRouterResolve: "openrouter/openai/gpt-5.4",
hidden: true,
}, },
"gpt-mini": { "gpt-mini": {
displayName: "GPT Mini", displayName: "GPT Mini",
@@ -126,6 +170,7 @@ export const providers = {
resolve: "google/gemini-3.1-pro-preview", resolve: "google/gemini-3.1-pro-preview",
openRouterResolve: "openrouter/google/gemini-3.1-pro-preview", openRouterResolve: "openrouter/google/gemini-3.1-pro-preview",
preferred: true, preferred: true,
subagentModel: "gemini-flash",
}, },
"gemini-flash": { "gemini-flash": {
displayName: "Gemini Flash", displayName: "Gemini Flash",
@@ -214,6 +259,7 @@ export const providers = {
displayName: "Claude Opus", displayName: "Claude Opus",
resolve: "opencode/claude-opus-4-7", resolve: "opencode/claude-opus-4-7",
openRouterResolve: "openrouter/anthropic/claude-opus-4.7", openRouterResolve: "openrouter/anthropic/claude-opus-4.7",
subagentModel: "claude-sonnet",
}, },
"claude-sonnet": { "claude-sonnet": {
displayName: "Claude Sonnet", displayName: "Claude Sonnet",
@@ -229,11 +275,20 @@ export const providers = {
displayName: "GPT", displayName: "GPT",
resolve: "opencode/gpt-5.5", resolve: "opencode/gpt-5.5",
openRouterResolve: "openrouter/openai/gpt-5.5", openRouterResolve: "openrouter/openai/gpt-5.5",
subagentModel: "gpt-5.4",
}, },
"gpt-pro": { "gpt-pro": {
displayName: "GPT Pro", displayName: "GPT Pro",
resolve: "opencode/gpt-5.5-pro", resolve: "opencode/gpt-5.5-pro",
openRouterResolve: "openrouter/openai/gpt-5.5-pro", openRouterResolve: "openrouter/openai/gpt-5.5-pro",
subagentModel: "gpt",
},
// hidden subagent target — see openai provider above for context.
"gpt-5.4": {
displayName: "GPT 5.4",
resolve: "opencode/gpt-5.4",
openRouterResolve: "openrouter/openai/gpt-5.4",
hidden: true,
}, },
"gpt-mini": { "gpt-mini": {
displayName: "GPT Mini", displayName: "GPT Mini",
@@ -257,6 +312,7 @@ export const providers = {
displayName: "Gemini Pro", displayName: "Gemini Pro",
resolve: "opencode/gemini-3.1-pro", resolve: "opencode/gemini-3.1-pro",
openRouterResolve: "openrouter/google/gemini-3.1-pro-preview", openRouterResolve: "openrouter/google/gemini-3.1-pro-preview",
subagentModel: "gemini-flash",
}, },
"gemini-flash": { "gemini-flash": {
displayName: "Gemini Flash", displayName: "Gemini Flash",
@@ -288,6 +344,20 @@ export const providers = {
}, },
}, },
}), }),
bedrock: provider({
displayName: "Amazon Bedrock",
envVars: ["AWS_BEARER_TOKEN_BEDROCK", "AWS_REGION", "BEDROCK_MODEL_ID"],
models: {
// single routing entry — the actual Bedrock model ID is read from
// BEDROCK_MODEL_ID at run time. see ModelRouting docs for why we
// don't catalog individual Bedrock models.
byok: {
displayName: "Amazon Bedrock",
resolve: "bedrock",
routing: "bedrock",
},
},
}),
openrouter: provider({ openrouter: provider({
displayName: "OpenRouter", displayName: "OpenRouter",
envVars: ["OPENROUTER_API_KEY"], envVars: ["OPENROUTER_API_KEY"],
@@ -297,6 +367,7 @@ export const providers = {
resolve: "openrouter/anthropic/claude-opus-4.7", resolve: "openrouter/anthropic/claude-opus-4.7",
openRouterResolve: "openrouter/anthropic/claude-opus-4.7", openRouterResolve: "openrouter/anthropic/claude-opus-4.7",
preferred: true, preferred: true,
subagentModel: "claude-sonnet",
}, },
"claude-sonnet": { "claude-sonnet": {
displayName: "Claude Sonnet", displayName: "Claude Sonnet",
@@ -312,11 +383,20 @@ export const providers = {
displayName: "GPT", displayName: "GPT",
resolve: "openrouter/openai/gpt-5.5", resolve: "openrouter/openai/gpt-5.5",
openRouterResolve: "openrouter/openai/gpt-5.5", openRouterResolve: "openrouter/openai/gpt-5.5",
subagentModel: "gpt-5.4",
}, },
"gpt-pro": { "gpt-pro": {
displayName: "GPT Pro", displayName: "GPT Pro",
resolve: "openrouter/openai/gpt-5.5-pro", resolve: "openrouter/openai/gpt-5.5-pro",
openRouterResolve: "openrouter/openai/gpt-5.5-pro", openRouterResolve: "openrouter/openai/gpt-5.5-pro",
subagentModel: "gpt",
},
// hidden subagent target — see openai provider above for context.
"gpt-5.4": {
displayName: "GPT 5.4",
resolve: "openrouter/openai/gpt-5.4",
openRouterResolve: "openrouter/openai/gpt-5.4",
hidden: true,
}, },
"gpt-mini": { "gpt-mini": {
displayName: "GPT Mini", displayName: "GPT Mini",
@@ -345,6 +425,7 @@ export const providers = {
displayName: "Gemini Pro", displayName: "Gemini Pro",
resolve: "openrouter/google/gemini-3.1-pro-preview", resolve: "openrouter/google/gemini-3.1-pro-preview",
openRouterResolve: "openrouter/google/gemini-3.1-pro-preview", openRouterResolve: "openrouter/google/gemini-3.1-pro-preview",
subagentModel: "gemini-flash",
}, },
"gemini-flash": { "gemini-flash": {
displayName: "Gemini Flash", displayName: "Gemini Flash",
@@ -432,6 +513,12 @@ export const modelAliases: ModelAlias[] = Object.entries(providers).flatMap(
preferred: def.preferred ?? false, preferred: def.preferred ?? false,
isFree: def.isFree ?? false, isFree: def.isFree ?? false,
fallback: def.fallback, fallback: def.fallback,
routing: def.routing,
// subagentModel is stored as an alias key local to the provider; expand
// here to a fully-qualified slug so callers can look up the target alias
// directly without re-deriving the provider.
subagentModel: def.subagentModel ? `${providerKey}/${def.subagentModel}` : undefined,
hidden: def.hidden ?? false,
})) }))
); );
@@ -451,7 +538,7 @@ const MAX_FALLBACK_DEPTH = 10;
* use this in UI display sites (dropdown trigger labels, PR-comment footers, * use this in UI display sites (dropdown trigger labels, PR-comment footers,
* etc.) so a deprecated stored slug renders as the model the user actually * etc.) so a deprecated stored slug renders as the model the user actually
* runs against not the historical name. selectable lists should still hide * runs against not the historical name. selectable lists should still hide
* deprecated aliases by filtering on `!a.fallback`. * deprecated and internal-only aliases by filtering on `!a.fallback && !a.hidden`.
*/ */
export function resolveDisplayAlias(slug: string): ModelAlias | undefined { export function resolveDisplayAlias(slug: string): ModelAlias | undefined {
let current = slug; let current = slug;
@@ -485,3 +572,40 @@ export function resolveCliModel(slug: string): string | undefined {
export function resolveOpenRouterModel(slug: string): string | undefined { export function resolveOpenRouterModel(slug: string): string | undefined {
return resolveDisplayAlias(slug)?.openRouterResolve; return resolveDisplayAlias(slug)?.openRouterResolve;
} }
// ── bedrock routing ────────────────────────────────────────────────────────────
/** env var that supplies the Bedrock model ID for the `bedrock/byok` slug. */
export const BEDROCK_MODEL_ID_ENV = "BEDROCK_MODEL_ID";
/**
* the Bedrock model ID passed to claude-code or opencode is whatever the
* user set in `BEDROCK_MODEL_ID` Pullfrog never resolves or upgrades it.
* we route by checking whether the ID names an Anthropic model: claude-code
* handles Anthropic-on-Bedrock natively (with `CLAUDE_CODE_USE_BEDROCK=1`),
* everything else goes through opencode's `amazon-bedrock` provider.
*
* AWS Bedrock IDs come in two shapes:
* - dotted foundation IDs: `us.anthropic.claude-opus-4-7`,
* `anthropic.claude-haiku-4-5-20251001-v1:0`, `amazon.nova-pro-v1:0`,
* `meta.llama4-scout-17b-instruct-v1:0`. AWS-published, lowercase, the
* foundation provider always appears as a discrete dot-segment.
* - inference-profile ARNs: `arn:aws:bedrock:us-east-2:<acct>:application-inference-profile/<user-name>`.
* `<user-name>` is operator-chosen, so a naive substring check is fragile
* in both directions (Anthropic profile named without "anthropic" routes
* to opencode and misses CLAUDE_CODE_USE_BEDROCK; non-Anthropic profile
* whose name happens to contain "anthropic" routes to claude-code).
*
* we anchor on a discrete dot-segment match (case-insensitive). this catches
* every published foundation ID and is conservative for ARN-form IDs: ARN
* names that don't include "anthropic" as their own dot-segment route to
* opencode by default. operators using ARN-form IDs whose backing model is
* Anthropic should set `PULLFROG_AGENT=claude` to force the right route, or
* include the foundation segment in the profile name.
*/
export function isBedrockAnthropicId(bedrockModelId: string): boolean {
// split on `.`, `/`, and `:` so the check works for both dotted foundation
// IDs (anthropic.* / us.anthropic.*) and ARN-form IDs (where the relevant
// foundation segment sits between `/` and `.` inside the resource name).
return bedrockModelId.toLowerCase().split(/[./:]/).includes("anthropic");
}
+82 -47
View File
@@ -155,18 +155,24 @@ For simple, well-defined tasks, skip the plan phase and go straight to build.`,
- resolve addressed threads via \`${t("resolve_review_thread")}\` - resolve addressed threads via \`${t("resolve_review_thread")}\`
- call \`${t("report_progress")}\` with a brief summary (or the exact push error if push failed)`, - call \`${t("report_progress")}\` with a brief summary (or the exact push error if push failed)`,
}, },
// Review and IncrementalReview use the multi-lens orchestrator pattern // Review and IncrementalReview use a 0-or-2+ lens pattern. The default is
// (canonical source: .claude/commands/anneal.md). The orchestrator does // 0 lenses (orchestrator handles the review solo). Multi-lens (2+
// triage → parallel read-only subagent fan-out → aggregate → draft comments // reviewfrog subagents in parallel) only fires for substantive PRs or
// → submit. For someone else's PR, parallel lenses (correctness, security, // high-stakes-subsystem touches — and when it fires, ALL lenses must
// research-validated claims, user-journey, etc.) provide breadth across // dispatch in a single assistant turn or the parallelism win disappears.
// angles that a single subagent can't carry coherently. Build mode keeps // We never dispatch exactly one lens: a single lens is just a worse,
// a single fresh-eyes subagent (different problem shape — orchestrator // slower version of doing the work yourself.
// wrote the code and bias-mitigation comes from delegating to one //
// subagent that doesn't share the implementation context). // Build mode self-review is a different problem shape: the orchestrator
// Deliberate omission vs canonical /anneal: severity categorization in the // wrote the code, so bias-mitigation comes from delegating to one
// final message (the review body has its own CAUTION/IMPORTANT framing // fresh-eyes subagent that doesn't share the implementation context. A
// instead of a severity table). // single subagent there is appropriate; the 0-or-2+ rule applies only to
// the Review/IncrementalReview lens fan-out where independence between
// perspectives is what's being purchased.
//
// Deliberate omission vs canonical /anneal: severity categorization in
// the final message (the review body has its own CAUTION/IMPORTANT
// framing instead of a severity table).
{ {
name: "Review", name: "Review",
description: description:
@@ -177,9 +183,9 @@ For simple, well-defined tasks, skip the plan phase and go straight to build.`,
2. **checkout**: call \`${t("checkout_pr")}\` — this returns PR metadata and a \`diffPath\`. read the diff TOC end-to-end and treat its file line ranges as your coverage checklist. 2. **checkout**: call \`${t("checkout_pr")}\` — this returns PR metadata and a \`diffPath\`. read the diff TOC end-to-end and treat its file line ranges as your coverage checklist.
3. **triage**: orient yourself on the PR identify *what kind of thing this is* (domain it touches, seams it crosses, external contracts it depends on, user-facing surfaces it changes). orientation only defer specific defect-hunting to the subagents; pre-reviewing biases the lenses you pick. use \`${t("get_pull_request")}\` and other read-only GitHub tools for additional context if needed. 3. **triage**: orient yourself on the PR identify *what kind of thing this is* (domain it touches, seams it crosses, external contracts it depends on, user-facing surfaces it changes). pull as much context as you need to render a confident, well-grounded review: read related files, grep for callers of changed symbols, check tests that exercise the touched paths, fetch related GitHub state. **you are the synthesizer** never delegate understanding to subagents.
if the PR is **genuinely trivial**, skip steps 45 entirely and submit a \`No new issues found.\` review per step 6. there's no value in dispatching even one lens for a typo. if the PR is **genuinely trivial**, skip the fan-out entirely and submit a \`No new issues found.\` review per step 7.
"Genuinely trivial" (skip): "Genuinely trivial" (skip):
- single-word doc typo, whitespace/format-only, comment-only across any number of files - single-word doc typo, whitespace/format-only, comment-only across any number of files
@@ -198,25 +204,25 @@ For simple, well-defined tasks, skip the plan phase and go straight to build.`,
- any "typo fix" in user-facing copy that changes meaning ("approved" "denied") - any "typo fix" in user-facing copy that changes meaning ("approved" "denied")
- mixed diffs where a semantic 1-liner is buried in whitespace/formatting changes - mixed diffs where a semantic 1-liner is buried in whitespace/formatting changes
When unsure, treat as non-trivial. The cost of one extra subagent is cents; the cost of a missed billing/auth/data bug is much more. 4. **lens decision 0 or 2+, NEVER 1**.
otherwise pick lenses by where the PR concentrates risk **there's no fixed count**. lens count is judgment, not a formula. concrete shapes to anchor against: The default is **0 lenses**: handle the review yourself end-to-end. Most PRs land here.
- **1 lens** pure refactor / mechanical rename across many files (impact); new test file with no source change (test-integrity); small isolated bug fix (correctness); doc-only PR with non-trivial technical content (research-validated or holistic) Dispatch **2+ \`${REVIEWER_AGENT_NAME}\` lenses in parallel** ONLY when ALL of the following are true:
- **23 lenses (most PRs land here)** new CRUD endpoint (correctness + security + test-integrity); new UI flow (user-journey + correctness); a single bug fix in a non-critical subsystem (correctness + test-integrity); design doc covering one domain (research-validated + correctness or holistic) - the PR is substantive (>5 files changed AND >200 net lines), OR touches a high-stakes subsystem (auth, billing, payments, schema migration, webhooks, secrets, RBAC, multi-tenant isolation, cron/scheduling)
- **45 lenses (high-stakes subsystem touches)** any billing/payments change (billing-subsystem + correctness + security + operational-readiness); new auth flow (auth-subsystem + correctness + security + test-integrity); schema migration (schema-migration-subsystem + correctness + operational-readiness + impact); cross-subsystem PR that touches billing AND auth AND schema (one subsystem lens per domain + correctness) - you can name 2+ distinct concrete failure modes that warrant independent lenses (one lens per failure mode; orthogonal, not overlapping)
- **6+ lenses** almost always a smell; you're either covering overlapping ground or this PR should have been split. push back via the review body rather than expanding lens count. - parallel-orchestrated independent perspectives meaningfully outperform what you'd find solo
**lens-add discipline.** Each lens needs to clear a specific bar before you dispatch it: name the concrete failure mode this lens would catch *that the diff plausibly introduces*, in one sentence. "Could apply", "good to have", "for completeness" do not qualify. If you can't name what the lens is going to find, drop it. The "when unsure, treat as non-trivial" rule above is for the trivial-vs-non-trivial gate at step 3 it does not license expanding lens count without articulated risk. Every extra lens adds wall-time, log noise, and pulls subagent attention onto speculative angles, which biases the final review toward bloat-shaped findings. **NEVER dispatch exactly one lens.** A single lens is just a more expensive version of doing the work yourself with a worse model it adds wall time and a context-handoff for no orthogonality benefit. Either you have at least two genuinely independent failure-mode hypotheses (dispatch all in one turn), or you don't (do the review yourself).
lenses come in two flavors, and you can mix them: When you do go multi-lens, lens framings come in two flavors:
- **themed lenses** a perspective applied across the whole diff (correctness, security, user-journey, performance, etc.). - **themed lenses** a perspective applied across the whole diff (correctness, security, user-journey, performance, etc.).
- **subsystem lenses** a domain-scoped frame for high-stakes subsystems the PR touches (e.g. "the auth lens", "the billing lens", "the schema-migration lens"). a subsystem lens is "review the PR specifically for what could go wrong in this subsystem" and naturally combines theme + scope. **for high-stakes domains, lead with the subsystem lens rather than the generic themed equivalent** "billing-subsystem" outperforms "correctness on billing code" because the framing primes the subagent to remember domain-specific failure modes (double-charges, refund races, currency rounding, dispute flows) the generic lens misses. - **subsystem lenses** a domain-scoped frame for high-stakes subsystems the PR touches (e.g. "the auth lens", "the billing lens", "the schema-migration lens"). **for high-stakes domains, lead with the subsystem lens rather than the generic themed equivalent** "billing-subsystem" outperforms "correctness on billing code" because the framing primes the subagent to remember domain-specific failure modes (double-charges, refund races, currency rounding, dispute flows) the generic lens misses.
starter menu (combine, omit, or invent your own): starter menu (combine, omit, or invent your own):
- **correctness & invariants** bugs, races, error handling, edge cases, state-machine boundaries - **correctness & invariants** bugs, races, error handling, edge cases, state-machine boundaries
- **impact** when the PR removes features, deletes exports, renames identifiers, or changes architectural patterns: stale references in code, tests, docs (\`docs/\`, \`wiki/\`), comments, configs, UI - **impact** stale references in code/tests/docs/configs/UI after rename/remove
- **research-validated assumptions** third-party API contracts, SDK semantics, framework directives, version-gated behavior. **only pick when the PR's correctness depends on the contract behaving a specific way** not when the API is merely used. An idempotency key as a backstop, a timeout as a hint, a retry as belt-and-suspenders: not load-bearing, skip this lens. The bar is "if the third-party contract differs from what the diff assumes, the PR is incorrect." When dispatched, the subagent must verify load-bearing claims via web search and quote source URLs. - **research-validated assumptions** third-party API contracts, SDK semantics, framework directives, version-gated behavior. **only pick when the PR's correctness depends on the contract behaving a specific way** not when the API is merely used. The bar is "if the third-party contract differs from what the diff assumes, the PR is incorrect." When dispatched, the subagent must verify load-bearing claims via web search and quote source URLs.
- **security** new endpoints, authZ, input validation, secrets handling, replay/CSRF/injection, cross-tenant isolation - **security** new endpoints, authZ, input validation, secrets handling, replay/CSRF/injection, cross-tenant isolation
- **user-journey** UX-touching flows: walk through happy path and failure modes as a user - **user-journey** UX-touching flows: walk through happy path and failure modes as a user
- **operational readiness** observability, alerting, migrations (forward + rollback), feature flags, on-call burden - **operational readiness** observability, alerting, migrations (forward + rollback), feature flags, on-call burden
@@ -226,26 +232,36 @@ For simple, well-defined tasks, skip the plan phase and go straight to build.`,
- **holistic** does the PR make sense as a whole? symmetric flows (delete for every create, rollback for every migration)? - **holistic** does the PR make sense as a whole? symmetric flows (delete for every create, rollback for every migration)?
- **subsystem lenses** (invent as the PR demands) auth, billing, payments, schema migration, webhooks, secrets, RBAC, multi-tenant isolation, cron/scheduling, etc. - **subsystem lenses** (invent as the PR demands) auth, billing, payments, schema migration, webhooks, secrets, RBAC, multi-tenant isolation, cron/scheduling, etc.
4. **fan out**: dispatch one \`${REVIEWER_AGENT_NAME}\` subagent per lens — its baked-in system prompt enforces the non-mutative + non-recursive contract (read-only file/search/web tools and read-only MCP queries; no writes, shell side effects, state-changing MCP calls, or nested subagent dispatch). when picking 2+ lenses, dispatch them in a **single assistant turn with multiple parallel subagent calls**; issuing one and awaiting reply before the next collapses the fan-out into a serial review. if a subagent errors out, times out, or returns nothing usable, retry once with the same lens; if it still fails, proceed with partial coverage and note the missing lens in the review body — do not skip step 4 entirely on a single subagent failure. each subagent gets: The only subagent type is \`${REVIEWER_AGENT_NAME}\` — used for lens judgment work ("is this safe / correct / well-tested?"), runs on a mid-tier model.
5. **fan out (only if step 4 said 2+ lenses)**: dispatch every \`${REVIEWER_AGENT_NAME}\` subagent for this run **IN A SINGLE ASSISTANT TURN, AS MULTIPLE PARALLEL TASK TOOL_USE BLOCKS IN ONE MESSAGE.**
CRITICAL PARALLELISM IS THE ONLY REASON LENSES EXIST.
The default tool-call behavior of Claude Code (and most agent runtimes) is **serial dispatch**: emit one Task call, await result, emit next, await, etc. This collapses your fan-out into a sequential review where each lens adds N × (orchestrator-think-time + lens-execution-time) to wall time. **YOU MUST OVERRIDE THIS DEFAULT.** Emit ALL of your Task tool_use blocks in the SAME assistant message, BEFORE you read ANY result from ANY of them. If you find yourself emitting one Task call, then thinking about the result, then emitting another STOP and re-issue them all together. The whole point of going multi-lens is the wall-clock speedup from parallel execution; serial dispatch defeats it entirely.
Right pattern: one assistant turn with N Task tool_use blocks wait N results arrive together aggregate.
Wrong pattern: turn 1 = Task(lens A) turn 2 (after A's result) = Task(lens B) → turn 3 (after B's result) = Task(lens C). This is the failure mode. Do not do this.
You can also include your own \`read\` / \`grep\` / \`webfetch\` calls in the SAME turn as the parallel \`${REVIEWER_AGENT_NAME}\` dispatches — concurrent context-pulling on the orchestrator side runs in parallel with the lens fan-out and costs zero extra wall time.
if a subagent errors out, times out, or returns nothing usable, retry once with the same lens; if it still fails, proceed with partial coverage and note the missing lens in the review body do not skip the fan-out entirely on a single subagent failure. each subagent gets:
- the diff path / target reading the diff and the codebase is its job - the diff path / target reading the diff and the codebase is its job
- **only one lens** never a multi-section "review for X, Y, and Z" prompt - **only one lens** never a multi-section "review for X, Y, and Z" prompt
- **a Task \`description\` set to the lens name** (e.g. \`"security"\`, \`"correctness"\`, \`"billing-subsystem"\`) — the harness reads this field to label the subagent's log lines so parallel runs can be told apart in CI output. without it, every subagent shows up as \`subagent#N\`. - **a Task \`description\` set to the lens name** (e.g. \`"security"\`, \`"correctness"\`, \`"billing-subsystem"\`) — the harness reads this field to label the subagent's log lines so parallel runs can be told apart in CI output. without it, every subagent shows up as \`subagent#N\`.
- the read-only contract restated in your dispatch instructions so the rule is present twice (the subagent's system prompt also enforces it). The test: would this call still be a no-op if reverted? If not (PR comments, branch pushes, issue updates, set_output, label changes, dependency installs, etc.), don't make it.
- if the lens touches external contracts, instruct the subagent to verify load-bearing claims via web search rather than trust training data, and to quote source URLs in its reasoning. action runs are non-interactive there's no human in the loop to catch "I'm pretty sure Stripe does X." - if the lens touches external contracts, instruct the subagent to verify load-bearing claims via web search rather than trust training data, and to quote source URLs in its reasoning. action runs are non-interactive there's no human in the loop to catch "I'm pretty sure Stripe does X."
- ask the subagent to report findings with file paths and NEW line numbers from the diff so you can anchor inline comments without re-reading the entire diff. - ask the subagent to report findings with file paths and NEW line numbers from the diff so you can anchor inline comments without re-reading the entire diff.
delegation discipline: delegation discipline:
- do NOT lens-review the diff yourself in parallel with the subagents (your job is dispatch + comment-drafting; doing the lens work yourself reintroduces the bias the fan-out avoids)
- do NOT summarize the PR for them (biases toward a validation frame) - do NOT summarize the PR for them (biases toward a validation frame)
- do NOT hand them a curated reading list (let them discover scope) - do NOT hand them a curated reading list (let them discover scope)
- do NOT pre-shape their output with a finding schema - do NOT pre-shape their output with a finding schema
- do NOT mention the other lenses (independence is the point overlapping findings are a strong signal) - do NOT mention the other lenses (independence is the point overlapping findings are a strong signal)
5. **aggregate & draft**: merge findings; de-dup overlaps (two lenses catching the same issue = higher-confidence signal); trace each finding yourself before accepting it. drop praise, style preferences, speculative/unverified claims, findings about pre-existing code unrelated to the PR (heuristic: if the finding's root cause lives in lines this PR added or modified, it's in scope; otherwise drop unless the PR plausibly introduced or amplified the regression), and anything not actionable. also drop **bloat-shaped findings** proposed fixes that would add defensive checks for cases that can't happen, abstractions used once, comments restating obvious code, tests asserting tautologies, or "just-in-case" guards. subagents are fallible and bias toward recommending changes; the bar for an actionable inline comment is sound + correct + elegant. recommending a change that improves only one of the three (or worse, degrades elegance to nominally improve correctness) makes the codebase worse, not better. 6. **aggregate & draft**: when the fan-out lands, merge findings; de-dup overlaps (two lenses catching the same issue = higher-confidence signal); trace each finding yourself before accepting it. drop praise, style preferences, speculative/unverified claims, findings about pre-existing code unrelated to the PR (heuristic: if the finding's root cause lives in lines this PR added or modified, it's in scope; otherwise drop unless the PR plausibly introduced or amplified the regression), and anything not actionable. also drop **bloat-shaped findings** proposed fixes that would add defensive checks for cases that can't happen, abstractions used once, comments restating obvious code, tests asserting tautologies, or "just-in-case" guards. subagents are fallible and bias toward recommending changes; the bar for an actionable inline comment is sound + correct + elegant. recommending a change that improves only one of the three (or worse, degrades elegance to nominally improve correctness) makes the codebase worse, not better.
for surviving findings, draft inline comments with NEW line numbers from the diff. every comment must be actionable, 2-3 sentences max. use GitHub permalink format for code references. for impact-analysis findings (stale references after rename/remove), report them in the review body ordered by severity (runtime breakage > incorrect docs > stale comments) rather than as inline comments unless they're anchored to a specific line. for surviving findings, draft inline comments with NEW line numbers from the diff. every comment must be actionable, 2-3 sentences max. use GitHub permalink format for code references. for impact-analysis findings (stale references after rename/remove), report them in the review body ordered by severity (runtime breakage > incorrect docs > stale comments) rather than as inline comments unless they're anchored to a specific line.
6. **submit**: ALWAYS submit exactly one review via \`${t("create_pull_request_review")}\`. Do NOT call \`report_progress\` — the review is the final record and the progress comment will be cleaned up automatically. 7. **submit**: ALWAYS submit exactly one review via \`${t("create_pull_request_review")}\`. Do NOT call \`report_progress\` — the review is the final record and the progress comment will be cleaned up automatically.
note: the first create_pull_request_review submission may error with a one-time diff-coverage nudge listing unread TOC regions. retry the same call to proceed optionally after reading the listed ranges. the pre-flight will not block again this session. note: the first create_pull_request_review submission may error with a one-time diff-coverage nudge listing unread TOC regions. retry the same call to proceed optionally after reading the listed ranges. the pre-flight will not block again this session.
@@ -273,10 +289,10 @@ For simple, well-defined tasks, skip the plan phase and go straight to build.`,
${PR_SUMMARY_FORMAT}`, ${PR_SUMMARY_FORMAT}`,
}, },
// IncrementalReview shares Review's multi-lens orchestrator pattern but // IncrementalReview shares Review's 0-or-2+ lens pattern but scopes the
// scopes the target to the incremental diff. The "issues must be NEW // target to the incremental diff. The "issues must be NEW since the last
// since the last Pullfrog review" filter lives at aggregation time // Pullfrog review" filter lives at aggregation time (step 8), NOT in the
// (step 6), NOT in the subagent prompt — pushing the filter into // subagent prompt — pushing the filter into
// subagents matches the canonical anneal anti-pattern of "list known // subagents matches the canonical anneal anti-pattern of "list known
// pre-existing failures — don't flag these" and suppresses signal on // pre-existing failures — don't flag these" and suppresses signal on
// regressions the new commits amplified. The review body is just // regressions the new commits amplified. The review body is just
@@ -296,38 +312,57 @@ ${PR_SUMMARY_FORMAT}`,
3. **incremental scope**: if \`incrementalDiffPath\` is present, read it to see what changed since the last review. this is a range-diff that isolates the net changes, filtering out base branch noise. if not present, fall back to reviewing the full PR diff and determine what changed since Pullfrog's most recent review. 3. **incremental scope**: if \`incrementalDiffPath\` is present, read it to see what changed since the last review. this is a range-diff that isolates the net changes, filtering out base branch noise. if not present, fall back to reviewing the full PR diff and determine what changed since Pullfrog's most recent review.
4. **prior feedback**: fetch previous reviews via \`${t("list_pull_request_reviews")}\`. for the most recent Pullfrog review, call \`${t("get_review_comments")}\` with the review ID to retrieve specific prior line-level feedback. you'll use this to filter your aggregation in step 6 — anything already flagged in a prior review and not changed by the new commits should not be re-raised. you do NOT need to render this in the review body; the rolling PR summary snapshot is the durable record of what's been addressed. 4. **prior feedback**: fetch previous reviews via \`${t("list_pull_request_reviews")}\`. for the most recent Pullfrog review, call \`${t("get_review_comments")}\` with the review ID to retrieve specific prior line-level feedback. you'll use this to filter your aggregation in step 8 — anything already flagged in a prior review and not changed by the new commits should not be re-raised. you do NOT need to render this in the review body; the rolling PR summary snapshot is the durable record of what's been addressed.
5. **triage & fan out**: orient on the *incremental* changes domain, seams, external contracts, user-facing surfaces. 5. **triage**: orient on the *incremental* changes domain, seams, external contracts, user-facing surfaces. pull as much context as you need to render a confident review: read related files, grep for callers of changed symbols, check tests that exercise the touched paths. **you are the synthesizer.**
if the incremental changes are **genuinely trivial**, skip the fan-out entirely and jump to step 8's non-substantive path (do NOT submit a review). if the incremental changes are **genuinely trivial**, skip the fan-out entirely and jump to step 10's non-substantive path (do NOT submit a review).
"Genuinely trivial" (skip): formatting/comment tweaks, import reordering, lockfile regen, mechanical rename of import paths, whitespace-only. "Genuinely trivial" (skip): formatting/comment tweaks, import reordering, lockfile regen, mechanical rename of import paths, whitespace-only.
"Looks trivial but isn't" (do NOT skip same anti-patterns as Review mode): 1-line changes to SQL/regex/auth/billing/permissions/signature-verification code; flipping feature-flag defaults or retry/timeout constants; money/tax/HTTP-method/redirect changes; tightening or loosening a comparison operator; mixed diffs with a semantic line buried in formatting. "Looks trivial but isn't" (do NOT skip same anti-patterns as Review mode): 1-line changes to SQL/regex/auth/billing/permissions/signature-verification code; flipping feature-flag defaults or retry/timeout constants; money/tax/HTTP-method/redirect changes; tightening or loosening a comparison operator; mixed diffs with a semantic line buried in formatting.
When unsure, treat as non-trivial. When unsure, treat as non-trivial.
otherwise pick lenses by where the new commits concentrate risk **there's no fixed count**, same calibration as Review mode (1 lens for pure refactor / isolated fix; 23 for typical features; 45 for high-stakes subsystem touches; 6+ is a smell). same **lens-add discipline** as Review mode applies: each lens needs to name the concrete failure mode it would catch *that the new commits plausibly introduce* — "could apply" doesn't qualify, drop it. **research-validated assumptions** specifically: only pick when the new commits' correctness depends on a third-party contract behaving a specific way; merely using an API doesn't qualify. lens framing follows Review mode: themed lenses (correctness & invariants, impact when new commits remove/rename/deprecate things, research-validated assumptions, security, user-journey, operational readiness, integration & cross-cutting, test integrity, performance, holistic) and subsystem lenses (auth, billing, schema migration, etc.) for high-stakes domains lead with the subsystem lens rather than the generic themed equivalent. 6. **lens decision 0 or 2+, NEVER 1**.
dispatch one \`${REVIEWER_AGENT_NAME}\` subagent per lens — its baked-in system prompt enforces the non-mutative + non-recursive contract (read-only file/search/web tools and read-only MCP queries; no writes, shell side effects, state-changing MCP calls, or nested subagent dispatch). dispatch them in a **single assistant turn with multiple parallel subagent calls** (serial dispatch collapses the fan-out). if a subagent errors out, times out, or returns nothing usable, retry once with the same lens; if it still fails, proceed with partial coverage and note the missing lens in the review body — do not skip step 5 entirely on a single subagent failure. each subagent gets: The default is **0 lenses**: handle the re-review yourself end-to-end. Most incremental reviews land here especially thread-reply re-reviews where the user is asking "did you address X?" rather than "review the diff again."
- the diff scope (incremental diff path if available, full diff otherwise). do NOT tell them to skip pre-existing issues that suppresses regressions the new commits amplified; the "issues must be NEW" filter lives at aggregation time (step 6), not in the subagent prompt
Dispatch **2+ \`${REVIEWER_AGENT_NAME}\` lenses in parallel** ONLY when ALL of the following are true:
- the incremental changes are substantive (>5 files changed AND >200 net new lines), OR touch a high-stakes subsystem (auth, billing, payments, schema migration, webhooks, secrets, RBAC, multi-tenant isolation, cron/scheduling)
- you can name 2+ distinct concrete failure modes the new commits plausibly introduce that warrant independent lenses
- parallel-orchestrated independent perspectives meaningfully outperform what you'd find solo
**NEVER dispatch exactly one lens.** Single-lens dispatch adds wall time and cost for no orthogonality benefit. Either go multi-lens (2 in parallel) or do the re-review yourself.
Lens framing follows Review mode: themed lenses (correctness, security, etc.) and subsystem lenses (auth, billing, schema-migration, etc.) for high-stakes domains lead with the subsystem lens.
7. **fan out (only if step 6 said 2+ lenses)**: dispatch every \`${REVIEWER_AGENT_NAME}\` subagent for this run **IN A SINGLE ASSISTANT TURN, AS MULTIPLE PARALLEL TASK TOOL_USE BLOCKS IN ONE MESSAGE.**
CRITICAL PARALLELISM IS THE ONLY REASON LENSES EXIST.
Default tool-call behavior is **serial dispatch**: emit one Task call, await result, emit next, await, etc. This collapses your fan-out into a sequential review where each lens adds N × (orchestrator-think-time + lens-execution-time) to wall time. **YOU MUST OVERRIDE THIS DEFAULT.** Emit ALL of your Task tool_use blocks in the SAME assistant message, BEFORE you read ANY result from ANY of them.
Right pattern: one assistant turn with N Task tool_use blocks wait N results arrive together aggregate.
Wrong pattern: turn 1 = Task(lens A) turn 2 (after A's result) = Task(lens B). This is the failure mode.
You can also include your own \`read\` / \`grep\` / \`webfetch\` calls in the SAME turn as the parallel \`${REVIEWER_AGENT_NAME}\` dispatches.
if a subagent errors out, times out, or returns nothing usable, retry once with the same lens; if it still fails, proceed with partial coverage and note the missing lens in the review body. each subagent gets:
- the diff scope (incremental diff path if available, full diff otherwise). do NOT tell them to skip pre-existing issues that suppresses regressions the new commits amplified; the "issues must be NEW" filter lives at aggregation time (step 8), not in the subagent prompt
- **only one lens** never a multi-section "review for X, Y, and Z" prompt - **only one lens** never a multi-section "review for X, Y, and Z" prompt
- **a Task \`description\` set to the lens name** (e.g. \`"security"\`, \`"correctness"\`, \`"billing-subsystem"\`) — the harness reads this field to label the subagent's log lines so parallel runs can be told apart in CI output. without it, every subagent shows up as \`subagent#N\`. - **a Task \`description\` set to the lens name** — the harness reads this field to label log lines so parallel runs can be told apart.
- the read-only contract restated in your dispatch instructions so the rule is present twice (the subagent's system prompt also enforces it). The test: would this call still be a no-op if reverted? If not (PR comments, branch pushes, issue updates, set_output, label changes, dependency installs, etc.), don't make it. - if the lens touches external contracts, instruct the subagent to verify load-bearing claims via web search and quote source URLs.
- if the lens touches external contracts, instruct the subagent to verify load-bearing claims via web search and quote source URLs. action runs are non-interactive there's no human to catch "I'm pretty sure Stripe does X."
- ask the subagent to report findings with file paths and NEW line numbers from the full PR diff so you can anchor inline comments. - ask the subagent to report findings with file paths and NEW line numbers from the full PR diff so you can anchor inline comments.
delegation discipline: delegation discipline:
- do NOT lens-review the diff yourself in parallel with the subagents
- do NOT summarize the changes for them (biases toward validation frame) - do NOT summarize the changes for them (biases toward validation frame)
- do NOT hand them a curated reading list (let them discover scope) - do NOT hand them a curated reading list (let them discover scope)
- do NOT pre-shape their output with a finding schema - do NOT pre-shape their output with a finding schema
- do NOT mention the other lenses (independence is the point) - do NOT mention the other lenses (independence is the point)
6. **aggregate, draft, self-critique**: merge findings; de-dup overlaps; trace each finding yourself. drop praise, style preferences, speculative/unverified claims, findings about pre-existing code unrelated to the new commits, anything not actionable, and anything that re-states prior review feedback (heuristic: if the finding's root cause lives in lines the *new commits* added or modified, it's in scope; otherwise drop). also drop **bloat-shaped findings** proposed fixes that would add defensive checks for cases that can't happen, abstractions used once, comments restating obvious code, tests asserting tautologies, or "just-in-case" guards. subagents are fallible and bias toward recommending changes; the bar for an actionable inline comment is sound + correct + elegant. recommending a change that improves only one of the three (or degrades elegance to nominally improve correctness) makes the codebase worse, not better. To compute "lines the new commits added or modified": if \`incrementalDiffPath\` from step 2 is present, use it directly. Otherwise, take the prior Pullfrog review's \`commit_id\` (returned alongside each entry from \`${t("list_pull_request_reviews")}\` in step 4) and run \`git diff <prior-review-sha>..HEAD\` to isolate the lines added since that review. draft inline comments with NEW line numbers from the full PR diff — every comment must be actionable, 2-3 sentences max. 8. **aggregate, draft, self-critique**: merge findings (yours + any subagent output if you went multi-lens); de-dup overlaps; trace each finding yourself. drop praise, style preferences, speculative/unverified claims, findings about pre-existing code unrelated to the new commits, anything not actionable, and anything that re-states prior review feedback (heuristic: if the finding's root cause lives in lines the *new commits* added or modified, it's in scope; otherwise drop). also drop **bloat-shaped findings** proposed fixes that would add defensive checks for cases that can't happen, abstractions used once, comments restating obvious code, tests asserting tautologies, or "just-in-case" guards. subagents are fallible and bias toward recommending changes; the bar for an actionable inline comment is sound + correct + elegant. recommending a change that improves only one of the three (or degrades elegance to nominally improve correctness) makes the codebase worse, not better. To compute "lines the new commits added or modified": if \`incrementalDiffPath\` from step 2 is present, use it directly. Otherwise, take the prior Pullfrog review's \`commit_id\` (returned alongside each entry from \`${t("list_pull_request_reviews")}\` in step 4) and run \`git diff <prior-review-sha>..HEAD\` to isolate the lines added since that review. draft inline comments with NEW line numbers from the full PR diff — every comment must be actionable, 2-3 sentences max.
7. **build the review body** a single "Reviewed changes" section: summarize at the logical-change level, not per-file. each bullet starts with a past-tense verb (e.g. \`- Extracted shared CLI runtime into a single module\`, \`- Renamed package to pullfrog\`). avoid file paths unless they add clarity. if the changes can be described in one sentence, use one sentence — no bullets needed. do NOT include a separate "Prior review feedback" checklist; that's tracked in the rolling PR summary snapshot for the next agent run, and surfacing it in the user-facing body is noise (changes that addressed prior feedback are already covered by the Reviewed-changes bullets). in some cases you may receive a complete diff for the whole pull request instead of an incremental one — when this happens, you will need to determine what changes have happened since Pullfrog's most recent review. 9. **build the review body** a single "Reviewed changes" section: summarize at the logical-change level, not per-file. each bullet starts with a past-tense verb (e.g. \`- Extracted shared CLI runtime into a single module\`, \`- Renamed package to pullfrog\`). avoid file paths unless they add clarity. if the changes can be described in one sentence, use one sentence — no bullets needed. do NOT include a separate "Prior review feedback" checklist; that's tracked in the rolling PR summary snapshot for the next agent run, and surfacing it in the user-facing body is noise (changes that addressed prior feedback are already covered by the Reviewed-changes bullets). in some cases you may receive a complete diff for the whole pull request instead of an incremental one — when this happens, you will need to determine what changes have happened since Pullfrog's most recent review.
8. Submit every run must end with EXACTLY ONE of \`${t("create_pull_request_review")}\` (substantive review) or \`${t("report_progress")}\` (no-review acknowledgement). do NOT call \`create_issue_comment\` for review output. 10. Submit every run must end with EXACTLY ONE of \`${t("create_pull_request_review")}\` (substantive review) or \`${t("report_progress")}\` (no-review acknowledgement). do NOT call \`create_issue_comment\` for review output.
Same callout-intensity ladder as Review mode \`[!CAUTION]\` (large red, "will break") → \`[!IMPORTANT]\` (large purple, "must address before merging") → \`[!NOTE]\` (small blue, "FYI") → no callout (plain text). And the same Fix-button lever: the footer renders a Fix button on every non-approving review, so \`approved: true\` suppresses it. Wrapping mergeable feedback in \`[!IMPORTANT]\` trains users to click Fix on reviews that don't need fixing — pick the tier the author's actual next action justifies. Same callout-intensity ladder as Review mode \`[!CAUTION]\` (large red, "will break") → \`[!IMPORTANT]\` (large purple, "must address before merging") → \`[!NOTE]\` (small blue, "FYI") → no callout (plain text). And the same Fix-button lever: the footer renders a Fix button on every non-approving review, so \`approved: true\` suppresses it. Wrapping mergeable feedback in \`[!IMPORTANT]\` trains users to click Fix on reviews that don't need fixing — pick the tier the author's actual next action justifies.
+1 -1
View File
@@ -1,6 +1,6 @@
{ {
"name": "pullfrog", "name": "pullfrog",
"version": "0.1.6", "version": "0.1.7",
"type": "module", "type": "module",
"bin": { "bin": {
"pullfrog": "dist/cli.mjs", "pullfrog": "dist/cli.mjs",
+9
View File
@@ -104,6 +104,15 @@ function createRuntimeContext(): RuntimeContext {
const env: NodeJS.ProcessEnv = { ...process.env }; const env: NodeJS.ProcessEnv = { ...process.env };
env.npm_config_registry = NPM_REGISTRY; env.npm_config_registry = NPM_REGISTRY;
env.COREPACK_NPM_REGISTRY = NPM_REGISTRY; env.COREPACK_NPM_REGISTRY = NPM_REGISTRY;
// bypass customer-side release-age gates (npm's `min-release-age`, pnpm's
// `minimumReleaseAge`) so our bootstrap can resolve the latest publish.
// pullfrog's npm version is server-stamped from a SHA-pinned action ref the
// customer already vets at the action layer — not a customer-vetted dep, so
// the gate is the wrong affordance here. env beats .npmrc in both tools.
// npm uses `npm_config_*`; pnpm v11+ requires `pnpm_config_*` (the v10→v11
// migration renamed the prefix). tracked: #713
env.npm_config_min_release_age = "0";
env.pnpm_config_minimum_release_age = "0";
const currentPath = process.env.PATH ?? ""; const currentPath = process.env.PATH ?? "";
env.PATH = currentPath ? `${nodeBinDir}${delimiter}${currentPath}` : nodeBinDir; env.PATH = currentPath ? `${nodeBinDir}${delimiter}${currentPath}` : nodeBinDir;
+3
View File
@@ -50,6 +50,9 @@ const FLAGSHIPS = [
function isPrunablePassthrough(alias: (typeof modelAliases)[number]): boolean { function isPrunablePassthrough(alias: (typeof modelAliases)[number]): boolean {
if (ROUTING_CANARIES.has(alias.slug)) return false; if (ROUTING_CANARIES.has(alias.slug)) return false;
if (alias.provider === "openrouter") return true; if (alias.provider === "openrouter") return true;
// routing slugs (bedrock/byok) need a per-run env var to pick the actual
// model — there's no generic smoke test, so prune from both matrices.
if (alias.routing) return true;
// opencode FREE models (big-pickle, mimo-v2-pro-free, minimax-m2.5-free) // opencode FREE models (big-pickle, mimo-v2-pro-free, minimax-m2.5-free)
// are unique to opencode and used in prod — keep them. only prune the keyed // are unique to opencode and used in prod — keep them. only prune the keyed
// mirrors. // mirrors.
+5
View File
@@ -44,6 +44,11 @@ type Plan =
async function plan(slug: string): Promise<Plan> { async function plan(slug: string): Promise<Plan> {
const alias = modelAliases.find((a) => a.slug === slug); const alias = modelAliases.find((a) => a.slug === slug);
if (!alias) throw new Error(`model-smoke: unknown alias "${slug}"`); if (!alias) throw new Error(`model-smoke: unknown alias "${slug}"`);
if (alias.routing) {
throw new Error(
`model-smoke: ${slug} is a routing slug (no fixed model). pass an explicit Bedrock model ID via PULLFROG_MODEL or the workflow env block.`
);
}
// walk the fallback chain so deprecated aliases (those with `fallback` set, // walk the fallback chain so deprecated aliases (those with `fallback` set,
// e.g. opencode/mimo-v2-pro-free → opencode/big-pickle) hit their replacement // e.g. opencode/mimo-v2-pro-free → opencode/big-pickle) hit their replacement
+5
View File
@@ -42,6 +42,11 @@ describe("models.dev validity", async () => {
const data = await api; const data = await api;
for (const alias of modelAliases) { for (const alias of modelAliases) {
// routing slugs (e.g. bedrock/byok) have no fixed `resolve` — the actual
// model ID is read from a separate env var at run time. skip drift checks
// since there's no models.dev entry to validate against.
if (alias.routing) continue;
const parsed = parseResolve(alias.resolve); const parsed = parseResolve(alias.resolve);
it(`${alias.resolve} exists on models.dev`, () => { it(`${alias.resolve} exists on models.dev`, () => {
+11
View File
@@ -14,6 +14,10 @@ const BYOK_ONLY_MODELS = new Set(["openai/o3"]);
describe("openRouterResolve completeness", () => { describe("openRouterResolve completeness", () => {
for (const alias of modelAliases) { for (const alias of modelAliases) {
if (alias.isFree) continue; if (alias.isFree) continue;
// routing slugs (e.g. bedrock/byok) are inherently BYOK — there's no
// single model to map to OpenRouter because the actual model ID is read
// from a per-run env var.
if (alias.routing) continue;
if (BYOK_ONLY_MODELS.has(alias.slug)) continue; if (BYOK_ONLY_MODELS.has(alias.slug)) continue;
it(`${alias.slug} has openRouterResolve`, () => { it(`${alias.slug} has openRouterResolve`, () => {
expect( expect(
@@ -29,6 +33,13 @@ describe("openRouterResolve completeness", () => {
expect(alias.openRouterResolve).toBeUndefined(); expect(alias.openRouterResolve).toBeUndefined();
}); });
} }
for (const alias of modelAliases) {
if (!alias.routing) continue;
it(`${alias.slug} (routing slug) has no openRouterResolve`, () => {
expect(alias.openRouterResolve).toBeUndefined();
});
}
}); });
describe("fallback chain resolution", () => { describe("fallback chain resolution", () => {
+8
View File
@@ -28,6 +28,14 @@ const results: { model: string; status: "pass" | "fail" | "skip"; detail?: strin
const seen = new Set<string>(); const seen = new Set<string>();
for (const alias of modelAliases) { for (const alias of modelAliases) {
// routing slugs (bedrock/byok) have no fixed `resolve` to test against —
// the model ID is supplied at run time via a per-run env var. skipping
// here matches the bumps cron + catalog drift test.
if (alias.routing) {
results.push({ model: alias.slug, status: "skip", detail: "routing slug (no fixed resolve)" });
continue;
}
if (seen.has(alias.resolve)) { if (seen.has(alias.resolve)) {
results.push({ model: alias.resolve, status: "skip", detail: "duplicate resolve" }); results.push({ model: alias.resolve, status: "skip", detail: "duplicate resolve" });
continue; continue;
+127 -5
View File
@@ -1,9 +1,131 @@
import { describe, expect, it } from "vitest"; import { afterEach, beforeEach, describe, expect, it } from "vitest";
import { resolveAgent } from "./agent.ts"; import { resolveAgent, resolveModel } from "./agent.ts";
const savedEnv = { ...process.env };
const STRIPPED = [
/_API_KEY$/,
/^CLAUDE_CODE_OAUTH_TOKEN$/,
/^AWS_BEARER_TOKEN_BEDROCK$/,
/^AWS_ACCESS_KEY_ID$/,
/^AWS_SECRET_ACCESS_KEY$/,
/^AWS_SESSION_TOKEN$/,
/^AWS_REGION$/,
/^BEDROCK_MODEL_ID$/,
/^PULLFROG_MODEL$/,
/^PULLFROG_AGENT$/,
];
beforeEach(() => {
for (const key of Object.keys(process.env)) {
if (STRIPPED.some((re) => re.test(key))) delete process.env[key];
}
});
afterEach(() => {
process.env = { ...savedEnv };
});
describe("resolveAgent", () => { describe("resolveAgent", () => {
it("returns opencode", () => { it("returns opencode by default", () => {
const agent = resolveAgent({}); expect(resolveAgent({}).name).toBe("opencode");
expect(agent.name).toBe("opencode"); });
it("routes anthropic/* to claude when ANTHROPIC_API_KEY is set", () => {
process.env.ANTHROPIC_API_KEY = "sk-test";
expect(resolveAgent({ model: "anthropic/claude-opus-4-7" }).name).toBe("claude");
});
it("falls back to opencode for anthropic/* without claude-code creds", () => {
expect(resolveAgent({ model: "anthropic/claude-opus-4-7" }).name).toBe("opencode");
});
describe("bedrock routing", () => {
it("routes Anthropic Bedrock IDs to claude", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(resolveAgent({ model: "us.anthropic.claude-opus-4-7" }).name).toBe("claude");
});
it("routes Anthropic Bedrock IDs (no region prefix) to claude", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.BEDROCK_MODEL_ID = "anthropic.claude-haiku-4-5-20251001-v1:0";
expect(resolveAgent({ model: "anthropic.claude-haiku-4-5-20251001-v1:0" }).name).toBe(
"claude"
);
});
it("routes non-Anthropic Bedrock IDs to opencode", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.BEDROCK_MODEL_ID = "amazon.nova-pro-v1:0";
expect(resolveAgent({ model: "amazon.nova-pro-v1:0" }).name).toBe("opencode");
});
it("routes Llama IDs to opencode", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.BEDROCK_MODEL_ID = "us.meta.llama4-scout-17b-instruct-v1:0";
expect(resolveAgent({ model: "us.meta.llama4-scout-17b-instruct-v1:0" }).name).toBe(
"opencode"
);
});
it("accepts AWS access keys as auth", () => {
process.env.AWS_ACCESS_KEY_ID = "AKIA-test";
process.env.AWS_SECRET_ACCESS_KEY = "secret-test";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(resolveAgent({ model: "us.anthropic.claude-opus-4-7" }).name).toBe("claude");
});
it("PULLFROG_AGENT override wins over Anthropic auto-routing", () => {
process.env.PULLFROG_AGENT = "opencode";
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(resolveAgent({ model: "us.anthropic.claude-opus-4-7" }).name).toBe("opencode");
});
});
});
describe("resolveModel", () => {
it("PULLFROG_MODEL override wins", () => {
process.env.PULLFROG_MODEL = "anthropic/claude-opus";
expect(resolveModel({ slug: "openai/gpt" })).toBe("anthropic/claude-opus-4-7");
});
it("PULLFROG_MODEL bypasses bedrock routing entirely", () => {
process.env.PULLFROG_MODEL = "openai/gpt";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(resolveModel({ slug: "bedrock/byok" })).toBe("openai/gpt-5.5");
});
it("resolves bedrock/byok to BEDROCK_MODEL_ID", () => {
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(resolveModel({ slug: "bedrock/byok" })).toBe("us.anthropic.claude-opus-4-7");
});
it("throws when bedrock/byok is selected without BEDROCK_MODEL_ID", () => {
expect(() => resolveModel({ slug: "bedrock/byok" })).toThrow("BEDROCK_MODEL_ID");
});
it("returns the alias resolve for normal slugs", () => {
expect(resolveModel({ slug: "openai/gpt" })).toBe("openai/gpt-5.5");
});
it("returns undefined for no slug + no PULLFROG_MODEL", () => {
expect(resolveModel({})).toBeUndefined();
});
// regression: PR #720 review caught that `resolveCliModel("bedrock/byok")`
// returns the literal sentinel `"bedrock"` from the alias's `resolve`
// field. Without routing-aware handling, PULLFROG_MODEL=bedrock/byok would
// leak that sentinel downstream and break agent dispatch.
it("PULLFROG_MODEL=bedrock/byok defers to BEDROCK_MODEL_ID, not the sentinel", () => {
process.env.PULLFROG_MODEL = "bedrock/byok";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(resolveModel({ slug: "openai/gpt" })).toBe("us.anthropic.claude-opus-4-7");
});
it("PULLFROG_MODEL=bedrock/byok throws if BEDROCK_MODEL_ID is missing", () => {
process.env.PULLFROG_MODEL = "bedrock/byok";
expect(() => resolveModel({ slug: "openai/gpt" })).toThrow("BEDROCK_MODEL_ID");
}); });
}); });
+55 -7
View File
@@ -1,6 +1,12 @@
import type { Agent } from "../agents/index.ts"; import type { Agent } from "../agents/index.ts";
import { agents } from "../agents/index.ts"; import { agents } from "../agents/index.ts";
import { getModelProvider, resolveCliModel } from "../models.ts"; import {
BEDROCK_MODEL_ID_ENV,
getModelProvider,
isBedrockAnthropicId,
resolveCliModel,
resolveDisplayAlias,
} from "../models.ts";
import { log } from "./cli.ts"; import { log } from "./cli.ts";
function hasEnvVar(name: string): boolean { function hasEnvVar(name: string): boolean {
@@ -12,6 +18,37 @@ function hasClaudeCodeAuth(): boolean {
return hasEnvVar("CLAUDE_CODE_OAUTH_TOKEN") || hasEnvVar("ANTHROPIC_API_KEY"); return hasEnvVar("CLAUDE_CODE_OAUTH_TOKEN") || hasEnvVar("ANTHROPIC_API_KEY");
} }
function hasBedrockAuth(): boolean {
return (
hasEnvVar("AWS_BEARER_TOKEN_BEDROCK") ||
(hasEnvVar("AWS_ACCESS_KEY_ID") && hasEnvVar("AWS_SECRET_ACCESS_KEY"))
);
}
/**
* resolve a single slug to its CLI-ready model string. routing aliases
* (e.g. `bedrock/byok`) defer to their backing env var instead of the
* sentinel stored in `resolve`. shared between PULLFROG_MODEL override
* and repo-config slug resolution so both paths get the same routing
* semantics without this helper, `PULLFROG_MODEL=bedrock/byok` would
* leak the literal sentinel string `"bedrock"` downstream.
*/
function resolveSlug(slug: string): string | undefined {
const alias = resolveDisplayAlias(slug);
if (alias?.routing === "bedrock") {
const bedrockId = process.env[BEDROCK_MODEL_ID_ENV]?.trim();
if (!bedrockId) {
throw new Error(
`${BEDROCK_MODEL_ID_ENV} env var is required when the model is set to "${slug}". ` +
`set it to an AWS Bedrock model ID (e.g. "us.anthropic.claude-opus-4-7", "amazon.nova-pro-v1:0"). ` +
`see https://docs.pullfrog.com/bedrock for setup.`
);
}
return bedrockId;
}
return resolveCliModel(slug);
}
/** /**
* resolve the effective model for this run. * resolve the effective model for this run.
* *
@@ -19,17 +56,20 @@ function hasClaudeCodeAuth(): boolean {
* 1. PULLFROG_MODEL env var resolved through the alias registry first, * 1. PULLFROG_MODEL env var resolved through the alias registry first,
* so values like "anthropic/claude-opus" become "anthropic/claude-opus-4-7". * so values like "anthropic/claude-opus" become "anthropic/claude-opus-4-7".
* raw specifiers (e.g. "anthropic/claude-opus-4-6") pass through unchanged. * raw specifiers (e.g. "anthropic/claude-opus-4-6") pass through unchanged.
* 2. slug from repo config / payload alias registry * always wins bypasses Bedrock routing entirely. to test a different
* 3. undefined agent will auto-select * Bedrock model, change `BEDROCK_MODEL_ID`, not `PULLFROG_MODEL`.
* 2. slug from repo config / payload alias registry. routing slugs
* (e.g. `bedrock/byok`) defer to a separate env var (`BEDROCK_MODEL_ID`).
* 3. undefined agent will auto-select.
*/ */
export function resolveModel(ctx: { slug?: string | undefined }): string | undefined { export function resolveModel(ctx: { slug?: string | undefined }): string | undefined {
const envModel = process.env.PULLFROG_MODEL?.trim(); const envModel = process.env.PULLFROG_MODEL?.trim();
if (envModel) { if (envModel) {
return resolveCliModel(envModel) ?? envModel; return resolveSlug(envModel) ?? envModel;
} }
if (ctx.slug) { if (ctx.slug) {
const resolved = resolveCliModel(ctx.slug); const resolved = resolveSlug(ctx.slug);
if (resolved) { if (resolved) {
return resolved; return resolved;
} }
@@ -49,7 +89,15 @@ export function resolveAgent(ctx: { model?: string | undefined }): Agent {
log.warning(`» unknown PULLFROG_AGENT="${envAgent}" — falling through to auto-select`); log.warning(`» unknown PULLFROG_AGENT="${envAgent}" — falling through to auto-select`);
} }
// 2. if model is Anthropic and Claude Code credentials are available, use Claude Code // 2. Bedrock routing: when BEDROCK_MODEL_ID is the resolved model, route
// Anthropic IDs through claude-code (which supports Bedrock natively
// once CLAUDE_CODE_USE_BEDROCK=1) and everything else through opencode's
// `amazon-bedrock` provider.
if (ctx.model && hasBedrockAuth() && process.env[BEDROCK_MODEL_ID_ENV]?.trim() === ctx.model) {
return isBedrockAnthropicId(ctx.model) ? agents.claude : agents.opencode;
}
// 3. if model is Anthropic and Claude Code credentials are available, use Claude Code
if (ctx.model) { if (ctx.model) {
try { try {
const provider = getModelProvider(ctx.model); const provider = getModelProvider(ctx.model);
@@ -61,6 +109,6 @@ export function resolveAgent(ctx: { model?: string | undefined }): Agent {
} }
} }
// 3. default: OpenCode (universal, supports all providers) // 4. default: OpenCode (universal, supports all providers)
return agents.opencode; return agents.opencode;
} }
+130 -3
View File
@@ -1,5 +1,5 @@
import { afterEach, beforeEach, describe, expect, it } from "vitest"; import { afterEach, beforeEach, describe, expect, it } from "vitest";
import { validateAgentApiKey } from "./apiKeys.ts"; import { formatApiKeyErrorSummary, isApiKeyAuthError, validateAgentApiKey } from "./apiKeys.ts";
const base = { const base = {
agent: { name: "opencode" }, agent: { name: "opencode" },
@@ -9,10 +9,23 @@ const base = {
const savedEnv = { ...process.env }; const savedEnv = { ...process.env };
// keys that count as provider auth in `knownApiKeys` and would let the
// auto-select path pass without our intent. strip all of them at test setup
// so each `it` starts from a clean slate regardless of what's in the dev `.env`.
const STRIPPED_PREFIXES_OR_NAMES = [
/_API_KEY$/,
/^CLAUDE_CODE_OAUTH_TOKEN$/,
/^AWS_BEARER_TOKEN_BEDROCK$/,
/^AWS_ACCESS_KEY_ID$/,
/^AWS_SECRET_ACCESS_KEY$/,
/^AWS_SESSION_TOKEN$/,
/^AWS_REGION$/,
/^BEDROCK_MODEL_ID$/,
];
beforeEach(() => { beforeEach(() => {
// strip all known provider keys so tests start clean
for (const key of Object.keys(process.env)) { for (const key of Object.keys(process.env)) {
if (key.endsWith("_API_KEY") || key === "CLAUDE_CODE_OAUTH_TOKEN") delete process.env[key]; if (STRIPPED_PREFIXES_OR_NAMES.some((re) => re.test(key))) delete process.env[key];
} }
}); });
@@ -73,4 +86,118 @@ describe("validateAgentApiKey", () => {
expect(() => validateAgentApiKey({ ...base, model: undefined })).toThrow("no API key found"); expect(() => validateAgentApiKey({ ...base, model: undefined })).toThrow("no API key found");
}); });
}); });
describe("bedrock routing slug", () => {
it("passes with AWS_BEARER_TOKEN_BEDROCK + AWS_REGION + BEDROCK_MODEL_ID", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.AWS_REGION = "us-east-1";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(() => validateAgentApiKey({ ...base, model: "bedrock/byok" })).not.toThrow();
});
it("passes with AWS access keys + region + model id", () => {
process.env.AWS_ACCESS_KEY_ID = "AKIA-test";
process.env.AWS_SECRET_ACCESS_KEY = "secret-test";
process.env.AWS_REGION = "us-east-1";
process.env.BEDROCK_MODEL_ID = "amazon.nova-pro-v1:0";
expect(() => validateAgentApiKey({ ...base, model: "bedrock/byok" })).not.toThrow();
});
it("throws when BEDROCK_MODEL_ID is missing", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.AWS_REGION = "us-east-1";
expect(() => validateAgentApiKey({ ...base, model: "bedrock/byok" })).toThrow(
"BEDROCK_MODEL_ID"
);
});
it("throws when AWS_REGION is missing", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(() => validateAgentApiKey({ ...base, model: "bedrock/byok" })).toThrow("AWS_REGION");
});
it("throws when no auth is set", () => {
process.env.AWS_REGION = "us-east-1";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(() => validateAgentApiKey({ ...base, model: "bedrock/byok" })).toThrow(
"AWS_BEARER_TOKEN_BEDROCK"
);
});
it("throws when only AWS_ACCESS_KEY_ID is set (missing secret)", () => {
process.env.AWS_ACCESS_KEY_ID = "AKIA-test";
process.env.AWS_REGION = "us-east-1";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-7";
expect(() => validateAgentApiKey({ ...base, model: "bedrock/byok" })).toThrow(
"AWS_BEARER_TOKEN_BEDROCK"
);
});
// regression: main.ts passes the resolved model into validateAgentApiKey
// (`payload.proxyModel ?? resolvedModel ?? payload.model`), which for
// bedrock is the raw AWS model ID and has no `/`. parseModel would throw.
// see PR #720 e2e run 25821218139 for the original failure mode.
it("accepts a raw Bedrock model ID (post-resolveModel) without throwing", () => {
process.env.AWS_BEARER_TOKEN_BEDROCK = "bedrock-token";
process.env.AWS_REGION = "us-east-1";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-6-v1";
expect(() =>
validateAgentApiKey({ ...base, model: "us.anthropic.claude-opus-4-6-v1" })
).not.toThrow();
});
it("throws on raw Bedrock model ID when AWS auth is missing", () => {
process.env.AWS_REGION = "us-east-1";
process.env.BEDROCK_MODEL_ID = "us.anthropic.claude-opus-4-6-v1";
expect(() =>
validateAgentApiKey({ ...base, model: "us.anthropic.claude-opus-4-6-v1" })
).toThrow("AWS_BEARER_TOKEN_BEDROCK");
});
});
});
describe("isApiKeyAuthError", () => {
it("matches the missing-key marker thrown by validateAgentApiKey", () => {
expect(isApiKeyAuthError("no API key found. Pullfrog needs ...")).toBe(true);
});
it("matches Claude CLI 401 strings", () => {
expect(isApiKeyAuthError("Invalid API key · Fix external API key")).toBe(true);
});
it("matches OpenAI / OpenRouter 401 phrasings", () => {
expect(isApiKeyAuthError("ProviderAuthError: User not found")).toBe(true);
expect(isApiKeyAuthError("401 Invalid authentication")).toBe(true);
});
it("ignores unrelated errors", () => {
expect(isApiKeyAuthError("git fetch failed")).toBe(false);
expect(isApiKeyAuthError("")).toBe(false);
});
});
describe("formatApiKeyErrorSummary", () => {
it("renders the missing-key body when the raw error contains the marker", () => {
const msg = formatApiKeyErrorSummary({
owner: "acme",
name: "repo",
raw: "no API key found in this run",
});
expect(msg).toContain("no API key found");
expect(msg).toContain("https://github.com/acme/repo/settings/secrets/actions");
expect(msg).toContain("/console/acme/repo");
expect(msg).toContain("https://discord.gg/8y96raFg8e");
});
it("renders the invalid-key body for any other auth error", () => {
const msg = formatApiKeyErrorSummary({
owner: "acme",
name: "repo",
raw: "Invalid API key · Fix external API key",
});
expect(msg).toContain("rejected (401)");
expect(msg).toContain("https://github.com/acme/repo/settings/secrets/actions");
expect(msg).toContain("https://discord.gg/8y96raFg8e");
});
}); });
+111 -14
View File
@@ -1,28 +1,46 @@
import { getModelEnvVars, providers } from "../models.ts"; import {
BEDROCK_MODEL_ID_ENV,
getModelEnvVars,
providers,
resolveDisplayAlias,
} from "../models.ts";
import { getApiUrl } from "./apiUrl.ts"; import { getApiUrl } from "./apiUrl.ts";
const knownApiKeys: Set<string> = new Set(Object.values(providers).flatMap((p) => [...p.envVars])); const knownApiKeys: Set<string> = new Set(Object.values(providers).flatMap((p) => [...p.envVars]));
/** marker prefix on the throw message for the catch-side reclassification path */
const MISSING_KEY_MARKER = "no API key found";
/** Markdown body used for both the thrown error and the formatted PR comment summary. */
function buildMissingApiKeyError(params: { owner: string; name: string }): string { function buildMissingApiKeyError(params: { owner: string; name: string }): string {
const apiUrl = getApiUrl(); const githubSecretsUrl = `https://github.com/${params.owner}/${params.name}/settings/secrets/actions`;
const settingsUrl = `${apiUrl}/console/${params.owner}/${params.name}`; const settingsUrl = `${getApiUrl()}/console/${params.owner}/${params.name}`;
const githubRepoUrl = `https://github.com/${params.owner}/${params.name}`; return [
const githubSecretsUrl = `${githubRepoUrl}/settings/secrets/actions`; `**${MISSING_KEY_MARKER}** — Pullfrog needs at least one LLM provider API key (e.g. \`ANTHROPIC_API_KEY\`, \`OPENAI_API_KEY\`, \`GEMINI_API_KEY\`) configured as a GitHub Actions secret.`,
"",
`[Open repo secrets →](${githubSecretsUrl}) · [Configure model →](${settingsUrl}) · [Setup docs →](https://docs.pullfrog.com/keys) · [Ask in Discord →](https://discord.gg/8y96raFg8e)`,
].join("\n");
}
return `no API key found. Pullfrog requires at least one LLM provider API key. function buildBedrockSetupError(params: {
owner: string;
name: string;
missing: string[];
}): string {
const githubSecretsUrl = `https://github.com/${params.owner}/${params.name}/settings/secrets/actions`;
to fix this, add the required secret to your GitHub repository: return `Bedrock model selected but required configuration is missing: ${params.missing.join(", ")}.
1. go to: ${githubSecretsUrl} add the missing secret(s) to your GitHub repository at ${githubSecretsUrl}, then reference them in your workflow's \`env:\` block:
2. click "New repository secret"
3. set the name to your provider's key (e.g., \`ANTHROPIC_API_KEY\`, \`OPENAI_API_KEY\`, \`GEMINI_API_KEY\`)
4. set the value to your API key
5. click "Add secret"
configure your model at ${settingsUrl} AWS_BEARER_TOKEN_BEDROCK: \${{ secrets.AWS_BEARER_TOKEN_BEDROCK }}
AWS_REGION: \${{ secrets.AWS_REGION }}
${BEDROCK_MODEL_ID_ENV}: \${{ secrets.${BEDROCK_MODEL_ID_ENV} }}
for full setup instructions, see https://docs.pullfrog.com/keys`; \`AWS_BEARER_TOKEN_BEDROCK\` may be substituted with \`AWS_ACCESS_KEY_ID\` + \`AWS_SECRET_ACCESS_KEY\` (and optional \`AWS_SESSION_TOKEN\`) if you prefer access keys.
for full setup instructions, see https://docs.pullfrog.com/bedrock`;
} }
function hasEnvVar(name: string): boolean { function hasEnvVar(name: string): boolean {
@@ -37,6 +55,22 @@ export function hasProviderKey(model: string): boolean {
return requiredVars.some((v) => hasEnvVar(v)); return requiredVars.some((v) => hasEnvVar(v));
} }
function validateBedrockSetup(params: { owner: string; name: string }): void {
const hasAuth =
hasEnvVar("AWS_BEARER_TOKEN_BEDROCK") ||
(hasEnvVar("AWS_ACCESS_KEY_ID") && hasEnvVar("AWS_SECRET_ACCESS_KEY"));
const missing: string[] = [];
if (!hasAuth)
missing.push("AWS_BEARER_TOKEN_BEDROCK (or AWS_ACCESS_KEY_ID + AWS_SECRET_ACCESS_KEY)");
if (!hasEnvVar("AWS_REGION")) missing.push("AWS_REGION");
if (!hasEnvVar(BEDROCK_MODEL_ID_ENV)) missing.push(BEDROCK_MODEL_ID_ENV);
if (missing.length > 0) {
throw new Error(buildBedrockSetupError({ owner: params.owner, name: params.name, missing }));
}
}
export function validateAgentApiKey(params: { export function validateAgentApiKey(params: {
agent: { name: string }; agent: { name: string };
model: string | undefined; model: string | undefined;
@@ -45,6 +79,28 @@ export function validateAgentApiKey(params: {
}): void { }): void {
// if a specific model is configured, only check that model's required env vars // if a specific model is configured, only check that model's required env vars
if (params.model) { if (params.model) {
// routing slugs (e.g. bedrock) get a tailored validation path because
// their auth shape doesn't match the standard "any one envVar present"
// rule (Bedrock needs auth + region + model-id, with auth being either
// a bearer token OR an access-key pair).
const alias = resolveDisplayAlias(params.model);
if (alias?.routing === "bedrock") {
validateBedrockSetup({ owner: params.owner, name: params.name });
return;
}
// upstream `resolveModel` translates `bedrock/byok` into the raw Bedrock
// model ID (e.g. `us.anthropic.claude-opus-4-6-v1`), which has no `/`
// and so isn't parseable as `provider/model`. these IDs only reach this
// function via routing aliases, so re-run the bedrock setup check rather
// than falling through to `getModelEnvVars` (which would throw inside
// parseModel). resolveModel itself already enforced BEDROCK_MODEL_ID,
// but auth + region are still validated here.
if (!params.model.includes("/")) {
validateBedrockSetup({ owner: params.owner, name: params.name });
return;
}
const requiredVars = getModelEnvVars(params.model); const requiredVars = getModelEnvVars(params.model);
// free models have no required env vars — skip validation entirely // free models have no required env vars — skip validation entirely
if (requiredVars.length === 0) return; if (requiredVars.length === 0) return;
@@ -59,3 +115,44 @@ export function validateAgentApiKey(params: {
throw new Error(buildMissingApiKeyError({ owner: params.owner, name: params.name })); throw new Error(buildMissingApiKeyError({ owner: params.owner, name: params.name }));
} }
} }
/**
* Detect agent-runtime auth failures that should be reformatted as an actionable
* key-fix CTA before being shown to the user. Covers the two shapes we see:
* - missing key (validateAgentApiKey throw): contains MISSING_KEY_MARKER
* - revoked / invalid key (Claude CLI 401 surfaced via api_error_status):
* "Invalid API key · Fix external API key" + similar provider variants
*/
export function isApiKeyAuthError(text: string): boolean {
if (!text) return false;
return (
text.includes(MISSING_KEY_MARKER) ||
/Invalid API key/i.test(text) ||
/\bUser not found\b/i.test(text) ||
/\bInvalid authentication\b/i.test(text)
);
}
/**
* Friendly Markdown summary for both the missing-key and invalid-key cases.
* Used in the catch / result-failure paths in `main.ts` to overwrite the raw
* agent error before it's posted to the PR progress comment.
*/
export function formatApiKeyErrorSummary(params: {
owner: string;
name: string;
raw: string;
}): string {
if (params.raw.includes(MISSING_KEY_MARKER)) {
return buildMissingApiKeyError({ owner: params.owner, name: params.name });
}
const githubSecretsUrl = `https://github.com/${params.owner}/${params.name}/settings/secrets/actions`;
const settingsUrl = `${getApiUrl()}/console/${params.owner}/${params.name}`;
return [
`**Your LLM provider API key was rejected (401).** Rotate the key in your provider dashboard, then update the matching GitHub Actions secret.`,
"",
`[Update repo secret →](${githubSecretsUrl}) · [Model settings →](${settingsUrl}) · [Setup docs →](https://docs.pullfrog.com/keys) · [Ask in Discord →](https://discord.gg/8y96raFg8e)`,
].join("\n");
}
+53 -10
View File
@@ -4,6 +4,7 @@ import { encode as toonEncode } from "@toon-format/toon";
import { type AgentId, formatMcpToolRef, type PayloadEvent, pullfrogMcpName } from "../external.ts"; import { type AgentId, formatMcpToolRef, type PayloadEvent, pullfrogMcpName } from "../external.ts";
import type { Mode } from "../modes.ts"; import type { Mode } from "../modes.ts";
import type { ResolvedPayload } from "./payload.ts"; import type { ResolvedPayload } from "./payload.ts";
import type { LearningsHeading } from "./runContext.ts";
import type { RunContextData } from "./runContextData.ts"; import type { RunContextData } from "./runContextData.ts";
interface InstructionsContext { interface InstructionsContext {
@@ -16,6 +17,10 @@ interface InstructionsContext {
* couldn't be seeded for some reason. main.ts always seeds, so in * couldn't be seeded for some reason. main.ts always seeds, so in
* practice this is always set; the null case keeps the type honest. */ * practice this is always set; the null case keeps the type honest. */
learningsFilePath: string | null; learningsFilePath: string | null;
/** server-parsed TOC for the body of the learnings tmpfile. rendered
* inline into the LEARNINGS prompt section so the agent can `read_file`
* targeted line ranges instead of pulling the whole file into context. */
learningsHeadings: LearningsHeading[];
} }
interface PromptContext extends InstructionsContext { interface PromptContext extends InstructionsContext {
@@ -369,6 +374,39 @@ export interface ResolvedInstructions {
runtime: string; runtime: string;
} }
/** render the heading list as an indented bullet TOC. ranges shown in
* parentheses (`(L3-L18)`); the start line is always the heading line
* itself, so reading the listed range gives the agent the heading +
* body together. shallowest heading depth in the body sits at the root
* column; deeper levels indent by `(depth - rootDepth) * 2` spaces. */
export function renderLearningsToc(headings: LearningsHeading[]): string {
if (headings.length === 0) return "";
const rootDepth = Math.min(...headings.map((h) => h.depth));
return headings
.map((h) => {
const indent = " ".repeat((h.depth - rootDepth) * 2);
return `${indent}- ${h.title} (L${h.startLine}-L${h.endLine})`;
})
.join("\n");
}
/** assemble the LEARNINGS prompt section: file path + intro + either
* the rendered heading TOC (when the body has structure) or a no-headings
* affordance pointing the agent at the reflection turn for restructuring.
* empty string when the seed step failed and there's no path to surface. */
export function buildLearningsSection(ctx: {
filePath: string | null;
headings: LearningsHeading[];
}): string {
if (!ctx.filePath) return "";
const intro = `Repo-level learnings accumulated by previous agent runs live at \`${ctx.filePath}\`. Use this file as durable context (test commands, conventions, gotchas, architecture notes).`;
const tocBody =
ctx.headings.length === 0
? "(no headings yet — file is empty or a flat list. read the whole file. during the post-run reflection turn, structure it with `## ` / `### ` headings so future runs can read targeted ranges.)"
: `Read targeted line ranges via your native file tool — do NOT slurp the whole file. Each range starts at the section heading line, so reading the range gives you heading + body together.\n\n${renderLearningsToc(ctx.headings)}`;
return `************* LEARNINGS *************\n\n${intro}\n\n${tocBody}`;
}
function assembleFullPrompt(ctx: { function assembleFullPrompt(ctx: {
toc: string; toc: string;
task: string; task: string;
@@ -376,17 +414,18 @@ function assembleFullPrompt(ctx: {
eventContext: string; eventContext: string;
system: string; system: string;
learningsFilePath: string | null; learningsFilePath: string | null;
learningsHeadings: LearningsHeading[];
runtime: string; runtime: string;
}): string { }): string {
// the LEARNINGS section is intentionally tiny — just the file path and a // server-parsed TOC is rendered inline so the agent can target line
// one-line "read it" instruction. embedding the contents would re-inflate // ranges via its native file tool. the file body itself is never
// the prompt every run (the previous design's failure mode) and clutter // inlined — that would re-inflate context every run and clutter CI
// CI logs. the agent reads the file with its native file tool; the // logs. post-run reflection (action/agents/postRun.ts) is where
// post-run reflection turn (action/agents/postRun.ts) is where editing // editing is encouraged.
// is encouraged, with the prune-stale framing. const learningsSection = buildLearningsSection({
const learningsSection = ctx.learningsFilePath filePath: ctx.learningsFilePath,
? `************* LEARNINGS *************\n\nRepo-level learnings accumulated by previous agent runs live at \`${ctx.learningsFilePath}\`. Read this file early and let the entries inform your approach (test commands, conventions, gotchas, etc.). The file may be empty if no learnings have been collected yet.` headings: ctx.learningsHeadings,
: ""; });
const runtimeSection = `************* RUNTIME *************\n\n${ctx.runtime}`; const runtimeSection = `************* RUNTIME *************\n\n${ctx.runtime}`;
@@ -421,7 +460,10 @@ export function resolveInstructions(ctx: InstructionsContext): ResolvedInstructi
tocEntries.push({ label: "EVENT CONTEXT", description: "related PR/issue data" }); tocEntries.push({ label: "EVENT CONTEXT", description: "related PR/issue data" });
tocEntries.push({ label: "SYSTEM", description: "persona, security, tools, workflow rules" }); tocEntries.push({ label: "SYSTEM", description: "persona, security, tools, workflow rules" });
if (pctx.learningsFilePath) if (pctx.learningsFilePath)
tocEntries.push({ label: "LEARNINGS", description: "repo-specific knowledge file path" }); tocEntries.push({
label: "LEARNINGS",
description: "repo-specific knowledge file path + heading TOC",
});
tocEntries.push({ label: "RUNTIME", description: "environment metadata" }); tocEntries.push({ label: "RUNTIME", description: "environment metadata" });
const toc = buildToc(tocEntries); const toc = buildToc(tocEntries);
@@ -433,6 +475,7 @@ export function resolveInstructions(ctx: InstructionsContext): ResolvedInstructi
eventContext, eventContext,
system, system,
learningsFilePath: pctx.learningsFilePath, learningsFilePath: pctx.learningsFilePath,
learningsHeadings: pctx.learningsHeadings,
runtime: pctx.runtime, runtime: pctx.runtime,
}); });
+45 -28
View File
@@ -1,4 +1,4 @@
import { mkdtemp, rm, writeFile } from "node:fs/promises"; import { mkdtemp, readFile, rm, writeFile } from "node:fs/promises";
import { tmpdir } from "node:os"; import { tmpdir } from "node:os";
import { join } from "node:path"; import { join } from "node:path";
import { afterEach, beforeEach, describe, expect, it } from "vitest"; import { afterEach, beforeEach, describe, expect, it } from "vitest";
@@ -20,51 +20,68 @@ describe("learnings tmpfile round-trip", () => {
await rm(dir, { recursive: true, force: true }); await rm(dir, { recursive: true, force: true });
}); });
it("seeds with existing learnings and reads them back verbatim", async () => { it("writes the verbatim DB body to disk and reads it back unchanged", async () => {
const current = "- run tests with `pnpm -r test`\n- default branch is `main`"; const current = [
"## Build & test",
"",
"- run tests with `pnpm -r test`",
"",
"## Architecture",
"",
"- workers in `worker/`",
].join("\n");
const path = await seedLearningsFile({ tmpdir: dir, current }); const path = await seedLearningsFile({ tmpdir: dir, current });
expect(path).toBe(learningsFilePath(dir)); expect(path).toBe(learningsFilePath(dir));
expect(path.endsWith(LEARNINGS_FILE_NAME)).toBe(true); expect(path.endsWith(LEARNINGS_FILE_NAME)).toBe(true);
const read = await readLearningsFile(path);
expect(read).toBe(current); expect(await readFile(path, "utf8")).toBe(current);
expect(await readLearningsFile(path)).toBe(current);
}); });
it("seeds an empty file when the repo has no learnings yet", async () => { it("seeds an empty file when the repo has no learnings yet, round-trip is empty string", async () => {
// empty seed (vs scaffold-with-comment) keeps the byte-trim equality
// gate clean: an untouched first run reads back as "" and persistLearnings
// skips the API round-trip rather than writing a placeholder string into
// Repo.learnings.
const path = await seedLearningsFile({ tmpdir: dir, current: null }); const path = await seedLearningsFile({ tmpdir: dir, current: null });
const read = await readLearningsFile(path); expect(await readFile(path, "utf8")).toBe("");
expect(read).toBe(""); expect(await readLearningsFile(path)).toBe("");
}); });
it("returns null when the file is missing (treated as no-change by persist)", async () => { it("returns null when the file is missing (treated as no-change by persist)", async () => {
const path = learningsFilePath(dir); expect(await readLearningsFile(learningsFilePath(dir))).toBeNull();
const read = await readLearningsFile(path);
expect(read).toBeNull();
}); });
it("trims whitespace so trailing newlines never trigger a spurious PATCH", async () => { it("trims trailing whitespace so editor newlines never trigger a spurious PATCH", async () => {
// editors commonly add a trailing newline on save. without trimming, a const current = "## Build & test\n\n- one fact";
// round-trip "read seed → save unchanged" would fail byte-equality and
// burn a LearningsRevision row on every run.
const current = "- one fact";
const path = await seedLearningsFile({ tmpdir: dir, current }); const path = await seedLearningsFile({ tmpdir: dir, current });
await writeFile(path, `${current}\n\n `, "utf8"); await writeFile(path, `${current}\n\n `, "utf8");
const read = await readLearningsFile(path); expect(await readLearningsFile(path)).toBe(current);
expect(read).toBe(current);
}); });
it("truncates content over the 10k server-side cap", async () => { it("truncates over-cap bodies at the last newline boundary so the next-seed TOC parse stays clean", async () => {
// server enforces MAX_LEARNINGS_LENGTH = 10_000. truncating client-side const padding = `${"x".repeat(80)}\n`.repeat(1300);
// avoids a 400 round-trip and keeps the bytes the agent will see in the const oversized = `## Build & test\n\n${padding}`;
// next run aligned with what the server actually stored.
const oversized = "x".repeat(11_000);
const path = await seedLearningsFile({ tmpdir: dir, current: null }); const path = await seedLearningsFile({ tmpdir: dir, current: null });
await writeFile(path, oversized, "utf8"); await writeFile(path, oversized, "utf8");
const read = await readLearningsFile(path); const read = await readLearningsFile(path);
expect(read).toBeTruthy(); expect(read).toBeTruthy();
expect(read?.length).toBe(10_000); expect(read?.length).toBeLessThanOrEqual(100_000);
const tailLine = read?.split("\n").pop() ?? "";
expect(/^x+$/.test(tailLine)).toBe(true);
expect(tailLine.length).toBe(80);
});
it("falls back to a hard truncate when the only newline is far above the cap (giant single line)", async () => {
const oversized = `## Build & test\n${"x".repeat(110_000)}`;
const path = await seedLearningsFile({ tmpdir: dir, current: null });
await writeFile(path, oversized, "utf8");
const read = await readLearningsFile(path);
expect(read).toBeTruthy();
expect(read?.length).toBe(100_000);
expect(read?.startsWith("## Build & test\n")).toBe(true);
});
it("preserves legacy free-text without scaffolding or wrapping", async () => {
const legacy = "- this is some old free-text bullet\n- another one";
const path = await seedLearningsFile({ tmpdir: dir, current: legacy });
expect(await readFile(path, "utf8")).toBe(legacy);
expect(await readLearningsFile(path)).toBe(legacy);
}); });
}); });
+44 -18
View File
@@ -7,47 +7,75 @@ import { dirname, join } from "node:path";
* back into future runs as durable context. Modeled on the PR-summary tmpfile * back into future runs as durable context. Modeled on the PR-summary tmpfile
* pattern (see action/utils/prSummary.ts): * pattern (see action/utils/prSummary.ts):
* *
* 1. server seeds `pullfrog-learnings.md` from `Repo.learnings` (or empty * 1. server seeds `pullfrog-learnings.md` with the verbatim body of
* when the repo has none yet) * `Repo.learnings` (or empty for fresh repos), and parses headings
* 2. the agent reads the file at startup as part of its context, and may * server-side (`utils/learningsToc.ts`) the parsed TOC is rendered
* edit it in place at end-of-run when prompted by the reflection turn * into the LEARNINGS prompt section, not into the file
* 3. main.ts reads the file back at end-of-run and PATCHes * 2. the agent reads the TOC in the prompt and uses listed line ranges
* `/api/repo/[owner]/[repo]/learnings` if it changed (byte-trim equality * to read just the sections relevant to the current task file can
* against the seed determines change detection) * grow large, but only targeted ranges hit the agent's context
* 3. agent edits the file in place at end-of-run during the reflection
* turn (see action/agents/postRun.ts buildLearningsReflectionPrompt)
* 4. main.ts reads the file back at end-of-run and PATCHes
* `/api/repo/[owner]/[repo]/learnings` if the body changed
* *
* Edit-in-place avoids stuffing the entire learnings list into both the * Edit-in-place avoids stuffing the entire learnings list into both the
* prompt context and an `update_learnings` MCP tool call (which previously * prompt context and an `update_learnings` MCP tool call (which previously
* required passing the FULL merged list as a string parameter an * required passing the FULL merged list as a string parameter an
* output-token tax that grew linearly with the learnings size). * output-token tax that grew linearly with the learnings size).
*
* Section structure is agent-curated. The reflection prompt teaches
* hierarchy + a soft 300-line-per-section cap to keep TOC ranges
* agent-targetable on long-lived repos; there is no fixed taxonomy.
*/ */
export const LEARNINGS_FILE_NAME = "pullfrog-learnings.md"; export const LEARNINGS_FILE_NAME = "pullfrog-learnings.md";
/** server-side cap mirrors `MAX_LEARNINGS_LENGTH` in /** server-side cap mirrors `MAX_LEARNINGS_LENGTH` in
* `app/api/repo/[owner]/[repo]/learnings/route.ts`. truncating client-side * `app/api/repo/[owner]/[repo]/learnings/route.ts`. truncating client-side
* keeps the PATCH from being rejected with a 400. */ * keeps the PATCH from being rejected with a 400. raised from 10k 100k
const MAX_LEARNINGS_LENGTH = 10_000; * once the TOC affordance landed: with line-range reads via the
* server-parsed TOC the agent doesn't ingest the whole file, so the cap
* can grow to whatever curation discipline allows. 100k holds ~400-500
* short bullets. */
const MAX_LEARNINGS_LENGTH = 100_000;
export function learningsFilePath(tmpdir: string): string { export function learningsFilePath(tmpdir: string): string {
return join(tmpdir, LEARNINGS_FILE_NAME); return join(tmpdir, LEARNINGS_FILE_NAME);
} }
/** seed the learnings file with the repo's current learnings, or an empty /** seed the rolling learnings tmpfile with the verbatim DB body (or empty
* file when the repo has none yet. returns the absolute path. */ * string for fresh repos). returns the absolute path. the parsed TOC is
* carried separately via `RepoSettings.learningsHeadings` and rendered
* into the prompt by `resolveInstructions`, so the file on disk is just
* the body no markers, no scaffold, no in-file TOC. */
export async function seedLearningsFile(params: { export async function seedLearningsFile(params: {
tmpdir: string; tmpdir: string;
current: string | null; current: string | null;
}): Promise<string> { }): Promise<string> {
const path = learningsFilePath(params.tmpdir); const path = learningsFilePath(params.tmpdir);
await mkdir(dirname(path), { recursive: true }); await mkdir(dirname(path), { recursive: true });
// empty file when no learnings exist yet — the agent reads it, sees
// nothing, and the LEARNINGS prompt section explains what the file is for.
// a header comment would risk being persisted as part of the first real
// edit, polluting the DB row with placeholder text.
await writeFile(path, params.current ?? "", "utf8"); await writeFile(path, params.current ?? "", "utf8");
return path; return path;
} }
/** truncate at the last newline boundary before `cap` so we don't leave
* a partial line at the tail (a half-truncated `## Headi` confuses the
* server's next-seed TOC parse and shrinks visible structure). falls
* back to a hard `slice` when the line boundary would discard a large
* run of content i.e. when the tail of `head` is one giant line (rare:
* minified pastes, fenced log dumps). losing a partial last line is
* preferable to losing kilobytes of body. */
const TRUNCATION_LINE_BOUNDARY_TOLERANCE = 4096;
function truncateAtLineBoundary(body: string, cap: number): string {
if (body.length <= cap) return body;
const head = body.slice(0, cap);
const lastNewline = head.lastIndexOf("\n");
if (lastNewline <= 0) return head;
if (cap - lastNewline > TRUNCATION_LINE_BOUNDARY_TOLERANCE) return head;
return head.slice(0, lastNewline);
}
/** read the agent-edited learnings file. returns null when the file is /** read the agent-edited learnings file. returns null when the file is
* missing or unreadable (treated as "no change"). caps content at the * missing or unreadable (treated as "no change"). caps content at the
* server's max length to avoid a 400 round-trip. */ * server's max length to avoid a 400 round-trip. */
@@ -58,7 +86,5 @@ export async function readLearningsFile(path: string): Promise<string | null> {
} catch { } catch {
return null; return null;
} }
const trimmed = raw.trim(); return truncateAtLineBoundary(raw.trim(), MAX_LEARNINGS_LENGTH);
if (trimmed.length > MAX_LEARNINGS_LENGTH) return trimmed.slice(0, MAX_LEARNINGS_LENGTH);
return trimmed;
} }
+99
View File
@@ -0,0 +1,99 @@
import { describe, expect, it } from "vitest";
import { buildLearningsSection, renderLearningsToc } from "./instructions.ts";
import type { LearningsHeading } from "./runContext.ts";
const h = (depth: 1 | 2 | 3 | 4 | 5 | 6, title: string, startLine: number, endLine: number) => ({
depth,
title,
startLine,
endLine,
});
describe("renderLearningsToc", () => {
it("renders flat h2 list with parenthesized ranges, no hashes or backticks", () => {
const headings: LearningsHeading[] = [
h(2, "Build & test", 1, 18),
h(2, "Architecture", 19, 60),
];
expect(renderLearningsToc(headings)).toBe(
`- Build & test (L1-L18)
- Architecture (L19-L60)`
);
});
it("indents deeper headings 2 spaces per depth level past the shallowest", () => {
const headings: LearningsHeading[] = [
h(2, "Build & test", 1, 42),
h(3, "Local", 3, 18),
h(3, "CI", 19, 42),
h(2, "Architecture", 43, 210),
h(3, "Background workers", 80, 210),
];
expect(renderLearningsToc(headings)).toBe(
`- Build & test (L1-L42)
- Local (L3-L18)
- CI (L19-L42)
- Architecture (L43-L210)
- Background workers (L80-L210)`
);
});
it("treats the shallowest depth as the root column when no h2 is present", () => {
const headings: LearningsHeading[] = [h(3, "Only h3", 1, 5), h(4, "Sub h4", 2, 5)];
expect(renderLearningsToc(headings)).toBe(
`- Only h3 (L1-L5)
- Sub h4 (L2-L5)`
);
});
it("supports depths up through h6 with stable 2-space indent steps", () => {
const headings: LearningsHeading[] = [
h(2, "Two", 1, 10),
h(3, "Three", 2, 10),
h(4, "Four", 3, 10),
h(5, "Five", 4, 10),
h(6, "Six", 5, 10),
];
expect(renderLearningsToc(headings)).toBe(
`- Two (L1-L10)
- Three (L2-L10)
- Four (L3-L10)
- Five (L4-L10)
- Six (L5-L10)`
);
});
});
describe("buildLearningsSection", () => {
it("returns empty string when no file path (seed step failed)", () => {
expect(buildLearningsSection({ filePath: null, headings: [] })).toBe("");
});
it("renders the no-headings affordance when the body has no structure", () => {
const out = buildLearningsSection({
filePath: "/tmp/run-1/pullfrog-learnings.md",
headings: [],
});
expect(out).toContain("************* LEARNINGS *************");
expect(out).toContain("/tmp/run-1/pullfrog-learnings.md");
expect(out).toContain("no headings yet");
expect(out).toContain("structure it with");
// does not include a TOC list when there are no headings
expect(out).not.toMatch(/\(L\d+-L\d+\)/);
});
it("renders the TOC inline with the file path and heading guidance", () => {
const out = buildLearningsSection({
filePath: "/tmp/run-1/pullfrog-learnings.md",
headings: [h(2, "Build & test", 1, 18), h(2, "Architecture", 19, 60)],
});
expect(out).toContain("************* LEARNINGS *************");
expect(out).toContain("/tmp/run-1/pullfrog-learnings.md");
expect(out).toContain("- Build & test (L1-L18)");
expect(out).toContain("- Architecture (L19-L60)");
expect(out).toContain("Each range starts at the section heading line");
// explicit "no hashes, no backticks" in the rendered list
expect(out).not.toContain("- `## Build");
expect(out).not.toContain("`## Build");
});
});
+19
View File
@@ -9,6 +9,22 @@ export interface Mode {
prompt: string; prompt: string;
} }
/**
* server-parsed TOC entry for `Repo.learnings`. depth is 1-6 (h1-h6),
* line numbers are 1-indexed against the raw body. computed by
* `parseLearningsHeadings` in `utils/learningsToc.ts` (server side) and
* shipped over the run-context JSON boundary; the canonical declaration
* lives there. duplicated here because the action runtime can't reach
* across into the proprietary root-level codebase, and the JSON wire
* means typecheck can't enforce shape equality across both sides.
*/
export interface LearningsHeading {
depth: 1 | 2 | 3 | 4 | 5 | 6;
title: string;
startLine: number;
endLine: number;
}
export interface RepoSettings { export interface RepoSettings {
model: string | null; model: string | null;
modes: Mode[]; modes: Mode[];
@@ -21,6 +37,7 @@ export interface RepoSettings {
prApproveEnabled: boolean; prApproveEnabled: boolean;
modeInstructions: Record<string, string>; modeInstructions: Record<string, string>;
learnings: string | null; learnings: string | null;
learningsHeadings: LearningsHeading[];
envAllowlist: string | null; envAllowlist: string | null;
} }
@@ -61,6 +78,7 @@ const defaultSettings: RepoSettings = {
prApproveEnabled: false, prApproveEnabled: false,
modeInstructions: {}, modeInstructions: {},
learnings: null, learnings: null,
learningsHeadings: [],
envAllowlist: null, envAllowlist: null,
}; };
@@ -127,6 +145,7 @@ export async function fetchRunContext(params: {
postCheckoutScript: data.settings?.postCheckoutScript ?? null, postCheckoutScript: data.settings?.postCheckoutScript ?? null,
prepushScript: data.settings?.prepushScript ?? null, prepushScript: data.settings?.prepushScript ?? null,
stopScript: data.settings?.stopScript ?? null, stopScript: data.settings?.stopScript ?? null,
learningsHeadings: data.settings?.learningsHeadings ?? [],
}, },
apiToken: data.apiToken, apiToken: data.apiToken,
oss: data.oss ?? false, oss: data.oss ?? false,